diff mbox series

[v1,1/1] misc/mei/hdcp: Use correct macros to initialize uuid_le

Message ID 20221228160500.21220-1-andriy.shevchenko@linux.intel.com
State New
Headers
Series [v1,1/1] misc/mei/hdcp: Use correct macros to initialize uuid_le |

Commit Message

Andy Shevchenko Dec. 28, 2022, 4:05 p.m. UTC 
  GUID_INIT() is for internal guid_t type and shouldn't be used
for the uuid_le. I.o.w. relying on the implementation details
is layering violation. Use correct macros to initialize uuid_le.

Fixes: 64e9bbdd9588 ("misc/mei/hdcp: Client driver for HDCP application")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/misc/mei/hdcp/mei_hdcp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tomas Winkler Jan. 1, 2023, 12:27 p.m. UTC | #1 
> 
> GUID_INIT() is for internal guid_t type and shouldn't be used for the uuid_le.
> I.o.w. relying on the implementation details is layering violation. Use correct
> macros to initialize uuid_le.
> 
> Fixes: 64e9bbdd9588 ("misc/mei/hdcp: Client driver for HDCP application")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  drivers/misc/mei/hdcp/mei_hdcp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c
> b/drivers/misc/mei/hdcp/mei_hdcp.c
> index 5a1c93a2d2f1..cc7f1169206c 100644
> --- a/drivers/misc/mei/hdcp/mei_hdcp.c
> +++ b/drivers/misc/mei/hdcp/mei_hdcp.c
> @@ -858,8 +858,8 @@ static void mei_hdcp_remove(struct mei_cl_device
> *cldev)
>  		dev_warn(&cldev->dev, "mei_cldev_disable() failed\n");  }
> 
> -#define MEI_UUID_HDCP GUID_INIT(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
> -				0x52, 0xD1, 0xC5, 0x4B, 0x62, 0x7F, 0x04)
> +#define MEI_UUID_HDCP UUID_LE(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
> +			      0x52, 0xD1, 0xC5, 0x4B, 0x62, 0x7F, 0x04)
> 
>  static const struct mei_cl_device_id mei_hdcp_tbl[] = {
>  	{ .uuid = MEI_UUID_HDCP, .version = MEI_CL_VERSION_ANY },
> --
> 2.35.1
diff mbox series

Patch

diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c
index 5a1c93a2d2f1..cc7f1169206c 100644
--- a/drivers/misc/mei/hdcp/mei_hdcp.c
+++ b/drivers/misc/mei/hdcp/mei_hdcp.c
@@ -858,8 +858,8 @@  static void mei_hdcp_remove(struct mei_cl_device *cldev)
 		dev_warn(&cldev->dev, "mei_cldev_disable() failed\n");
 }
 
-#define MEI_UUID_HDCP GUID_INIT(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
-				0x52, 0xD1, 0xC5, 0x4B, 0x62, 0x7F, 0x04)
+#define MEI_UUID_HDCP UUID_LE(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
+			      0x52, 0xD1, 0xC5, 0x4B, 0x62, 0x7F, 0x04)
 
 static const struct mei_cl_device_id mei_hdcp_tbl[] = {
 	{ .uuid = MEI_UUID_HDCP, .version = MEI_CL_VERSION_ANY },