From patchwork Wed Dec 28 09:49:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 37158 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1807369wrt; Wed, 28 Dec 2022 01:52:02 -0800 (PST) X-Google-Smtp-Source: AMrXdXvTSRAHxcwvGChzFn2aj9Ga8FkGjMU3CcGr4DjUgnnugauaqOh2ZvYyshh14S0povNkg7zy X-Received: by 2002:a05:6402:43cf:b0:461:8a1a:271f with SMTP id p15-20020a05640243cf00b004618a1a271fmr26846442edc.11.1672221122637; Wed, 28 Dec 2022 01:52:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672221122; cv=none; d=google.com; s=arc-20160816; b=vBpyt4uIfOp1HO7hQru7g1rY4RpnLV0kFmGGRfKy6Ot9GzhuGJnjtXFHHwzZZsw6ou lRYScPw09+hFKr2VK3waJvrVNvQLXs0u5VFvhGYyzNLSe1m34WCG4qYYEZwYERD0F435 A6Fx9E2QrAt7UXjEv7pOI4gEDDmbJlI6oEsKfpZsVBibRnybcO8zLugZMxxa62HuX4Gr yms8Mln7AqwuslWATab+n/sgUL+h6omXqnhPQp9CnQiHKFH5DLwOEyuCY9AVFqN0RWJW hinP5QjBT1JFAE0cpw0FI+RUuWG95pKhmQxQeftJ3s4SyJ/nXb7O3gurbiI8lGRUk/si 8uWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Of1SwCpBKO4q8x30QhAiKMUGkGoz/h3vos+nuouvtiY=; b=DIF9P5ATCJCsklzk9GWKf+xm5CcKYOL6172Py9hUVIMy/sepSAHCjmiQ9bC1FBN0zv /WBXXeStjmgXZzmdO7cRgN5Nke6id7CS4EZzAkeHXukiNrZ0fYMjm5umhAtJIDXcFu3Y hbQLaOa9D0k1W2jTw6/kKbvHsIXhxDI7aOHF9S1WvddvTkVoBbFNZ+JU6Z3UMjHqEXh0 O+GCsO+puqStqic3x2oYGrHi4ECAQ/B2AnsJZpeW/wQZst2hHXmq7szUycLtVIHI9oku wcp3evk1rTOLGPcp2+b7o2nnQ/qjktmIiHHqnoKarPpnCdenE7WjEpewDdkUAj/NBV/S oaYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HdS1jKmv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d4-20020aa7d684000000b0046ab036c18esi11217808edr.606.2022.12.28.01.51.38; Wed, 28 Dec 2022 01:52:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HdS1jKmv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232868AbiL1JtV (ORCPT + 99 others); Wed, 28 Dec 2022 04:49:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232714AbiL1JtD (ORCPT ); Wed, 28 Dec 2022 04:49:03 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB722F01B; Wed, 28 Dec 2022 01:49:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672220942; x=1703756942; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jTREtm4c31COf+aa5sKKx8GFXjmF+LQu9JNMP099WX8=; b=HdS1jKmvXq0TvE9cgC5E33r9GFweeZB2hFYdTtlcSeCa5L302IhBEKl0 jYia6dTyhuo//WAsCBT1RERuPH98q29Hrpw9jKROha+7FaZhToR54ZK0f dM/ZubpJAePtWVNl9tSSCEc4dvvsUIDQtqClUa20HRKhSgJ936mZx9SlR KYlMZLOFb27ZQwI/xr1OM1d07URMJj3h5XBVIAEDao9gvDMpP7KGOLm0V fsJ5/3Fi4KCw+9ky02/EWW1qAto7QvPBmlRJIdB7/B9+hjkVszyaKXG19 Qp3U0+1rDF9FlFnwWPlSHFys4GBCtpToQluBUIHEJ6lfz3K6upwA7r01E A==; X-IronPort-AV: E=McAfee;i="6500,9779,10573"; a="322823324" X-IronPort-AV: E=Sophos;i="5.96,280,1665471600"; d="scan'208";a="322823324" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Dec 2022 01:49:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10573"; a="685655148" X-IronPort-AV: E=Sophos;i="5.96,280,1665471600"; d="scan'208";a="685655148" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 28 Dec 2022 01:48:58 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 38D25159; Wed, 28 Dec 2022 11:49:29 +0200 (EET) From: Andy Shevchenko To: Greg Kroah-Hartman , Sakari Ailus , Heikki Krogerus , Andy Shevchenko , Daniel Scally , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Cc: "Rafael J. Wysocki" , Yong Zhi , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Daniel Scally Subject: [PATCH v3 1/4] media: ipu3-cio2: Don't dereference fwnode handle Date: Wed, 28 Dec 2022 11:49:19 +0200 Message-Id: <20221228094922.84119-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221228094922.84119-1-andriy.shevchenko@linux.intel.com> References: <20221228094922.84119-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753450936276653267?= X-GMAIL-MSGID: =?utf-8?q?1753450936276653267?= Use acpi_fwnode_handle() instead of dereferencing an fwnode handle directly, which is a better coding practice. Signed-off-by: Andy Shevchenko Acked-by: Sakari Ailus Tested-by: Daniel Scally Acked-by: Heikki Krogerus Reviewed-by: Daniel Scally --- drivers/media/pci/intel/ipu3/cio2-bridge.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/intel/ipu3/cio2-bridge.c b/drivers/media/pci/intel/ipu3/cio2-bridge.c index df6c94da2f6a..18974a72e94a 100644 --- a/drivers/media/pci/intel/ipu3/cio2-bridge.c +++ b/drivers/media/pci/intel/ipu3/cio2-bridge.c @@ -263,7 +263,7 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg, struct cio2_bridge *bridge, struct pci_dev *cio2) { - struct fwnode_handle *fwnode; + struct fwnode_handle *fwnode, *primary; struct cio2_sensor *sensor; struct acpi_device *adev; acpi_status status; @@ -322,7 +322,9 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg, } sensor->adev = acpi_dev_get(adev); - adev->fwnode.secondary = fwnode; + + primary = acpi_fwnode_handle(adev); + primary->secondary = fwnode; cio2_bridge_instantiate_vcm_i2c_client(sensor);