From patchwork Wed Dec 28 08:40:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 37150 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1793123wrt; Wed, 28 Dec 2022 01:10:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXt8MA4NOfRDVhbiv89ZlEgYILiIzg/JZ1A2x/3R7R4bxHDEPx7mZFNx6qWVs5yReRd1NbjP X-Received: by 2002:a17:906:9519:b0:836:3d32:2cf9 with SMTP id u25-20020a170906951900b008363d322cf9mr20123749ejx.55.1672218623742; Wed, 28 Dec 2022 01:10:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672218623; cv=none; d=google.com; s=arc-20160816; b=hUnDWNWcpCLjMLLso/Zc0S3BT0MPzGWnFtybQMzBlwmZ/Du1yToZVwS3+FA+EbEpUN S6Di4poQqCP9C/o6DbJoRY4EZYoFYm0o4+CBuEm6Vkk/To225A2PlTbsSoNqQvnk76D0 LJm7H9JobSCoWgCrLmgasklWtYAMmZxcu07qRV35XNbVPaH5OvZYWHSjIaZXuIParUYs w11OiHC24DMUMar+dsq5Bso19NmPVcQUiVtEvegPMsCoQ8mGqwIIYZQAdpApWvaU2mBt pzInWbTKv1W3Snr+U2QuagiPvlMdpN9QFcP31BrlBlrXoaiWu9S8kb3uyH1DodPVo566 Hxgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=t4t3wjs91jqYDdhcaBgIoHHF665G49/NIuIJvlGrcfA=; b=qZYCzoHv88DhkuNC3yl7aLQfLExveSoyaN/CS3spFLt8xYTH9unuKsz5rT1HZULDpu LwsSze8SMn3WfR9rGznixXhApJZgXnCluQowYc2sqQhLa1ymFS25QlkLpCtebilnzsp/ oAMICZls4PgjElyPJ2mU/hjKQAIvYIKgEziWIH8aazP0cwCHVyqbIlJhaR0QE1iUU3BD NaTU4WieWYlRneTzOaDGPJXDZX5bCttZGnJfx5CZ3JrPyoOROd8qclB3voWMV+Vq8FFN X0l5HKT/M9OYD8YpQgIHjMPDJjH/O4xnQeZsLNM59DKmqnxXlLIMT28rIYKAFGEbeceD +ZJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=imJgc7Ix; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga23-20020a1709070c1700b00829e391ba03si14233736ejc.38.2022.12.28.01.10.00; Wed, 28 Dec 2022 01:10:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=imJgc7Ix; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232848AbiL1Iox (ORCPT + 99 others); Wed, 28 Dec 2022 03:44:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232810AbiL1Inu (ORCPT ); Wed, 28 Dec 2022 03:43:50 -0500 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B70210565 for ; Wed, 28 Dec 2022 00:42:51 -0800 (PST) Received: by mail-pg1-x52f.google.com with SMTP id 78so10180000pgb.8 for ; Wed, 28 Dec 2022 00:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t4t3wjs91jqYDdhcaBgIoHHF665G49/NIuIJvlGrcfA=; b=imJgc7Ixk5aekscKAi7ezzMRHSzFJJTv+Rq9u2se4QLC3CgFHjcLdLAqnY2rzzFixf FB/pf4o10XfdXgwrgeJuwnCZYYnEreMSGeaAybI3Jzs4/o52VhkkDlL6PJnDfWn9ShtF mqaC6Bf6E2WPM+/9orsIi8nkgVl4TyzU8rHRPvO4INIZML0JinHhsY7rM4Y0xeqCg9z9 l/2zHbqrpeISzR07n/1geMozRMXA5pbcrDiMRfIfZA5Ixv0GK4bdYcQfyyAQdnt8fIm5 8awUhpTgxQrL7XVdYHyYQoNIay9wGN9reUFCp1rLQH7N+o2jcbG5TXcArgmP8SXEtqCc FMvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t4t3wjs91jqYDdhcaBgIoHHF665G49/NIuIJvlGrcfA=; b=ByHDY6L9ayv5uYQVQHkMJxxBwMw8OflUBkk0nQrzxUhlHQ393t48TiXyZ/B8RUNFqd dRplr75NgpiLsmrlJJC1cv7QwMfq55pXpPWw46M3H5KqqdJRMaxoq2WS5UL5850ziwiT ayDsvOgNEfSXkiBila3FbCRJ/qPM5fhUrVOKvGBLT7w7xBf/RMrH/aap3cU6LU08Khyd M+Ci+TVwSY/fe4p5DC/CCcyHRVDcErgytknt/wyjrR5iLub5I6JKZv/7j7IYZ6/UIrCz 8ZQLuthNLYkfwWRL5bZRoYOxLAJxCNpcCjq4CGlmNQX2IwsghKyx+Sj7EYylNryV/Ym8 +dRw== X-Gm-Message-State: AFqh2ko1ynMA4LJMgWQOPJXW1kIv924k49iqgDUd3bWFth1+RcPtOPoM jZ3WXGGBnLLPRQM1ZuuG+wYX X-Received: by 2002:a05:6a00:1485:b0:575:b783:b6b3 with SMTP id v5-20020a056a00148500b00575b783b6b3mr34741803pfu.28.1672216971036; Wed, 28 Dec 2022 00:42:51 -0800 (PST) Received: from localhost.localdomain ([117.217.178.73]) by smtp.gmail.com with ESMTPSA id d188-20020a6236c5000000b0057a9b146592sm9786286pfa.186.2022.12.28.00.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Dec 2022 00:42:50 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: quic_saipraka@quicinc.com, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, ahalaney@redhat.com, steev@kali.org, Manivannan Sadhasivam , stable@vger.kernel.org Subject: [PATCH v5 17/17] soc: qcom: llcc: Do not create EDAC platform device on SDM845 Date: Wed, 28 Dec 2022 14:10:28 +0530 Message-Id: <20221228084028.46528-18-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221228084028.46528-1-manivannan.sadhasivam@linaro.org> References: <20221228084028.46528-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753448315734784046?= X-GMAIL-MSGID: =?utf-8?q?1753448315734784046?= The platforms based on SDM845 SoC locks the access to EDAC registers in the bootloader. So probing the EDAC driver will result in a crash. Hence, disable the creation of EDAC platform device on all SDM845 devices. The issue has been observed on Lenovo Yoga C630 and DB845c. Cc: # 5.10 Reported-by: Steev Klimaszewski Signed-off-by: Manivannan Sadhasivam --- drivers/soc/qcom/llcc-qcom.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index 7b7c5a38bac6..8d840702df50 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -1012,11 +1012,18 @@ static int qcom_llcc_probe(struct platform_device *pdev) drv_data->ecc_irq = platform_get_irq_optional(pdev, 0); - llcc_edac = platform_device_register_data(&pdev->dev, - "qcom_llcc_edac", -1, drv_data, - sizeof(*drv_data)); - if (IS_ERR(llcc_edac)) - dev_err(dev, "Failed to register llcc edac driver\n"); + /* + * The platforms based on SDM845 SoC locks the access to EDAC registers + * in bootloader. So probing the EDAC driver will result in a crash. + * Hence, disable the creation of EDAC platform device on SDM845. + */ + if (!of_device_is_compatible(dev->of_node, "qcom,sdm845-llcc")) { + llcc_edac = platform_device_register_data(&pdev->dev, + "qcom_llcc_edac", -1, drv_data, + sizeof(*drv_data)); + if (IS_ERR(llcc_edac)) + dev_err(dev, "Failed to register llcc edac driver\n"); + } return 0; err: