From patchwork Wed Dec 28 06:06:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xuezhi Zhang X-Patchwork-Id: 37113 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1742165wrt; Tue, 27 Dec 2022 22:19:52 -0800 (PST) X-Google-Smtp-Source: AMrXdXuMWO2JwAcWU5vhEyHJrqxVIjHf3Cfk7T9q7QMU+7nuq6uQE1Kzz2WP125J9Tv4Fz9i2WCi X-Received: by 2002:a17:906:7188:b0:7c0:f117:6990 with SMTP id h8-20020a170906718800b007c0f1176990mr20532845ejk.41.1672208391890; Tue, 27 Dec 2022 22:19:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672208391; cv=none; d=google.com; s=arc-20160816; b=rq0rArvQiofsVc//olyRB4cwt+TIfCjOOitt7lmPxHJalndBRP7kkFlgDNbl8IHuuo gob0S/qzqvCnN3bxBV+Sfe6P3+L7686U33rhVpCPszWlu4NM0wYju1DoO1HhLOHTE9Su 5l7bcsZSNkyRh/r8ee9kUKS40YtGRTkwfkfcC1IHHbHHNQSVmZiJe3hOCG9T0KFAHd54 YRdbh/eehYNILMNc84hP7X1/P+eG8nWJ9VOSHP62F/z3Ryqmh61AhIa5UH0hknI++4+n AW7F1qWSuZ/OLz6KqhsEOQXjHJZDTFlIaDzLmdcpSSCUpjjjq4w1haEMrTwMsQ+f1q70 OQBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=J2pU4Ljf/baXLHkKM+0GW9OZ+a+3/dhLhTsDpyWdPkY=; b=UrdFl5kNodLg54Gp9/jYLHLVqTEk1e7oWlC3Dg3bySlMma3FtCKBzpb41xGt0hcIw3 oAbV0ufY6JDRILmC8Z0n8cMyZ3xfLXVfNy8OsmTKNWemKyYsGNg+i0YNU45Ag6DsDqYR Zf0xe0NUbJEgmkdX/rRAOn096gx6ygifuPIqIV5FFpNCMQS9EVe5B91iKyquKXu4WrGi fiVXsFYcjLYQdZqcyJf0PSlpR4+tTylIf4vu+WFSjy6pPIJffb6JChOc8UDx48H4cTIG /Jm0vEnbmnseTUV+9uZZs0bvA4Gn0+kfPgLuXm1ugKR96R1pGhVvl9Zj608sha7P0tZL 36JQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=J4rsImfj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id la26-20020a170907781a00b007c1070653adsi9886455ejc.809.2022.12.27.22.19.26; Tue, 27 Dec 2022 22:19:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=J4rsImfj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232475AbiL1GJP (ORCPT + 99 others); Wed, 28 Dec 2022 01:09:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbiL1GIQ (ORCPT ); Wed, 28 Dec 2022 01:08:16 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9BEAE0B0; Tue, 27 Dec 2022 22:06:38 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id x26so3883795pfq.10; Tue, 27 Dec 2022 22:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=J2pU4Ljf/baXLHkKM+0GW9OZ+a+3/dhLhTsDpyWdPkY=; b=J4rsImfjSAB9ftOXVUGlyeDy4HhqXCrEuncwIMH47Kkumi18w/3toVyuMb4wHstQe/ 14DqUxdW2vzJeotM9o1RylgZUT71RCJKW6sJ8oMpicYdi5/O76A0QR5tXdVVm83f2qn+ x6FcogvB8kDygHsitrYqL+eilBiPhsz7K0LTf5V8bPQIkmYJwe7QGceiReDVsM/FtBvu Z1c6UAPBEup7ZNFM1K6TZR4LdmUK0ReYH54xAMarW0SgiJFGLNIhSc7Bhvrukk9WRZi4 cMGRrRxXKwsHM0Ns8ti+DVWw6Hu1QQIO3FVzCUccpqiAsW/EylqSI1XppAcAt9m4/+us olcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J2pU4Ljf/baXLHkKM+0GW9OZ+a+3/dhLhTsDpyWdPkY=; b=yUzx2nM7vR9DiPC6o76nxBizwTICtBEx5pNuVpEnkoh9dbPObUUHG14vh5qGUm80Ci Gm5L5HDKfJZ2LXBkrBcqdeRiMccClyfRsYCpAAkxECCfBvqd3BN5v2XHK1+wlljUw6jl Ussjujr7VWojox4Q3VWfek8J3+1X1APkvue0fX56PuoKUh0wIk4L5WU42c+NtLvjOG4C b9q6DSGoTm27oVrehe0RQrXjO/L4CoisWF0ZDRPCd89M8AhQGpyLcXF4lknuaDQhbKbz eDNSx+da7u+zR3u5Dp0Ovs6cOApSHrRrYWd+XH5QQqTlviV60sRGkjkI0N6cojhbGPPX r1Rg== X-Gm-Message-State: AFqh2kpgDOrwkmt12h8hy/oQaQ3tqqpyGhY0/4G6qa3K0TtBJU98qefW VqSys807wzNkZjxFDnu+qmY= X-Received: by 2002:aa7:8209:0:b0:581:3328:b468 with SMTP id k9-20020aa78209000000b005813328b468mr7808000pfi.6.1672207598250; Tue, 27 Dec 2022 22:06:38 -0800 (PST) Received: from carlis-virtual-machine.localdomain ([156.236.96.164]) by smtp.gmail.com with ESMTPSA id w186-20020a6262c3000000b005772f762e43sm9831769pfb.13.2022.12.27.22.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Dec 2022 22:06:37 -0800 (PST) From: Xuezhi Zhang To: zhangxuezhi1@coolpad.com, erazor_de@users.sourceforge.net, jikos@kernel.org, benjamin.tissoires@redhat.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: roccat: convert sysfs snprintf to sysfs_emit Date: Wed, 28 Dec 2022 14:06:33 +0800 Message-Id: <20221228060633.1459256-1-zhangxuezhi3@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753437586541918707?= X-GMAIL-MSGID: =?utf-8?q?1753437586541918707?= From: Xuezhi Zhang Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Xuezhi Zhang --- drivers/hid/hid-roccat-isku.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-roccat-isku.c b/drivers/hid/hid-roccat-isku.c index e95d59cd8d07..d356a0ac770c 100644 --- a/drivers/hid/hid-roccat-isku.c +++ b/drivers/hid/hid-roccat-isku.c @@ -63,7 +63,7 @@ static ssize_t isku_sysfs_show_actual_profile(struct device *dev, { struct isku_device *isku = hid_get_drvdata(dev_get_drvdata(dev->parent->parent)); - return snprintf(buf, PAGE_SIZE, "%d\n", isku->actual_profile); + return sysfs_emit(buf, "%d\n", isku->actual_profile); } static ssize_t isku_sysfs_set_actual_profile(struct device *dev,