From patchwork Mon Dec 26 08:58:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Kuai X-Patchwork-Id: 36562 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp810001wrt; Mon, 26 Dec 2022 00:42:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXvBL63pEyY85iqpzLfGjUx3QJDL4Z+v7v9GU32MU0RyrqYSyb4O0tozzhzny1qVWWoQn5Vt X-Received: by 2002:a17:907:8c81:b0:7c1:962e:cf28 with SMTP id td1-20020a1709078c8100b007c1962ecf28mr15920793ejc.23.1672044125752; Mon, 26 Dec 2022 00:42:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672044125; cv=none; d=google.com; s=arc-20160816; b=QJN5IbIEGhcyCnYRKUlYsrUS0/S0ji5xDO2jWk71WfC9K0136wL/VgHuebIx5RAN3T rRo9vuRHRZEyiW4f2q4HGHJhwwmM2PL+laKRhzUTFXhe4+0UL3RRil+SPMTKMbTYmR6s dAtk25VEY3UACIhyo8H7BPN5XrzczrAlCw/RU7hPdbW/jlphz+6aWnFmWjKlBNvBYYQl 3C6n22NfmUVfi40/kahvIJvG79vhUNhM0XqOC1O7R8C1qhcwgMKJ6yEL3+wCZr3EObKW X60AODAqivrrrCEnhoo4R2pUaxG2q83kQCoUmzrTLThdO6Dw56V3Cx/kVdhruFi+82F1 7H0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=G+XmaomHOloNTHAlNXidYO/UJtRyy5EiCT6PiSCBwXg=; b=la271zrn1K6AYdaPiiR5rhrsTZvGj8WUheUbl5Gph6sbIZd2Owrw2tFpkFzlNmtPu1 ygLWaJSIrV1wl8cnygBq6c9u32Aej80CZkAo6ITSMz2v0ZQTA57UQZ5A951rJrtD0lmh BE+XdqpV+AiuyAf+cgVoDzNVKOHhhtC2ZqoageDOMUG8plp4HxrFuPvQkec4mSKwc8TH 5fv59gJQS0c6n7tVA3OcJN2OpRaAYLWNcQI6eZ5xQUggimrPp1wxXx6WM6+NhXmZERg/ SwnkAaYbP4KiyBmb1rFDTVpaDli9KVhRHGudBzPdmg5kBPNX4USUafpLw9bJnDuYebB7 iqSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qq18-20020a17090720d200b007882936242fsi6615398ejb.769.2022.12.26.00.41.42; Mon, 26 Dec 2022 00:42:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231882AbiLZIjI (ORCPT + 99 others); Mon, 26 Dec 2022 03:39:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231534AbiLZIiq (ORCPT ); Mon, 26 Dec 2022 03:38:46 -0500 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9EE825F8; Mon, 26 Dec 2022 00:38:43 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4NgWQj5WpGz4f3mSQ; Mon, 26 Dec 2022 16:38:37 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.127.227]) by APP2 (Coremail) with SMTP id Syh0CgBH7eqEXaljOrUjAg--.30907S5; Mon, 26 Dec 2022 16:38:40 +0800 (CST) From: Yu Kuai To: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com Subject: [PATCH v3 1/5] blk-iocost: check return value of match_u64() Date: Mon, 26 Dec 2022 16:58:55 +0800 Message-Id: <20221226085859.2701195-2-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20221226085859.2701195-1-yukuai1@huaweicloud.com> References: <20221226085859.2701195-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: Syh0CgBH7eqEXaljOrUjAg--.30907S5 X-Coremail-Antispam: 1UD129KBjvdXoW7GF4kXr15AryDtF4xur1rJFb_yoWxtwb_ZF Z3Ga4fZrn7Ga95Z3WkCF1YqrWIkwn5JF4j9340yryUX3W3X3Z5Aw47Xr18Xa15WFW8G34r CFWDZr4qyr1IgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb-kFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUGwA2048vs2IY02 0Ec7CjxVAFwI0_JFI_Gr1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM2 8EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AI xVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20x vE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xv r2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48JMxC20s 026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_ JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14 v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xva j40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JV W8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbec_DUUUUU== X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753265341487115451?= X-GMAIL-MSGID: =?utf-8?q?1753265341487115451?= From: Yu Kuai This patch fixs that the return value of match_u64() from ioc_qos_write() is not checked, Signed-off-by: Yu Kuai Acked-by: Tejun Heo --- block/blk-iocost.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/blk-iocost.c b/block/blk-iocost.c index 549ddc9e0c6f..93b938517be3 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -3212,7 +3212,8 @@ static ssize_t ioc_qos_write(struct kernfs_open_file *of, char *input, switch (match_token(p, qos_ctrl_tokens, args)) { case QOS_ENABLE: - match_u64(&args[0], &v); + if (match_u64(&args[0], &v)) + goto einval; enable = v; continue; case QOS_CTRL: