From patchwork Fri Dec 23 12:52:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 36124 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp138431wrn; Thu, 22 Dec 2022 20:54:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXsTxyZ0wINOl9eUEwxQ9HDh66tGmhMcLtj/X1VP5LS+SONhVYHuTd48fwR49u9WeYBQkJtR X-Received: by 2002:a05:6a20:1bc2:b0:ad:e765:9554 with SMTP id cv2-20020a056a201bc200b000ade7659554mr9344175pzb.55.1671771289184; Thu, 22 Dec 2022 20:54:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671771289; cv=none; d=google.com; s=arc-20160816; b=qOG6IMnatKdY4WT2shaLApIZsnW5wlF81W5RFDgrI8UwaKiAXLyo6fJjMvpn2FjX37 Da/sXLuvfEBzXXk1rLRFieFtsFyxpe+G9M6vK/gYS4NHhVQgmsCaMdv3Vk7JegYHbki+ oEAgS9ADBVY2mIQ6ZpNEwB+aZf/SXyvDchx5huJ7jaK+Wus3FaKTySC5jW6b0DstdYxq Zu905hFwvJZz8fg1KhaBPEAa2Ypv9NkgV5qHvSOh5zW4+MoKXkgLmwQZRCFG4GMaURki Y6DrgLt4A4vsF0CAvTc7WTIrsz2qnqMWmNW4pHIlxrUCO5OaWG6FhLi3tdJ3L38yWsMK sNiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=E3iXBYUxOU7PhhBFumbCKk9akw+ArNSfLZyFzmwpjvo=; b=KMTDpaXqoY9mvj8KcHEyxi60Wa/Jx33OKxKUej9BVAkUXlpV5npMUGjLV33JvMnE1q jddlWXTS2NTd+SzOcllYAJ8NqYUkt7Zj89qAla/AmbRYWfnTziiJc11wgyoF7Kb2TfiB WsAwANU6jzKqNYt8WNNCakezy6QbnmiWpDIUEDhFKBFBRM6/5hXqpj6knBDtwiQ82cgz EiXADwRWICUaG5y7abuv9mhlzepwvkWOurfFAPNhD7u0qSL7Ph7ImDoMqIkRnYFOdQ2k n6V3+ET/PXXMq60B1N+XdhItKvrLzewq5KoQMXhzZL/1r1NTFXgKQ6q44WZfu8vzwo9q 6LRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e21-20020a637455000000b00476d6927ba2si2755853pgn.659.2022.12.22.20.54.36; Thu, 22 Dec 2022 20:54:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235814AbiLWExx (ORCPT + 99 others); Thu, 22 Dec 2022 23:53:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbiLWExe (ORCPT ); Thu, 22 Dec 2022 23:53:34 -0500 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46B34248D3; Thu, 22 Dec 2022 20:53:33 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4NdZZH5w1hz4f3k5s; Fri, 23 Dec 2022 12:53:27 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgDXjbFHNKVjpOduAQ--.93S7; Fri, 23 Dec 2022 12:53:30 +0800 (CST) From: Kemeng Shi To: axboe@kernel.dk, dwagner@suse.de, hare@suse.de, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: hch@lst.de, john.garry@huawei.com, shikemeng@huaweicloud.com Subject: [PATCH 05/13] blk-mq: remove unnecessary list_empty check in blk_mq_try_issue_list_directly Date: Fri, 23 Dec 2022 20:52:15 +0800 Message-Id: <20221223125223.1687670-6-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20221223125223.1687670-1-shikemeng@huaweicloud.com> References: <20221223125223.1687670-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgDXjbFHNKVjpOduAQ--.93S7 X-Coremail-Antispam: 1UD129KBjvdXoWrKr1xWry5Kw1Utw48Ww18uFg_yoWDJrX_uF y0vwn7XFWDGF17Ar4I93WIyFn8K34kWr1fXFyftF9xWFWfWFs8Was5KF4rZ3y7Ca17K3sI 9ryrXr9Iyr10gjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbDAFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUAVCq3wA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJ M28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2I x0cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK 6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4 xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8 JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20V AGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAF wI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc4 0Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AK xVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0pRvJPtU UUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752979251707894701?= X-GMAIL-MSGID: =?utf-8?q?1752979251707894701?= We only break the list walk if we get 'BLK_STS_*RESOURCE'. We also count errors for 'BLK_STS_*RESOURCE' error. If list is not empty, errors will always be non-zero. So we can remove unnecessary list_empty check. This will remove redundant list_empty check for case that error happened at sending last request in list. Signed-off-by: Kemeng Shi --- block/blk-mq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index bfba0e151733..a447a7586032 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2832,8 +2832,7 @@ void blk_mq_try_issue_list_directly(struct blk_mq_hw_ctx *hctx, * the driver there was more coming, but that turned out to * be a lie. */ - if ((!list_empty(list) || errors) && - hctx->queue->mq_ops->commit_rqs && queued) + if (errors && hctx->queue->mq_ops->commit_rqs && queued) hctx->queue->mq_ops->commit_rqs(hctx); }