From patchwork Fri Dec 23 12:24:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 36250 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp290481wrn; Fri, 23 Dec 2022 04:28:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXvEHpwGfoFEMV5W5/0+Ht0G2nJCJYpipctu2ztuYjQKU72qsqdFHb87Oo7eJOa2fY3fbC+S X-Received: by 2002:a17:906:13d6:b0:7c1:99a7:e10b with SMTP id g22-20020a17090613d600b007c199a7e10bmr7326426ejc.49.1671798493120; Fri, 23 Dec 2022 04:28:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671798493; cv=none; d=google.com; s=arc-20160816; b=vUhz2ankdDpYL3DThd9awiIEjsei6vua1y6Jd1mwrxe5dPdRHvUSKvSFRqTE+rPRmQ 4PASKMo6rG3rDg7fgUfEWetu5SlX1IkKJjEtMjkfiKt9F49p08aM30lr7XbuhHAnt1im z8ZnKB6dHWhtVv7D86IBgu5IBTaT7Mxit/1SPfWEqhylzG/Fs4GrjMGsCJIIeH3LfBnI C8Pv3E2TTUAuKi3v4f9TkeFqRDhjIpspnbiU77gHj7/RhaGqU/JoU/FHhlqGw3Tbk60H wHbs7mMjNJtPOqVH+n30rhuUf/VmP7sMNMzyXvXNoX1kXYBQ3X/kp7r/RCT1XMrZ1OdA 3r9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8FHYTZAlv8fVDMzUdIleeERbDn7iPe8hE1wrLAMToxc=; b=pg3gBAzuSzxg3uuX7JHbRu/zRo9LFUXuzO2MfjGPfUe1l5+PdYSq6+nWbbFJF3z/pb JPuEygXNAoOk0u7uOPP/zId5nj2oK5bvgFiXGynRdivMsUqIys1qU90PGnHfH4un8C+r Adb9Gzksjw9BBLxRefl7q8+fxzohflwy8qEc99hy3mQP80CcryXUj8s99liY4Gk/C5fr ZWds763xfq/WOCgYqHLSBtvQF/u7kEnYw87V+ELoxeQbhrQHJ1jl773O02vZ6NPiRY/s +ZoYz8T8XQbxF6zxgYXO629b48BD2RERNWPGkd5mX07sFBkRJOaOeQuoL7cr21wPI71L Sqgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=aNHAgoxh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e16-20020a17090658d000b0084514612c26si2706888ejs.611.2022.12.23.04.27.49; Fri, 23 Dec 2022 04:28:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=aNHAgoxh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236308AbiLWMZS (ORCPT + 99 others); Fri, 23 Dec 2022 07:25:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236298AbiLWMZO (ORCPT ); Fri, 23 Dec 2022 07:25:14 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69004FCCF; Fri, 23 Dec 2022 04:25:13 -0800 (PST) Received: from umang.jainideasonboard.com (unknown [IPv6:2401:4900:1f3f:cd5d:4e48:3b91:9262:9565]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 682D0492; Fri, 23 Dec 2022 13:25:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671798312; bh=Xo4PgGMqXkAeAbAXamG4Agqq6zDHS6a3JUw2oXCCxcA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aNHAgoxhvTZb5g/t3sRmdo1fISxhqSourtvk2a6eUsvsZPlWCVyxocjj+Da9i7fUm RJOWfsT+76+cpSo1/4CPtZ/DgZDsJq/scSBkKsTnPPY9a2uPK4GJwDSbDcYsUpx9wC 1+hH65ZUd5Ec74/lm9JrevRiirNA5uuSBAgSLwiE= From: Umang Jain To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Kees Cook , Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [PATCH v3 7/7] staging: vc04_services: vchiq: Drop custom return values from TODO Date: Fri, 23 Dec 2022 17:54:04 +0530 Message-Id: <20221223122404.170585-8-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221223122404.170585-1-umang.jain@ideasonboard.com> References: <20221223122404.170585-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753007776785244114?= X-GMAIL-MSGID: =?utf-8?q?1753007776785244114?= The custom return values (enum vchiq_status) has been dropped. Remove the TODO entry for the same. Signed-off-by: Umang Jain Tested-by: Stefan Wahren --- drivers/staging/vc04_services/interface/TODO | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 97085a0b3223..6d9d4a800aa7 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -40,11 +40,6 @@ beneficial to go over all of them and, if correct, comment on their merits. Extra points to whomever confidently reviews the remote_event_*() family of functions. -* Get rid of custom function return values - -Most functions use a custom set of return values, we should force proper Linux -error numbers. Special care is needed for VCHIQ_RETRY. - * Reformat core code with more sane indentations The code follows the 80 characters limitation yet tends to go 3 or 4 levels of