From patchwork Fri Dec 23 12:24:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 36253 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp290633wrn; Fri, 23 Dec 2022 04:28:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXvjSg04CgxnkoVCCjlEHm/+cU+WBBYStTyyMxKNgv978TUxgSdXQJkGCfm9TqPDyrrOgfa6 X-Received: by 2002:a17:906:b053:b0:7c1:1b89:1fe0 with SMTP id bj19-20020a170906b05300b007c11b891fe0mr7178787ejb.65.1671798524337; Fri, 23 Dec 2022 04:28:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671798524; cv=none; d=google.com; s=arc-20160816; b=ZXOCtF1ibSzLN+bAEVrWNVicnmFpdprsfK3Z1QwTxn9m6f2co+m4tJvvwLXYWXDWiC P1cbZgfeEcEjAxq8PVTuj0CooA4JYZF/5IMTtbxzbUIFSxl9r5Vt0Tu0kO/8O5Z5tUp4 3qDqOdT8PDL1CgvnAuElrsG2QNgiT8b+fxpH9D3nobqdx/gr9t7VR5HDzZL9TLJr+Sf8 2f1/0QSb2idiQdIZ26osHNp72V9ta9BhKU0tM7mYYliXjspPJNPV7mktk5gHPooDvagu ZXCVSPm0jYmlFQ9qnlLfVdHHT8g9drtpCk/2W79Ig7UWs+oOwyuZ5LW5CKVxZAuFbUxG PJrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=R/rVxk4vHlu+LLPlZnh9uaVQ3DHbcCLV+BtLWHVF5mA=; b=f/zDBIA2Jr1TTGsXKvq5xx8gyatsb3Iq6Gb+bg+RiR/XhGXplQeV83a2pR6bvmA9Yj nH3Av4VkeOtMvqbYtmno9gPna8w3/aVR3Qneyh2hWEJytljHXf8V/kZ8wGGbFdoub8s/ JgD6RDhdNg/d4g+gxljhuqM7/81petnIZo/fy5BEarND05QvDc6tt7/9qA2tmJE0V12S MIoKTbH2zq/ZZ6XuYX1nQmTGo28WwkaN9/LBaVm1RbdCrpi/PTrAI9lTh5wnHdk67O/i JgQk3ReVDEpkpxRCPTMoIXGwV1miZsGEwPTEZ7CYLIMfCqH+JWSLXZESZryCrxixmObm YWNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=VVJknRnT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j27-20020a170906279b00b00797670441desi1913089ejc.911.2022.12.23.04.28.20; Fri, 23 Dec 2022 04:28:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=VVJknRnT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236283AbiLWMZC (ORCPT + 99 others); Fri, 23 Dec 2022 07:25:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236266AbiLWMY7 (ORCPT ); Fri, 23 Dec 2022 07:24:59 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FD873722A; Fri, 23 Dec 2022 04:24:58 -0800 (PST) Received: from umang.jainideasonboard.com (unknown [IPv6:2401:4900:1f3f:cd5d:4e48:3b91:9262:9565]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D6A3492; Fri, 23 Dec 2022 13:24:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671798297; bh=Uz/jtOm7K0pgw7vfRKWZw/6DeaYJhsIV5g5BVa7QStc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VVJknRnTsD/g2C3L9Kpz+ndih9fs0wSMl6r7YIwCc/pVkNqba+k09tiEKKR0fKLYY lKoF1wX/KCEktcnG6E6dk6f6DTVRgeQU/6pLnBJpAh84tqMJxJghyduMOFhVon0VHQ 2+29bsooIP+LcpXXHe0giX4Dta1bArGgYZ85zwak= From: Umang Jain To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Kees Cook , Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [PATCH v3 5/7] vc04_services: vchiq_arm: Drop VCHIQ_RETRY usage on disconnect Date: Fri, 23 Dec 2022 17:54:02 +0530 Message-Id: <20221223122404.170585-6-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221223122404.170585-1-umang.jain@ideasonboard.com> References: <20221223122404.170585-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753007809080111760?= X-GMAIL-MSGID: =?utf-8?q?1753007809080111760?= Drop the usage of VCHIQ_RETRY when the vchiq has connection status VCHIQ_CONNSTATE_DISCONNECTED. Disconnected status will not be valid to carry on a retry, hence replace the VCHIQ_RETRY with -ENOTCONN. This patch removes the usage of vCHIQ_RETRY completely and act as intermediatory to address the TODO item: * Get rid of custom function return values for vc04_services/interface. Signed-off-by: Umang Jain Tested-by: Stefan Wahren --- .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 9c64d5de810e..ddb6d0f4daed 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -3641,7 +3641,7 @@ vchiq_loud_error_footer(void) int vchiq_send_remote_use(struct vchiq_state *state) { if (state->conn_state == VCHIQ_CONNSTATE_DISCONNECTED) - return VCHIQ_RETRY; + return -ENOTCONN; return queue_message(state, NULL, MAKE_REMOTE_USE, NULL, NULL, 0, 0); } @@ -3649,7 +3649,7 @@ int vchiq_send_remote_use(struct vchiq_state *state) int vchiq_send_remote_use_active(struct vchiq_state *state) { if (state->conn_state == VCHIQ_CONNSTATE_DISCONNECTED) - return VCHIQ_RETRY; + return -ENOTCONN; return queue_message(state, NULL, MAKE_REMOTE_USE_ACTIVE, NULL, NULL, 0, 0);