diff mbox series

[v2] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp

Message ID 20221223073353.20612-1-quic_youghand@quicinc.com
State New
Headers
Series [v2] arm64: dts: qcom: sc7280: Add wifi alias for SC7280-idp |

Commit Message

Youghandhar Chintala Dec. 23, 2022, 7:33 a.m. UTC 
  Currently, the boot loader code used in the SC7280 SoC accesses
the WiFi node using node names (wifi@<addr>). Since the bootloader
is a common code that is used in SoCs having different WiFi chipsets,
it is better if the bootloader code accesses the WiFi node using
a WiFi alias. The advantage of this method is that the boot loader
code need not be changed for every new WiFi chip.
Therefore, add wifi alias entry for SC7280-idp device tree

Signed-off-by: Youghandhar Chintala <quic_youghand@quicinc.com>
---
V2:
 -Added purpose of this in the commit message
---
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Dec. 23, 2022, 7:59 a.m. UTC | #1 
On 23/12/2022 08:33, Youghandhar Chintala wrote:
> Currently, the boot loader code used in the SC7280 SoC accesses
> the WiFi node using node names (wifi@<addr>). Since the bootloader
> is a common code that is used in SoCs having different WiFi chipsets,
> it is better if the bootloader code accesses the WiFi node using
> a WiFi alias. The advantage of this method is that the boot loader
> code need not be changed for every new WiFi chip.
> Therefore, add wifi alias entry for SC7280-idp device tree

Sounds good but which bootloader.

Best regards,
Krzysztof
Youghandhar Chintala Dec. 28, 2022, 7:02 a.m. UTC | #2 
On 12/23/2022 1:29 PM, Krzysztof Kozlowski wrote:
> On 23/12/2022 08:33, Youghandhar Chintala wrote:
>> Currently, the boot loader code used in the SC7280 SoC accesses
>> the WiFi node using node names (wifi@<addr>). Since the bootloader
>> is a common code that is used in SoCs having different WiFi chipsets,
>> it is better if the bootloader code accesses the WiFi node using
>> a WiFi alias. The advantage of this method is that the boot loader
>> code need not be changed for every new WiFi chip.
>> Therefore, add wifi alias entry for SC7280-idp device tree
> Sounds good but which bootloader.
>
> Best regards,
> Krzysztof

Depth-charge Chrome OS bootloader.

Regards,

Youghandhar
Krzysztof Kozlowski Dec. 28, 2022, 9:08 a.m. UTC | #3 
On 28/12/2022 08:02, Youghandhar Chintala (Temp) wrote:
> 
> On 12/23/2022 1:29 PM, Krzysztof Kozlowski wrote:
>> On 23/12/2022 08:33, Youghandhar Chintala wrote:
>>> Currently, the boot loader code used in the SC7280 SoC accesses
>>> the WiFi node using node names (wifi@<addr>). Since the bootloader
>>> is a common code that is used in SoCs having different WiFi chipsets,
>>> it is better if the bootloader code accesses the WiFi node using
>>> a WiFi alias. The advantage of this method is that the boot loader
>>> code need not be changed for every new WiFi chip.
>>> Therefore, add wifi alias entry for SC7280-idp device tree
>> Sounds good but which bootloader.
>>
>> Best regards,
>> Krzysztof
> 
> Depth-charge Chrome OS bootloader.

Put it in the commit msg.

Best regards,
Krzysztof
Youghandhar Chintala Dec. 28, 2022, 9:43 a.m. UTC | #4 
On 12/28/2022 2:38 PM, Krzysztof Kozlowski wrote:
> On 28/12/2022 08:02, Youghandhar Chintala (Temp) wrote:
>> On 12/23/2022 1:29 PM, Krzysztof Kozlowski wrote:
>>> On 23/12/2022 08:33, Youghandhar Chintala wrote:
>>>> Currently, the boot loader code used in the SC7280 SoC accesses
>>>> the WiFi node using node names (wifi@<addr>). Since the bootloader
>>>> is a common code that is used in SoCs having different WiFi chipsets,
>>>> it is better if the bootloader code accesses the WiFi node using
>>>> a WiFi alias. The advantage of this method is that the boot loader
>>>> code need not be changed for every new WiFi chip.
>>>> Therefore, add wifi alias entry for SC7280-idp device tree
>>> Sounds good but which bootloader.
>>>
>>> Best regards,
>>> Krzysztof
>> Depth-charge Chrome OS bootloader.
> Put it in the commit msg.
>
> Best regards,
> Krzysztof

Added it in v3 version of patch.

Regards,

Youghandhar
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index cd432a2856a7..c4f88d7b3758 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -18,6 +18,7 @@  / {
 	aliases {
 		bluetooth0 = &bluetooth;
 		serial1 = &uart7;
+		wifi0 = &wifi;
 	};
 
 	max98360a: audio-codec-0 {