[2/2] dt-bindings: usb: usbmisc-imx: add i.MX8MM usbmisc

Message ID 20221223031012.92932-2-peng.fan@oss.nxp.com
State New
Headers
Series [1/2] dt-bindings: usb: ci-hdrc-usb2: add i.MX8MM compatible |

Commit Message

Peng Fan (OSS) Dec. 23, 2022, 3:10 a.m. UTC
  From: Peng Fan <peng.fan@nxp.com>

Add fsl,imx8mm-usbmisc compatible for i.MX8MM

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

I had a V4 patchset to convert the binding to dt schema, but we are in
the process of ARM System-Ready 2.0 certification, directly update
this binding doc is the easiest way for now.

 Documentation/devicetree/bindings/usb/usbmisc-imx.txt | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Krzysztof Kozlowski Dec. 23, 2022, 8:08 a.m. UTC | #1
On 23/12/2022 04:10, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add fsl,imx8mm-usbmisc compatible for i.MX8MM
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> I had a V4 patchset to convert the binding to dt schema, but we are in
> the process of ARM System-Ready 2.0 certification, directly update
> this binding doc is the easiest way for now.
> 

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
  
Rob Herring Feb. 21, 2023, 2:36 p.m. UTC | #2
On Thu, Dec 22, 2022 at 9:09 PM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Add fsl,imx8mm-usbmisc compatible for i.MX8MM
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> I had a V4 patchset to convert the binding to dt schema, but we are in
> the process of ARM System-Ready 2.0 certification, directly update
> this binding doc is the easiest way for now.

There's been some misunderstanding (within Arm), but this is not
sufficient for certification. There must be a schema. Besides, you've
already done the work to convert and spent maintainers time to review
this. So can you please repost the conversions.

Rob
  
Peng Fan Feb. 22, 2023, 12:27 a.m. UTC | #3
Hi Rob,

> Subject: Re: [PATCH 2/2] dt-bindings: usb: usbmisc-imx: add i.MX8MM
> usbmisc
> 
> On Thu, Dec 22, 2022 at 9:09 PM Peng Fan (OSS) <peng.fan@oss.nxp.com>
> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add fsl,imx8mm-usbmisc compatible for i.MX8MM
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > I had a V4 patchset to convert the binding to dt schema, but we are in
> > the process of ARM System-Ready 2.0 certification, directly update
> > this binding doc is the easiest way for now.
> 
> There's been some misunderstanding (within Arm), but this is not sufficient
> for certification. 

You mean SR-IR 2.0 requires schema binding doc?

There must be a schema. Besides, you've already done the
> work to convert and spent maintainers time to review this. So can you
> please repost the conversions.

ok, I will pick up the v4 and prepare v5.

Thanks,
Peng.

> 
> Rob
  

Patch

diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
index b796836d2ce7..29b8f65ff849 100644
--- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
+++ b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt
@@ -8,6 +8,7 @@  Required properties:
 	"fsl,imx6sx-usbmisc" for imx6sx
 	"fsl,imx7d-usbmisc" for imx7d
 	"fsl,imx7ulp-usbmisc" for imx7ulp
+	"fsl,imx8mm-usbmisc" for imx8mm
 - reg: Should contain registers location and length
 
 Examples: