Message ID | 20221222191641.1643117-8-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp266382wrn; Thu, 22 Dec 2022 03:19:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXusxY/Bkq/m+vrO9gNbiflV6GRz2dnaqrnwa0VzQ1zRvv8fu7IWdIQ189YlwiXB/2fdWSLe X-Received: by 2002:a05:6402:1caa:b0:475:b14a:f83a with SMTP id cz10-20020a0564021caa00b00475b14af83amr4496684edb.15.1671707999135; Thu, 22 Dec 2022 03:19:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671707999; cv=none; d=google.com; s=arc-20160816; b=HMJ7GpK0fnc8x5smWLC/M/5SoOfO61wktLoPsXJdoT4zbd2PUSjc9XNNfz2rKz2KMM R8wyCTge0Sm1GUAeeZerAwMzaiIp5sRPkA1kwvn/OJRJeg5L0F//GojpBqHZ4/8wJmu7 2w99G7a9Lyw873X7ao3De8gcUuaYcpm0Lr0ljyhVDqg2tGF2eldq9Pign5LtJ0h3dq7s cl0Y2TQH0Fl9KJN7EFOxsWvDb3FPvWRHFu1KsVrL9KrNfY7oZCrP8V0xnsASbJN4agCY S/mfhznBsQYidi3iwQUZrTwr7dLQp5BDb8rZpfRmYzZZGPi4ezA7Puc5w8vBpy+p/Ptd PSNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=nyGUGwipDetsnrwH9cRlSkmhXNnlTJZbqjZdsKOTkNg=; b=IL93dXvRs0xnE8DXX5noqbiep50Yt182EiIBuJFyKKyoFJfe51sE3xsZGn9MKk/R+A 6G+VmwSIpAO9xLFAgB2YZ67+rQzEXr0GNRgVCtKJMiPyRkNhe1VLfgr9TkH9rdutKd3V srt8h1zHgBTq6M3k8QgBx4p6jANWx3kqQUts81FHQdbVQePppVgmTvcnKiTAyL4PRXk3 yr+ZTUyuTIDSa6C4tNyGQf6GRmblwKQO/NnDoRPJVnFRyZ23zoZDm7TkGvyQYNHzat3s 4+3iX4TYOrvT8MsoWFTxtBvuxbCTM9hqkZoso2YiGICa5HeiNyw07LEcp9zeCjYVvsRK OmRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q9-20020a056402032900b004782d6db359si443421edw.146.2022.12.22.03.19.35; Thu, 22 Dec 2022 03:19:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235364AbiLVLSK (ORCPT <rfc822;pacteraone@gmail.com> + 99 others); Thu, 22 Dec 2022 06:18:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235387AbiLVLRu (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 22 Dec 2022 06:17:50 -0500 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 473C722BD3; Thu, 22 Dec 2022 03:17:50 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Nd7890F9Qz4f3jJB; Thu, 22 Dec 2022 19:17:45 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgB3a+nXPKRjMew+AQ--.3596S9; Thu, 22 Dec 2022 19:17:47 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: paolo.valente@linaro.org, axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jack@suse.cz, hch@lst.de, damien.lemoal@wdc.com Subject: [PATCH RESEND v2 07/10] block, bfq: remove redundant check in bfq_put_cooperator Date: Fri, 23 Dec 2022 03:16:38 +0800 Message-Id: <20221222191641.1643117-8-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20221222191641.1643117-1-shikemeng@huaweicloud.com> References: <20221222191641.1643117-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: Syh0CgB3a+nXPKRjMew+AQ--.3596S9 X-Coremail-Antispam: 1UD129KBjvdXoWrKrWxAFWUXr1xWw48Gw1Utrb_yoWxtrg_t3 sYkFWrJrW8Gry5Ar1ftas8Aw1UAayrJF1DJFyFqw4DXF15GF4rCa92gFWayFs8Way7Ga4a yFy0q3WDtr4DKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbSxYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r126s0DM28IrcIa0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC 64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM2 8EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq 3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6x kF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUIL05UUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752912886923567063?= X-GMAIL-MSGID: =?utf-8?q?1752912886923567063?= |
Series |
A few bugfix and cleancode patch for bfq
|
|
Commit Message
Kemeng Shi
Dec. 22, 2022, 7:16 p.m. UTC
We have already avoided a circular list in bfq_setup_merge (see comments
in bfq_setup_merge() for details), so bfq_queue will not appear in it's
new_bfqq list. Just remove this check.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
block/bfq-iosched.c | 2 --
1 file changed, 2 deletions(-)
Comments
On Fri 23-12-22 03:16:38, Kemeng Shi wrote: > We have already avoided a circular list in bfq_setup_merge (see comments > in bfq_setup_merge() for details), so bfq_queue will not appear in it's > new_bfqq list. Just remove this check. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > block/bfq-iosched.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c > index 7c91d16dbf6f..89995815dbae 100644 > --- a/block/bfq-iosched.c > +++ b/block/bfq-iosched.c > @@ -5273,8 +5273,6 @@ void bfq_put_cooperator(struct bfq_queue *bfqq) > */ > __bfqq = bfqq->new_bfqq; > while (__bfqq) { > - if (__bfqq == bfqq) > - break; > next = __bfqq->new_bfqq; > bfq_put_queue(__bfqq); > __bfqq = next; > -- > 2.30.0 >
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 7c91d16dbf6f..89995815dbae 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -5273,8 +5273,6 @@ void bfq_put_cooperator(struct bfq_queue *bfqq) */ __bfqq = bfqq->new_bfqq; while (__bfqq) { - if (__bfqq == bfqq) - break; next = __bfqq->new_bfqq; bfq_put_queue(__bfqq); __bfqq = next;