From patchwork Thu Dec 22 06:04:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Wang X-Patchwork-Id: 35622 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp160402wrn; Wed, 21 Dec 2022 22:13:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXsf/DdiGrDDbLVIxdrK50WbFNGDu1e4z9/7dWIAWh3DsQEpGpZHVOX7+IKfcb6zKokBvNSE X-Received: by 2002:a17:907:c296:b0:820:4046:1586 with SMTP id tk22-20020a170907c29600b0082040461586mr3382214ejc.12.1671689603444; Wed, 21 Dec 2022 22:13:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671689603; cv=none; d=google.com; s=arc-20160816; b=ups3zFY3df/eEJPhl8ZDfKNLuL7QmwbSFbQUc+PRi2mFyHh0cNHv1dcdGkz9U5O12h lo1a1x7XfznYuRSpI8m42OQ9nWRRc+U9cP0z36ctxKoqWNZ/nI2K+qz2ZvZizovP2mWq PzUflAc4o7qqca/YwNVMilbpy7s8jLIIQFEOGfCaApTImaYv4/EQ2lW+z+P73QKjm6le ovB1L+Tfu25dni76l4JSydQbYIN1c5wOu3cmQ0TeXNoHF5IXiJQCnoFzXrChRMJ44vFn SdxR753KCXxc7h8on0ns1dYRgEmzhbjYCuh61rRrVpKROhUdx7lzQIGCBKedI67ScQQr No+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1rTeZDLahEEUIQy4wMRthdfJbzV+lOwcoNI4SggfJI8=; b=QBuefuJfYZrMGol1eOhsMjq/0P5Xz4boIjASpQwRyDgRhiV0VhwWrurEFz9TaCP2Tt XcLEM2RpKCrYefYev6//h7NvHoHyZRCImwrQfCTkueg1+G3Y60ByMxf0alxPf6VaHprK /Ez2DgT8dtT42m9WykkB/DufW97mTpogxF5tXN5gVANi2OrF7pnJFd8BumBYMskELPnC itFtdrXCp9G31S+Y+HCp5slAtBD5ZpiqKCpwqLjeUy79eJwYe6r0oKhl4E3o1OjwfDaE ec+nlM81ONHiXAIowjNO57gOmtLMb5SZoVV4iEvck96kMA4s/vwnIAL8V7g5Xz5owTI3 HFNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R62w4Img; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho34-20020a1709070ea200b007ae2368c8b7si3378328ejc.138.2022.12.21.22.12.52; Wed, 21 Dec 2022 22:13:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R62w4Img; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235055AbiLVGFs (ORCPT + 99 others); Thu, 22 Dec 2022 01:05:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235060AbiLVGFn (ORCPT ); Thu, 22 Dec 2022 01:05:43 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71A391B1C0 for ; Wed, 21 Dec 2022 22:04:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671689092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1rTeZDLahEEUIQy4wMRthdfJbzV+lOwcoNI4SggfJI8=; b=R62w4ImgynvjYrO7IgrIDcR2VDtZpEl+S4+8iqDsFZkGlcVbBS7eMDSJGc6NS3QAVxjW6+ DPXzl5TiHAd6nmPvsm0E29IkXV1mRJkfx8jqT2nSB1lfW3vcSz042Kes0u94WxrmrO/Y2M vZsaudRsAAVF4kofjO1/fGuFdUFJ+UI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-152-V2twCnI5NIurCMkSOvZAzQ-1; Thu, 22 Dec 2022 01:04:49 -0500 X-MC-Unique: V2twCnI5NIurCMkSOvZAzQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DB30A29ABA2B; Thu, 22 Dec 2022 06:04:48 +0000 (UTC) Received: from localhost.localdomain (ovpn-13-179.pek2.redhat.com [10.72.13.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id 48B21112132C; Thu, 22 Dec 2022 06:04:43 +0000 (UTC) From: Jason Wang To: mst@redhat.com, jasowang@redhat.com Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, alvaro.karsz@solid-run.com, eperezma@redhat.com Subject: [RFC PATCH 2/4] virtio_ring: switch to use BAD_RING() Date: Thu, 22 Dec 2022 14:04:25 +0800 Message-Id: <20221222060427.21626-3-jasowang@redhat.com> In-Reply-To: <20221222060427.21626-1-jasowang@redhat.com> References: <20221222060427.21626-1-jasowang@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752893597605119480?= X-GMAIL-MSGID: =?utf-8?q?1752893597605119480?= Switch to reuse BAD_RING() to allow common logic to be implemented in BAD_RING(). Signed-off-by: Jason Wang --- drivers/virtio/virtio_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 2e7689bb933b..90c2034a77f3 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -2237,7 +2237,7 @@ bool virtqueue_notify(struct virtqueue *_vq) /* Prod other side to tell it about changes. */ if (!vq->notify(_vq)) { - vq->broken = true; + BAD_RING(vq, "vq %d is broken\n", vq->vq.index); return false; } return true;