From patchwork Thu Dec 22 02:26:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 35577 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp96454wrn; Wed, 21 Dec 2022 18:31:58 -0800 (PST) X-Google-Smtp-Source: AMrXdXtAymJnItnTFymz/gYkiZfCJhM2AfN9dvXRdTeroYrSvAkZVDoKvyNlSYybsWzngOeIG60n X-Received: by 2002:aa7:c69a:0:b0:46d:e3f8:4ed4 with SMTP id n26-20020aa7c69a000000b0046de3f84ed4mr3636033edq.21.1671676318539; Wed, 21 Dec 2022 18:31:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671676318; cv=none; d=google.com; s=arc-20160816; b=ICbHyu53qmhCx/Dq2VG1OTVedJejHEQ9P0aMexphemnUzLB3dL1j4+ZHhddyoHD35l r8Ku3MEmP2PPe3sjuAXjtHN//Q07KKOF75GwctVoR3Wj7VLyJ8RDMbBtVwowVWf3NCxL NlxaGeUaHPX+YhT228CJND/M3W5eKRt5TdQEfDGkxFdctTLk42qqV9jDm/LUITgNh4SU pz1Le1GCp3Cb3LLKpSzdR1J6GtAfXIvbEPYk8SONNg8nF7q1B/mzX0XzVC8pR/+VQ9qm U8XtT78oQ+vC/SBsRJLfI8j3QSXTcwOtxK41SrMxIKPBATP3omoqxVZhvIAUd37r3onb hfeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fVWA7/D2KvjMyMicmKIzWkp9wEe3Q6Twufyriuc4mnk=; b=LhwiAsto9LAzt2xQr/vcLmUyFO5nEykAgeBIKG0pmP5xUkISZgMbPsvyDjMzGKMWn2 9pEZsIv5euCXJh4YXCUcksnFUupRyDVBk241EaQOtXJSyagzDNMv9zTfMfwKRLprI6oT kAVZ07oxaoRioOHab0Aq64cGz5kuFVGrzEn95GEFXHLYC52s9GSHvR85RxtsU8MPPDTL SIQr7YZfqR5I2Gj0zLPYSBxrz8oxZOMCy1NJMsR5p9Q1ZnWLeESdVR0ZJkd9/hSO+4cg cy3Pvqsa2OMdHh2bzuGHIzgbzMkWPGi6SrWJvyigvNFP20zVuAYFGj9TxWzjbwDxVz4d 6KnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=F+cvtx7S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s24-20020a056402037800b0046187ab5c1bsi14303555edw.512.2022.12.21.18.31.34; Wed, 21 Dec 2022 18:31:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=F+cvtx7S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234914AbiLVC04 (ORCPT + 99 others); Wed, 21 Dec 2022 21:26:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231146AbiLVC0u (ORCPT ); Wed, 21 Dec 2022 21:26:50 -0500 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37E2E10069 for ; Wed, 21 Dec 2022 18:26:50 -0800 (PST) Received: by mail-io1-xd33.google.com with SMTP id z144so372617iof.3 for ; Wed, 21 Dec 2022 18:26:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fVWA7/D2KvjMyMicmKIzWkp9wEe3Q6Twufyriuc4mnk=; b=F+cvtx7SUTBiDbyXWwC1K3FSy9wvZ3+6N3Ol2twXHs8J8w4KDcC3F1O1+gSzcMeK3X Aj4VfFDE8EzvrmHmiq0I9CxoJZAMmE+mYUaWWJzu6CNM+4jWd/SyDIjcr/BmG40Sdr3s e+ao1Efe1LBSnUNdNyzTedN629/nEG+bd9ZuU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fVWA7/D2KvjMyMicmKIzWkp9wEe3Q6Twufyriuc4mnk=; b=h8qo7OobuWl/xxKscfXgIbwS6SburtcGO8LcMx0iK1ZgRSCfwE3ZjGPPqYYVHwVguF lLVTE1/5sg7+eJiXWFk5V5YmdJRoDHwa29538czAfr364lXIgtn4hdQFgMi7DW500uuU nshP3s6TUU2kZwCvIGyFa0CHF0IercaylnK2tYSOQicXCxYQdGpXuARy9bWS24KqmsGb gQk/EBqARHUGvNnd2n8AChDQJC7IEQVlDaRarYyCbQEpxDWsQbLvKoTTfygRbsyyhRVE HAkQFEvUjxVpFaesgrBWfQJBYO526+54viVzwOq4wubgDpnCDVzcPNsyDmnGWCYRNPln O1rA== X-Gm-Message-State: AFqh2kqpYAfjaZy/2ixF1++fTIQZ4ydv/LKHCm9+cqfM42U5JvPZQ8hS 1wXaaPbanbrKZvXp3ABBg0lCZw== X-Received: by 2002:a6b:dc02:0:b0:6e2:d3fa:76eb with SMTP id s2-20020a6bdc02000000b006e2d3fa76ebmr2618945ioc.20.1671676009612; Wed, 21 Dec 2022 18:26:49 -0800 (PST) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id x43-20020a0294ae000000b00375783003fcsm5994321jah.136.2022.12.21.18.26.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 18:26:49 -0800 (PST) From: Matthias Kaehlcke To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Stefan Wahren , stable@vger.kernel.org, Douglas Anderson , Matthias Kaehlcke , Ravi Chandra Sadineni Subject: [PATCH v2 2/2] usb: misc: onboard_hub: Fail silently when there is no platform device Date: Thu, 22 Dec 2022 02:26:45 +0000 Message-Id: <20221222022605.v2.2.I0c5ce35d591fa1f405f213c444522585be5601f0@changeid> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog In-Reply-To: <20221222022605.v2.1.If5e7ec83b1782e4dffa6ea759416a27326c8231d@changeid> References: <20221222022605.v2.1.If5e7ec83b1782e4dffa6ea759416a27326c8231d@changeid> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752879667577092501?= X-GMAIL-MSGID: =?utf-8?q?1752879667577092501?= Some boards with an onboard USB hub supported by the onboard_hub driver have a device tree node for the hub, but the node doesn't specify all properties needed by the driver (which is not a DT error per se). For such a hub no onboard_hub platform device is created. However the USB portion of the onboard hub driver still probes and uses _find_onboard_hub() to find the platform device that corresponds to the hub. If the DT node of the hub doesn't have an associated platform device the function looks for a "peer-hub" node (to get the platform device from there), if that doesn't exist either it logs an error and returns -EINVAL. The absence of a platform device is expected in some configurations, so drop the error log and fail silently with -ENODEV. Fixes: 8bc063641ceb ("usb: misc: Add onboard_usb_hub driver") Signed-off-by: Matthias Kaehlcke Tested-by: Stefan Wahren --- Changes in v2: - patch added to the series drivers/usb/misc/onboard_usb_hub.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index d63c63942af1..44a0b0ddee55 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -348,10 +348,8 @@ static struct onboard_hub *_find_onboard_hub(struct device *dev) pdev = of_find_device_by_node(dev->of_node); if (!pdev) { np = of_parse_phandle(dev->of_node, "peer-hub", 0); - if (!np) { - dev_err(dev, "failed to find device node for peer hub\n"); - return ERR_PTR(-EINVAL); - } + if (!np) + return ERR_PTR(-ENODEV); pdev = of_find_device_by_node(np); of_node_put(np);