From patchwork Wed Dec 21 15:25:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 35402 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp3586148wrn; Wed, 21 Dec 2022 07:27:04 -0800 (PST) X-Google-Smtp-Source: AMrXdXsdQypXWmh7GQEEgY7w5UXOra0M15TEhXhd5AyT8HmRyIamD4CIziSvlpvagVpQl81X7in3 X-Received: by 2002:a17:903:264d:b0:189:2276:30c5 with SMTP id je13-20020a170903264d00b00189227630c5mr2348823plb.0.1671636424193; Wed, 21 Dec 2022 07:27:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671636424; cv=none; d=google.com; s=arc-20160816; b=Q4fGWi26908OWo99AOPFIQW/PIFUrMQufAYX21Q2U81QxeL1gaTD8WNslob6fMD7HS IG29WU/DSa9ZCgTbjX0EbKXphpvaMeKWpy37bAehJtV/8sOzWokai1OrtHW0JRjd2CIN 7wZSv4u6xc6fFs/rKV4xktf7vxKQ+YR+kyyHEgu8BXnK93w1vZjbIVFEzd+yWo9NcSDm g54f8CzU7xYezpZ70tHs4xMlguFaU9Zy5L0bD8M4ALYBiP1mJMRN2777sMBeQt5gPxF+ R1FnSAmFrz4UvfRXAcm2yp21imaE9UeEs6K0cePPPkwl73DtZvr2lnirOsVABPhPil2R 2Yyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XEakEc2TumUj9I0JFZxAmMNH6yQlNW3F3xhK6BoUg1I=; b=V2CyG0pDK0Nx4gkc5wnPpRS4SGDNoly/Ru2Ju/gzEIGGWRGySugKnl+/Y/MCWsmVNj B9chNxbI3YLr3Gj2FbhiraV0iEQTqtGI3YE1/EOO4tGCn2K84MgqOOdfZqfpokrEW7P2 VZGte/SF6TcJD/ZsTa+f6VNemNVL5AyNOWItA2/pN8N0KgDmZQOUFM9hRXeNHDiIsWwv YvjiBuwgp/npne3Y3eqGiC+gxR5n5QkNDF/ctWq/LEf/tQoplQfoCLyWYdRDntj6TsV3 1wI9odPVO7hb+U8+Dcrx7DjX9clStC+Kp1qq5wzkVyva0mn1R8EgrXZehpySlSySyx3O lZAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=Svm6uGAg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j37-20020a63fc25000000b0048441fd28d2si17283123pgi.283.2022.12.21.07.26.50; Wed, 21 Dec 2022 07:27:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=Svm6uGAg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234734AbiLUP0P (ORCPT + 99 others); Wed, 21 Dec 2022 10:26:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234635AbiLUPZt (ORCPT ); Wed, 21 Dec 2022 10:25:49 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C665955B2 for ; Wed, 21 Dec 2022 07:25:46 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id d14so22402525edj.11 for ; Wed, 21 Dec 2022 07:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XEakEc2TumUj9I0JFZxAmMNH6yQlNW3F3xhK6BoUg1I=; b=Svm6uGAgnyBswNXuAPBjKuldylKpri2MOc825zRx/pJ/eJTZj57gSwKEb/ss79pB5U e/zJuDh0q2Vzhlx+gtpvX5N7eyndyiprjLqxkQC04/c0ogjoQJpO7/wKOa9aPwBP902l UIbSSEJ0rfvtkY9ZbiyIkfDlhCM/WH5k1ihWXfA7IKV/AcpLgyPcSWwSdMrGItqJwd9W zFBW8qlu+6IpWm8KXv6rzYOKimpr46si9/0zZUegISClGo9TyensAKIdblDapwZe3TEF 2pRPWpV2EYeuEacnUkGVJLUBsrphRoIw2YxJvFH6LzktA/jmlVFmOc7ZDlp8q7kC994q 3TAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XEakEc2TumUj9I0JFZxAmMNH6yQlNW3F3xhK6BoUg1I=; b=2UzZsZuwCEs+Y7nR9qzwfllU2Plet8TvM+LvP8kGYVaNZb0ayMBiIpfyHeHlZfv13i aJSmJLl4TSCpHyEHHbJuInQQ9U1mv2NlhNasNvc+4gaJumtvCI9xNiwI6EKrtD9CvEa0 Qc3bal5ET7O04kGDhTIFNgZL1+5ZoF/SR92M04ccibkxsiyXMNRBw8qhzuCwDWuU5Q1R 6dZyW3ZZMkRwuQCumjqktWFhjYQ/80Dkq7XpOJ/hBj1ptLBK9FSL2+h0LIIsXoWOPPzp Y1eRR/zUJqaqHlQFDylNOmoYdIC20rQzIkSrXRnNS4hxh87R4YunVY2P5gR/lc0wWcwB YzoA== X-Gm-Message-State: AFqh2krFff8JYu8UKz9+YmQQIyaow+RZwMnlbbIP4cx1Gq2yYspeuHcP BlQ8j1fADW5AFgUHWE7AagBlUA== X-Received: by 2002:a05:6402:240d:b0:46d:731f:d726 with SMTP id t13-20020a056402240d00b0046d731fd726mr2088485eda.22.1671636345373; Wed, 21 Dec 2022 07:25:45 -0800 (PST) Received: from blmsp.fritz.box ([2001:4091:a245:805c:8713:84e4:2a9e:cbe8]) by smtp.gmail.com with ESMTPSA id n19-20020aa7c793000000b0045cf4f72b04sm7105428eds.94.2022.12.21.07.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 07:25:45 -0800 (PST) From: Markus Schneider-Pargmann To: Marc Kleine-Budde , Chandrasekar Ramakrishnan , Wolfgang Grandegger Cc: Vincent MAILHOL , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH 05/18] can: m_can: Remove double interrupt enable Date: Wed, 21 Dec 2022 16:25:24 +0100 Message-Id: <20221221152537.751564-6-msp@baylibre.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221221152537.751564-1-msp@baylibre.com> References: <20221221152537.751564-1-msp@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752837834930078242?= X-GMAIL-MSGID: =?utf-8?q?1752837834930078242?= Interrupts are enabled a few lines further down as well. Remove this second call to enable all interrupts. Signed-off-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 4b387403a7c7..a76465016e17 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1347,7 +1347,6 @@ static void m_can_chip_config(struct net_device *dev) m_can_write(cdev, M_CAN_TEST, test); /* Enable interrupts */ - m_can_write(cdev, M_CAN_IR, IR_ALL_INT); if (!(cdev->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING)) if (cdev->version == 30) m_can_write(cdev, M_CAN_IE, IR_ALL_INT &