From patchwork Wed Dec 21 15:25:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 35401 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp3586104wrn; Wed, 21 Dec 2022 07:26:59 -0800 (PST) X-Google-Smtp-Source: AMrXdXtJCD6YMqerQhRZt0OU0NR0sG22lWuQ3nkJ8MQYIVSaZ6Kf6K+0ukiDJm7gBcD7qW1KqS9v X-Received: by 2002:a17:903:ca:b0:188:da5c:152b with SMTP id x10-20020a17090300ca00b00188da5c152bmr2330150plc.9.1671636419362; Wed, 21 Dec 2022 07:26:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671636419; cv=none; d=google.com; s=arc-20160816; b=AZmx89AQUzbR4ZvTdheTMLVXzMEyBfZU4Jc+rVP4bl9NftPGxjvDxc5qX6VnqHSRf+ RnQj+LQIdW4G/tTVE2lMw5cjWm32U+TzFbs2Nqr1PNF5hS8EpMgRBQXNP/oo2paYXb8D C0bbvfn/aA0YGXIhmP/TJcOsm0+7LOR9vWfUWYE83qlYrPnC6gI1xRbZTUWnEurb3bqc K5ae4KkSSHDPq6xbqIaABngwJO0WyBUzgFR3uxviuK22XSaEqwAiXuR1r3S94yRM+NV+ IWxnzGDBL3FSiXr15U2EGO1vKRc9fbejPCrU/HX5+xaKrOb0RHmD1RAveMnoqYQ+LG0S VuZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Fh+i7sl1pIQRS50o8+ESJqbTkr0TABVbPKqpvGqBGr8=; b=xwg7p59JdcSn3sihDhB857AaK3sAd6i1bZh4IuRxzqBz5Cw+Z8c2hq4a22ZqYOxkdW El9JMzmo5eOXx8ogAZAii7vuBTa7mi0DcDVzmZCg/FYnoABslpOQ1SzU6Oc6by7vZAy4 2d+9Utth0fqajENARLJsZT9CVEnjJZQ4kL3mNPMm3xVmmnynIILjFwMrmtvRdwJFuAm2 cfMi4WFnbwVnVhUqgbz3Qt35IwuUzOO1eBjdmec6/GsyJdGQ2xW24bNfhCXPCoIt/9g2 ZH5u4Me6DFbF5mnks36AwCLAZbGHBK23L1phRCdY9GveQ0HSPXRY38KA+0Kux5iWTk2t 2IUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=Fyz4WV+Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q5-20020a170902dac500b00189feee4923si18461923plx.534.2022.12.21.07.26.46; Wed, 21 Dec 2022 07:26:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=Fyz4WV+Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234651AbiLUP0H (ORCPT + 99 others); Wed, 21 Dec 2022 10:26:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234619AbiLUPZs (ORCPT ); Wed, 21 Dec 2022 10:25:48 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D3F0100E for ; Wed, 21 Dec 2022 07:25:45 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id s5so22402076edc.12 for ; Wed, 21 Dec 2022 07:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fh+i7sl1pIQRS50o8+ESJqbTkr0TABVbPKqpvGqBGr8=; b=Fyz4WV+Qcjmsg/j0ljHqQmf9ASBggxmEprXdUABioB/YrkWMvXLyW92wARKEk7z5Sh PVmefH0BUZ2sLpnpZpjxUO6AcPh/xQIxz+nouiwurmLphKjOvq6jhs3O9ld2nGBof2Rg SO69IPSiiZBHiIaiU8wcRygLOh5Fgt1Fs4+oA4XRBBkr5TKZBBB7ox5obfwgx/7ZqhHs lRoM+7KKOELPyuJFI5uPs49DB979r4D2l3tXaHDCvG0JbAQGEQO72NXSxiCY0G+UWwV3 ynSHEdQ/dn03Ooy4Bw5IntDOfXNjqQf7OD7Sk3mwzFnxyFnFRV1xZE/LbdbbfBl/dZWr sGEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fh+i7sl1pIQRS50o8+ESJqbTkr0TABVbPKqpvGqBGr8=; b=fyn0reLY1gl8uxUMhAuuyooDnZFOa6ndew2a2Lja+EXYoQOKbLKj7hPBvIDp2QK1df SqFugBMEggpaEjc6tEdhmHTnSn7rdL570DsKqoErveOWGpHqSmKkHh8gz1lL4lk042YN 4YR+vnk6VIy4U3IvNwJtqKAi7N3N3XTJMkWQbu3Vb/254DXQynV0frznbrbtb54nw50H faQ19mwskIvvO7M3RCudi2HY5QZxHbozNhiXIzUx3QVySibRd8cJ7rMhNGHqtSiMmr4o izuWGnlqe61nvNFEAoVR7ekhL5Mc8zM3wUZZ2eBTftARLDiaVF6BloQkBmBU+TCFNoAn 15KQ== X-Gm-Message-State: AFqh2koEG4wJLmuXHa4JGUzaBNyTdd/0WqSi7AHF3w/ZDiqR5xwul55z Rw0zMz/4Fdva+vpEd2A03k56cg== X-Received: by 2002:a05:6402:1f15:b0:46c:e2f1:3a81 with SMTP id b21-20020a0564021f1500b0046ce2f13a81mr1815011edb.37.1671636344513; Wed, 21 Dec 2022 07:25:44 -0800 (PST) Received: from blmsp.fritz.box ([2001:4091:a245:805c:8713:84e4:2a9e:cbe8]) by smtp.gmail.com with ESMTPSA id n19-20020aa7c793000000b0045cf4f72b04sm7105428eds.94.2022.12.21.07.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 07:25:44 -0800 (PST) From: Markus Schneider-Pargmann To: Marc Kleine-Budde , Chandrasekar Ramakrishnan , Wolfgang Grandegger Cc: Vincent MAILHOL , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH 04/18] can: m_can: Always acknowledge all interrupts Date: Wed, 21 Dec 2022 16:25:23 +0100 Message-Id: <20221221152537.751564-5-msp@baylibre.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221221152537.751564-1-msp@baylibre.com> References: <20221221152537.751564-1-msp@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752837829868280801?= X-GMAIL-MSGID: =?utf-8?q?1752837829868280801?= The code already exits the function on !ir before this condition. No need to check again if anything is set as IR_ALL_INT is 0xffffffff. Signed-off-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/m_can.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index a43abc667757..4b387403a7c7 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1073,8 +1073,7 @@ static irqreturn_t m_can_isr(int irq, void *dev_id) return IRQ_NONE; /* ACK all irqs */ - if (ir & IR_ALL_INT) - m_can_write(cdev, M_CAN_IR, ir); + m_can_write(cdev, M_CAN_IR, ir); if (cdev->ops->clear_interrupts) cdev->ops->clear_interrupts(cdev);