[v2] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
Commit Message
J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
for 8 channel ADCs for J721s2 SoC.
Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
Changelog v1 -> v2:
- Updated Interrupt Values for tscadc
.../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
.../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
2 files changed, 55 insertions(+), 1 deletion(-)
Comments
On 21/12/2022 06:51, Bhavya Kapoor wrote:
> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
> for 8 channel ADCs for J721s2 SoC.
>
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
>
> Changelog v1 -> v2:
> - Updated Interrupt Values for tscadc
>
> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
> 2 files changed, 55 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> index a7aa6cf08acd..67593aa69327 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> @@ -309,3 +309,17 @@ &mcu_mcan1 {
> pinctrl-0 = <&mcu_mcan1_pins_default>;
> phys = <&transceiver2>;
> };
> +
> +&tscadc0 {
> + status = "okay";
> + adc {
> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
> + };
> +};
> +
> +&tscadc1 {
> + status = "okay";
> + adc {
> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
> + };
> +};
> \ No newline at end of file
Same errors as before.
I don't know how many same patches we need to see - this is fourth. None
of them seems to be correct...
Best regards,
Krzysztof
On 22/12/22 17:32, Krzysztof Kozlowski wrote:
> On 21/12/2022 06:51, Bhavya Kapoor wrote:
>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>> for 8 channel ADCs for J721s2 SoC.
>>
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>> ---
>>
>> Changelog v1 -> v2:
>> - Updated Interrupt Values for tscadc
>>
>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> index a7aa6cf08acd..67593aa69327 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>> phys = <&transceiver2>;
>> };
>> +
>> +&tscadc0 {
>> + status = "okay";
>> + adc {
>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> + };
>> +};
>> +
>> +&tscadc1 {
>> + status = "okay";
>> + adc {
>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>> + };
>> +};
>> \ No newline at end of file
> Same errors as before.
>
> I don't know how many same patches we need to see - this is fourth. None
> of them seems to be correct...
>
> Best regards,
> Krzysztof
>
This is a v2 patch. Please read the changelog. Link to its v1 is
https://lore.kernel.org/all/20221220101249.46450-1-b-kapoor@ti.com/
I mailed to drop other previous patch before this v1 ->
https://lore.kernel.org/all/c61fb922-e4aa-8068-242b-f495e4fc4369@ti.com/
Regards
On 22/12/2022 13:13, Bhavya Kapoor wrote:
>
> On 22/12/22 17:32, Krzysztof Kozlowski wrote:
>> On 21/12/2022 06:51, Bhavya Kapoor wrote:
>>> J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
>>> for 8 channel ADCs for J721s2 SoC.
>>>
>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>>> ---
>>>
>>> Changelog v1 -> v2:
>>> - Updated Interrupt Values for tscadc
>>>
>>> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
>>> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++-
>>> 2 files changed, 55 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> index a7aa6cf08acd..67593aa69327 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
>>> @@ -309,3 +309,17 @@ &mcu_mcan1 {
>>> pinctrl-0 = <&mcu_mcan1_pins_default>;
>>> phys = <&transceiver2>;
>>> };
>>> +
>>> +&tscadc0 {
>>> + status = "okay";
>>> + adc {
>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>> + };
>>> +};
>>> +
>>> +&tscadc1 {
>>> + status = "okay";
>>> + adc {
>>> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
>>> + };
>>> +};
>>> \ No newline at end of file
>> Same errors as before.
>>
>> I don't know how many same patches we need to see - this is fourth. None
>> of them seems to be correct...
>>
>> Best regards,
>> Krzysztof
>>
> This is a v2 patch. Please read the changelog. Link to its v1 is
> https://lore.kernel.org/all/20221220101249.46450-1-b-kapoor@ti.com/
Sure, you still need to correct patch error. I am writing about this
fourth time and you never responded.
Best regards,
Krzysztof
On 22/12/2022 15:07, Bhavya Kapoor wrote:
> Hi, Only comment that I am aware of is:
I wrote:
"Additionally - I commented just before error in your patch. You must
fix it, not ignore it, even though I did not point it out before."
My comment was literally just before error you get from git. Just open
the patch and see the error - no new line.
Best regards,
Krzysztof
@@ -309,3 +309,17 @@ &mcu_mcan1 {
pinctrl-0 = <&mcu_mcan1_pins_default>;
phys = <&transceiver2>;
};
+
+&tscadc0 {
+ status = "okay";
+ adc {
+ ti,adc-channels = <0 1 2 3 4 5 6 7>;
+ };
+};
+
+&tscadc1 {
+ status = "okay";
+ adc {
+ ti,adc-channels = <0 1 2 3 4 5 6 7>;
+ };
+};
\ No newline at end of file
@@ -306,4 +306,44 @@ cpts@3d000 {
ti,cpts-periodic-outputs = <2>;
};
};
-};
+
+ tscadc0: tscadc@40200000 {
+ compatible = "ti,am3359-tscadc";
+ reg = <0x0 0x40200000 0x0 0x1000>;
+ interrupts = <GIC_SPI 860 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&k3_pds 0 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 0 0>;
+ assigned-clocks = <&k3_clks 0 2>;
+ assigned-clock-rates = <60000000>;
+ clock-names = "adc_tsc_fck";
+ dmas = <&main_udmap 0x7400>,
+ <&main_udmap 0x7401>;
+ dma-names = "fifo0", "fifo1";
+ status = "disabled";
+
+ adc {
+ #io-channel-cells = <1>;
+ compatible = "ti,am3359-adc";
+ };
+ };
+
+ tscadc1: tscadc@40210000 {
+ compatible = "ti,am3359-tscadc";
+ reg = <0x0 0x40210000 0x0 0x1000>;
+ interrupts = <GIC_SPI 861 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&k3_pds 1 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 1 0>;
+ assigned-clocks = <&k3_clks 1 2>;
+ assigned-clock-rates = <60000000>;
+ clock-names = "adc_tsc_fck";
+ dmas = <&main_udmap 0x7402>,
+ <&main_udmap 0x7403>;
+ dma-names = "fifo0", "fifo1";
+ status = "disabled";
+
+ adc {
+ #io-channel-cells = <1>;
+ compatible = "ti,am3359-adc";
+ };
+ };
+ };
\ No newline at end of file