From patchwork Tue Dec 20 09:22:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastien Nocera X-Patchwork-Id: 35001 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp2862873wrn; Tue, 20 Dec 2022 01:23:43 -0800 (PST) X-Google-Smtp-Source: AMrXdXuzk17X7W+CdcdDI65QzaCWBFM1zobEUkYjoiHtAqmTD2vRf0sETBAC5qXC8j2y4IwlV0mS X-Received: by 2002:a17:906:1b4e:b0:7b2:c227:126d with SMTP id p14-20020a1709061b4e00b007b2c227126dmr1085021ejg.20.1671528223201; Tue, 20 Dec 2022 01:23:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671528223; cv=none; d=google.com; s=arc-20160816; b=bAnGeim5cZNZ3UsN8Qw++yb/YOhqf6fiAqf2rmp4CLh4YFZAukp36xvb91Jld70tjl Bb1FyP9aYkzlbCw6yFmo69aCKKuFlhlo9hvbUaFDasdDHzGhUgOrq8cbm0P7PJzrBwUH /ZdoFc3Cvo+Q9fDEJ0Au1+LuoSPTwWNVvDuLfCjD7nXLvKv0BECzjn6ffqsN0PlkTbs7 j7JmcEWN9N161s3+vYwepYMpc31CyabMEYOcHhOzWaE3jGwT6P2ijlghbi5pyTdgQPGS m6w9yNSZj9fyci+MaUOCWlSp47Ub7DkXMiv9G7Rix3ZIiRiDvU6nlUI7kwQVxZ7fMagA 0Ivw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=LqcGyNOORjYvyr79URQ1gndkhcU9NNhfu+brYbKKEoM=; b=uy3ygdiYe694hGx9TowGBPyDOfAHiHqMsbUn7Z2Q+KAMPssaFczcxu461Y+pdx/33j hO6nD1VbcyfeOiOPdvEDiSOnZO4SzbEVM23SqnpKbqhbaB3H1WXq5FaEEU+5DnjiVve9 X2CGxHhxEMBv8wdFBCf7ZZSr9MGAwcGQmpmCA44fNkRjV0tE5D0Gs/8JYIbvXm0wDYy8 ZC3R0hcR6lQFV3TBbIhyQCcTmFPUKXHCXCYA6OrP9Rwu6a6TSy2Lw4U/Spo3O9qzCA49 tivJrQklUKC1MQEZFzUib92ojnhcdeQSITQ2g3d/u9VFFvXdYIJKDyvY4iHOVXK1Cklx L1jA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf20-20020a1709077f1400b007c1052c9243si12865638ejc.15.2022.12.20.01.23.19; Tue, 20 Dec 2022 01:23:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233437AbiLTJW0 (ORCPT + 99 others); Tue, 20 Dec 2022 04:22:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233409AbiLTJWN (ORCPT ); Tue, 20 Dec 2022 04:22:13 -0500 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2468F26FF; Tue, 20 Dec 2022 01:22:11 -0800 (PST) Received: (Authenticated sender: hadess@hadess.net) by mail.gandi.net (Postfix) with ESMTPSA id 3A1041C0007; Tue, 20 Dec 2022 09:22:08 +0000 (UTC) From: Bastien Nocera To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , "Peter F . Patel-Schneider" , =?utf-8?q?Filipe_La?= =?utf-8?q?=C3=ADns?= , Nestor Lopez Casado Subject: [PATCH 1/3] Revert "HID: logitech-hidpp: add a module parameter to keep firmware gestures" Date: Tue, 20 Dec 2022 10:22:05 +0100 Message-Id: <20221220092207.428640-1-hadess@hadess.net> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752724377985334074?= X-GMAIL-MSGID: =?utf-8?q?1752724377985334074?= Now that we're in 2022, and the majority of desktop environments can and should support touchpad gestures through libinput, remove the legacy module parameter that made it possible to use gestures implemented in firmware. This will eventually allow simplifying the driver's initialisation code. This reverts commit 9188dbaed68a4b23dc96eba165265c08caa7dc2a. --- drivers/hid/hid-logitech-hidpp.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 08ad19097e9e..7f9187201913 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -32,11 +32,6 @@ MODULE_LICENSE("GPL"); MODULE_AUTHOR("Benjamin Tissoires "); MODULE_AUTHOR("Nestor Lopez Casado "); -static bool disable_raw_mode; -module_param(disable_raw_mode, bool, 0644); -MODULE_PARM_DESC(disable_raw_mode, - "Disable Raw mode reporting for touchpads and keep firmware gestures."); - static bool disable_tap_to_click; module_param(disable_tap_to_click, bool, 0644); MODULE_PARM_DESC(disable_tap_to_click, @@ -4355,11 +4350,6 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) hidpp_application_equals(hdev, HID_GD_KEYBOARD)) hidpp->quirks |= HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS; - if (disable_raw_mode) { - hidpp->quirks &= ~HIDPP_QUIRK_CLASS_WTP; - hidpp->quirks &= ~HIDPP_QUIRK_NO_HIDINPUT; - } - if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) { ret = wtp_allocate(hdev, id); if (ret)