diff mbox series

dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries

Message ID 20221219194241.3817250-1-hugo@hugovil.com
State New
Headers
Series dt-bindings: rtc: pcf2127: add missing pcf/pca2129 entries |

Commit Message

Hugo Villeneuve Dec. 19, 2022, 7:42 p.m. UTC 
  From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also
contains:
    nxp,pcf2129
    ncp,pca2129

Add these missing entries.

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
 Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


base-commit: e88f319a2546fd7772c726bf3a82a23b0859ddeb

Comments

Rob Herring Dec. 19, 2022, 10:03 p.m. UTC | #1 
On Mon, Dec 19, 2022 at 02:42:40PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also
> contains:
>     nxp,pcf2129
>     ncp,pca2129
> 
> Add these missing entries.
> 
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
>  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index cde7b1675ead..00dbae7e23c2 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -14,7 +14,10 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: nxp,pcf2127
> +    enum:
> +      - nxp,pcf2127
> +      - nxp,pcf2129
> +      - ncp,pca2129

Check Documentation/devicetree/bindings/rtc/trivial-rtc.yaml.

Maybe they aren't trivial after all and should be removed? Or 
nxp,pcf2127 is also trivial?

Rob

P.S. 'make dt_compatible_check' will check in the kernel for 
undocumented (by a schema) compatibles.
Hugo Villeneuve Dec. 19, 2022, 10:52 p.m. UTC | #2 
On Mon, 19 Dec 2022 16:03:35 -0600
Rob Herring <robh@kernel.org> wrote:

> On Mon, Dec 19, 2022 at 02:42:40PM -0500, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > 
> > The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also
> > contains:
> >     nxp,pcf2129
> >     ncp,pca2129
> > 
> > Add these missing entries.
> > 
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > ---
> >  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > index cde7b1675ead..00dbae7e23c2 100644
> > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > @@ -14,7 +14,10 @@ maintainers:
> >  
> >  properties:
> >    compatible:
> > -    const: nxp,pcf2127
> > +    enum:
> > +      - nxp,pcf2127
> > +      - nxp,pcf2129
> > +      - ncp,pca2129
> 
> Check Documentation/devicetree/bindings/rtc/trivial-rtc.yaml.
> 
> Maybe they aren't trivial after all and should be removed? Or 
> nxp,pcf2127 is also trivial?

Hi Rob,
the pcf2127, and also the pca/pcf2129, can use the "reset-source" property. Are they still considered "trivial" devices then?

Hugo.


> P.S. 'make dt_compatible_check' will check in the kernel for 
> undocumented (by a schema) compatibles.
>
Krzysztof Kozlowski Dec. 20, 2022, 10:16 a.m. UTC | #3 
On 19/12/2022 20:42, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also
> contains:
>     nxp,pcf2129
>     ncp,pca2129
> 
> Add these missing entries.
> 
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
>  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index cde7b1675ead..00dbae7e23c2 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -14,7 +14,10 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: nxp,pcf2127
> +    enum:
> +      - nxp,pcf2127
> +      - nxp,pcf2129
> +      - ncp,pca2129

Keep the entries sorted, e.g. alphabetically.

Best regards,
Krzysztof
Krzysztof Kozlowski Dec. 20, 2022, 10:17 a.m. UTC | #4 
On 19/12/2022 23:52, Hugo Villeneuve wrote:
> On Mon, 19 Dec 2022 16:03:35 -0600
> Rob Herring <robh@kernel.org> wrote:
> 
>> On Mon, Dec 19, 2022 at 02:42:40PM -0500, Hugo Villeneuve wrote:
>>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>>>
>>> The pcf2127_of_match structure in drivers/rtc/rtc-pcf2127.c also
>>> contains:
>>>     nxp,pcf2129
>>>     ncp,pca2129
>>>
>>> Add these missing entries.
>>>
>>> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>>> ---
>>>  Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 5 ++++-
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
>>> index cde7b1675ead..00dbae7e23c2 100644
>>> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
>>> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
>>> @@ -14,7 +14,10 @@ maintainers:
>>>  
>>>  properties:
>>>    compatible:
>>> -    const: nxp,pcf2127
>>> +    enum:
>>> +      - nxp,pcf2127
>>> +      - nxp,pcf2129
>>> +      - ncp,pca2129
>>
>> Check Documentation/devicetree/bindings/rtc/trivial-rtc.yaml.
>>
>> Maybe they aren't trivial after all and should be removed? Or 
>> nxp,pcf2127 is also trivial?
> 
> Hi Rob,
> the pcf2127, and also the pca/pcf2129, can use the "reset-source" property. Are they still considered "trivial" devices then?

Then they do not look trivial, so please remove them from trivial-rtc.yaml.



Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
index cde7b1675ead..00dbae7e23c2 100644
--- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
+++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
@@ -14,7 +14,10 @@  maintainers:
 
 properties:
   compatible:
-    const: nxp,pcf2127
+    enum:
+      - nxp,pcf2127
+      - nxp,pcf2129
+      - ncp,pca2129
 
   reg:
     maxItems: 1