From patchwork Mon Dec 19 12:32:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 34518 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp2358534wrn; Mon, 19 Dec 2022 04:33:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf7LF7gf/+OIWwr6l5c3O7jl4q9EmuoRvojTiEMe+bAwAa9AhGiX2I21LPPXToZdAlo/UwOw X-Received: by 2002:aa7:96d4:0:b0:576:8e8d:6675 with SMTP id h20-20020aa796d4000000b005768e8d6675mr47380909pfq.19.1671453200563; Mon, 19 Dec 2022 04:33:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671453200; cv=none; d=google.com; s=arc-20160816; b=xnVnJjoi/vl0VNfTN7IywvIHyGfKZ0ptpBdT6dGwKJ7sDRSrdzK8Fw7NcDYJ3yp0gH UQf9/AzKONtUz/i/J9lKgrZH3Bg2g3+akenMRvUdkG0I3YXfGC3Zy29RcXlmZAScmK1q l/6kdD6YStOiKyQ7JnctLI1cahwtsvshQJmMlAbzxLgFmSyTEYmKEzLBX62FIrdVdPEJ 6ICTRpeoBuaujohw7iuRSZOphjnewqS7VSObG83286x4RfO4JmP9GUQfBO2SyB1AEaDM X9VaSS12WMxDpbwm/iNK5EjHSPJJFmPQoOX6iYMTgFgUx3aGktgAMQUf1DQ3DNXdCG6d gh7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QCcJteLTGOtCNBPtxm6/mxHmODlUOIpzDTbfc8iuKzw=; b=AcylSHtsnhlQmzPogRrp/ntTOOO34SaL1vu97IaUvhMSh6VquTqPQrUftaKrd8qtVp V6AlikHNqfdwQxgqAucXoCeGHjjCwmSNrWziyoMJlhMbE79zraPP3UPXGvC7yKOIEGGp bjW1hu25sKCRjd1e6mcTiGF8foO4awPW35TP56EZDXfcDvWmCdLJgzJ226JEYXKLNKhW zJldVrTqE5CbeHIytSD3TTN3BgVA5rd0AZdr7NwxtSo94XFJBVuDVt/vg40Mnf6/WNow 1O58irzXrNXZABKC8/43z/YdKTM1sgsf1MyzaRwrfVOBVJeeLC1evq5+BNhO7g0J0AJM UYXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=O8s7VviL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y22-20020a056a00181600b005728c05ef9esi11626197pfa.14.2022.12.19.04.33.07; Mon, 19 Dec 2022 04:33:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=O8s7VviL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231862AbiLSMdC (ORCPT + 99 others); Mon, 19 Dec 2022 07:33:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232063AbiLSMch (ORCPT ); Mon, 19 Dec 2022 07:32:37 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC3E1EE1D; Mon, 19 Dec 2022 04:31:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671453106; x=1702989106; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=eN8P+N64P95zR91Fwvb5XL2UO1+uvpxDLZPoDQkp4Ig=; b=O8s7VviL+cw9tp9FrDRMaajNKt8ltgGY2Rijq1XO99LsyZG/SikFjUe0 Cw580K0qzxISf/Tj87jAaD4uY1G5EK9067KinJKnIddsoexM3cpvttD7T 8FUkLOCX5zs8YTch2zpvo7T1Vx+8azxxcMT+nDZslqjI6EHrchtKH+m6I 2MkpBg4dk+ThHRZbXM95cjL3zWgDaQfsCjjXOQN1sG/o499R5Uk7VKzF4 Hhzu5R7YtJQ5qXGe+xyqzQBi1pO7mfHEoyuOv0+iwCxEyQpPBD9Q0e9yT lU30fTYD4hWAArQUEy1x+5tBlm4aecgM3BCzzJE5lpMSTi99oM5BVKwZV w==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="299670630" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="299670630" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 04:31:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="896027912" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="896027912" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga006.fm.intel.com with ESMTP; 19 Dec 2022 04:31:43 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id CB011F7; Mon, 19 Dec 2022 14:32:13 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Andy Shevchenko , Linus Walleij Subject: [PATCH v1 1/4] pinctrl: intel: Add default case to intel_config_set_pull() Date: Mon, 19 Dec 2022 14:32:05 +0200 Message-Id: <20221219123208.5505-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752645711509175671?= X-GMAIL-MSGID: =?utf-8?q?1752645711509175671?= For the sake of symmetry with intel_config_get_pull(), add a default case to the outer switch. Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-intel.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 8181a65fb815..4b1d5a21aa68 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -758,6 +758,10 @@ static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned int pin, } break; + + default: + ret = -EINVAL; + break; } if (!ret)