From patchwork Mon Dec 19 11:57:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 34484 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp2343919wrn; Mon, 19 Dec 2022 04:02:57 -0800 (PST) X-Google-Smtp-Source: AMrXdXs3ngxXFp9I469O457tLb7puxbtn74ClOk+fsxho41QTydsKw6CbuG0++nsoX+9h5pemtbs X-Received: by 2002:a05:6a20:2d22:b0:b0:1abd:8604 with SMTP id g34-20020a056a202d2200b000b01abd8604mr8519163pzl.41.1671451376786; Mon, 19 Dec 2022 04:02:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671451376; cv=none; d=google.com; s=arc-20160816; b=Nh6dps+R51Vv64AoM3Sig7nQtzcE27uW/zbjpF0Zr9u4Nd38aZPc/zRMdtsiyXWKm1 2NzymeUqxZ80AD8eCTKGP6fF3ea4PzTtOioPN3Nxob19C5fR/prkMCVEimyMxNs8EWII Z3JfsSdMOElic/C/xk0AYj9i3hED/vPvH8Ra9B584FZEq2p6ADFxEW5jdaxnI9tbQkZ4 +mIlYMbdEaN+ep+0EZAAJGPPMjOraU3GYI08Sber+3Y4KZSjgNO1MkNT8atjmsQVMs74 pvLnrf0cFxcsOk8YOipJ74HseoOXtg2c8edLxWa0URuqr/pjZktTHv1vr0Odkbk8BP/1 H1aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BnacRbbY/v/FN0BxUxB8bU+aqBdRLSa7i4FnTA7deQ0=; b=CgM7mhnePFtDdNvSryfsAfVZdLjK0opvTBzFSIhnagde9Foox40EL72lF08HYvcnbR +t74lDpwE3knnCs7trpFIWP0tLthxcyCDWLOTvxNDfywErZoarUqz/6Fyb5r33s7Vmxm NuT/vY+EEu6Vjnwxfi0K/Y5oTr94TCFITamZPrqxgC4AkRAkWz99K5K3tDe+Ifq/1vt/ Go3UHPC6DIq5f2xcCIh86Wb0upuOZmcyyigv39U5rraU1V+gJS4PZteMYDszxYIcIgge WYXoVt6kN7m2ynyiCKQKvjwTfFjgUNieaXhfY1lSs4PZhjDfH/6B8CxCOxCqmu+Woeyd G2zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=pIh8IVwU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 77-20020a630150000000b004782ca58117si10480126pgb.611.2022.12.19.04.02.43; Mon, 19 Dec 2022 04:02:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=pIh8IVwU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229598AbiLSL64 (ORCPT + 99 others); Mon, 19 Dec 2022 06:58:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231602AbiLSL63 (ORCPT ); Mon, 19 Dec 2022 06:58:29 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9B8BB4AA; Mon, 19 Dec 2022 03:58:27 -0800 (PST) Received: from umang.jainideasonboard.com (unknown [IPv6:2401:4900:1f3e:7d24:3f0:3e81:fb16:ab4d]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 02756825; Mon, 19 Dec 2022 12:58:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671451106; bh=aaumRJIlPyO334JageSyVTFWQcGmFZVA0qlebhmqQM8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pIh8IVwUzeljCDadac6rHsPCeLYocKmooGmbIm1MDeU54544W1A4nX0VvnOd5HM+k RTwgBJ0NcqYb4HMjYvLHU9x2PkVzV05BmYQfpFHnT6ykSyZ7/PokwCAYJj55rPNXDt 11DJFj7OOOW2IA6msIkmPMbWc6bEgXhQuFeZp0Rc= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kees Cook , Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [PATCH v2 7/7] staging: vc04_services: vchiq: Drop custom return values from TODO Date: Mon, 19 Dec 2022 17:27:25 +0530 Message-Id: <20221219115725.11992-8-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221219115725.11992-1-umang.jain@ideasonboard.com> References: <20221219115725.11992-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752643798721831814?= X-GMAIL-MSGID: =?utf-8?q?1752643798721831814?= The custom return values (enum vchiq_status) has been dropped. Remove the TODO entry for the same. Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/TODO | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 97085a0b3223..6d9d4a800aa7 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -40,11 +40,6 @@ beneficial to go over all of them and, if correct, comment on their merits. Extra points to whomever confidently reviews the remote_event_*() family of functions. -* Get rid of custom function return values - -Most functions use a custom set of return values, we should force proper Linux -error numbers. Special care is needed for VCHIQ_RETRY. - * Reformat core code with more sane indentations The code follows the 80 characters limitation yet tends to go 3 or 4 levels of