From patchwork Mon Dec 19 06:15:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: shravan chippa X-Patchwork-Id: 34401 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp2220967wrn; Sun, 18 Dec 2022 22:19:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf6OhO2NmEHZ0yzJnYJVRYGgZB5SJiloEROep+8XR/ZKRfsflWN0QrqQZVVcFWwMlqKWK2c1 X-Received: by 2002:aa7:c047:0:b0:46d:6efb:b47a with SMTP id k7-20020aa7c047000000b0046d6efbb47amr33169389edo.41.1671430762598; Sun, 18 Dec 2022 22:19:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671430762; cv=none; d=google.com; s=arc-20160816; b=xYysfqRU8yJG/PrgoOhXYMs2Cbn6VbsuZI0IUm6JLzsGZhTJiWQlYvGgdqTpKRCMer YvYoDPLaWaLh3VeRUoy8giWFGlepR8XpZfYMM6VpHDRZ7H2rs6Ri4nflV0zPEqu2n+qo oP3Lyhje7wFKxlWHV0ZRBodCFg+P9TdVfq5jjHktYriQs0qgGzDJAsLzJ9/NwaecIqBM tt1bLrji2ke7RiDgIFNgXq+VT2FBrSWgeYAGcaZRzdKEpwzM++0BUZYYsGes2yXsbaqR hBsa2v7CDixbIhLMwX5BNa5HI231a/Cqo4WSrmLOBsNzgyW3nshss5i/xrmshnsttpYl ppTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iclWbWphq1AjeEOfInG5jgMTLhbz0kYJaZ446wyIzMg=; b=MYTyZbzg6+kI3UhRzHhgHTgfF8gBTLdj2bP6XUUOuQO1bYhw+/Q3MKXF+8iFE1T5hZ jykozSPrDQ7XKgVBEYKhgXHwYLNPSyUCE4wgVtqJEBdhKEhRFwy1ZevU0JUrGg0ocZUs AP7/o5MzaIMvk1f+XMSm378sIs3p7//QOp+4M8pFBgj1j/6bjusT/2fIMdiVJ0r90kcQ B2VCl8++/hh0BFTz54jMhr8vR6kTY8lMcsD7tn2yoWiqL83FPxIKluHfK2zhmSdofNTm ZV7J3E5btb9Th2N4zG1gDyncjzcXddW+ZyYyVaSlpw4MVWUNVHtncDP6VZqEoLmXdbve 07Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=0fec5J4H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x16-20020a05640226d000b0045d189ac612si9618234edd.402.2022.12.18.22.18.56; Sun, 18 Dec 2022 22:19:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=0fec5J4H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231301AbiLSGPr (ORCPT + 99 others); Mon, 19 Dec 2022 01:15:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231225AbiLSGPl (ORCPT ); Mon, 19 Dec 2022 01:15:41 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDB1E10D; Sun, 18 Dec 2022 22:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1671430542; x=1702966542; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qsJvK2VpBu4Gb2ZvUzYx5074zsrdEggN0+SM/yXO0po=; b=0fec5J4Hmmpe1ku4XyKHGoJ6JuCuQtmRp5K19PzyfYJO8/pi7BNpJLKs F4EiYIHTW4CcSxGV49D7xaGimrVx7aNtnUQZOMOeZiaTwCMeg39cMTZbE J6+1NvImLiZ8HB2gyefyIMHHtU0aBQK/GqonDNMc+EKBo0DUkddL8xzSf saqwHavV+BMEvosHjbWyTVjaaTKv1pApjCiKg/T2aVQTsiEZPcGv6z2ue y+dQoGXnc+3gyj3Oqnyvc0g2ep1vNkyTf423RBQAUrzgwk6m4ni+2U/I9 owXiY+u1HA92Mu0EhQlHJKjgX2Kgv4O998weoy6TtQVvH39kAREz5Ro6w g==; X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="193603883" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 18 Dec 2022 23:15:41 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 23:15:40 -0700 Received: from microchip1-OptiPlex-9020.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Sun, 18 Dec 2022 23:15:37 -0700 From: shravan kumar To: , , CC: , , "shravan kumar" , Jacopo Mondi Subject: [PATCH v7 2/5] media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to __v4l2_ctrl_modify_range Date: Mon, 19 Dec 2022 11:45:23 +0530 Message-ID: <20221219061526.3169369-3-shravan.chippa@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221219061526.3169369-1-shravan.chippa@microchip.com> References: <20221219061526.3169369-1-shravan.chippa@microchip.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752622183692463840?= X-GMAIL-MSGID: =?utf-8?q?1752622183692463840?= From: Shravan Chippa For evry mode we will get new set of values for hbalnk so use __v4l2_ctrl_modify_range() to support multi modes for hblank. The hblank value is readonly in the driver. because of this the function returns error if we try to change. so added dumy return case in imx334_set_ctrl function Suggested-by: Jacopo Mondi Signed-off-by: Shravan Chippa --- drivers/media/i2c/imx334.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c index acc9f9f15e47..a742b60ea3b0 100644 --- a/drivers/media/i2c/imx334.c +++ b/drivers/media/i2c/imx334.c @@ -382,7 +382,8 @@ static int imx334_update_controls(struct imx334 *imx334, if (ret) return ret; - ret = __v4l2_ctrl_s_ctrl(imx334->hblank_ctrl, mode->hblank); + ret = __v4l2_ctrl_modify_range(imx334->hblank_ctrl, mode->hblank, + mode->hblank, 1, mode->hblank); if (ret) return ret; @@ -480,6 +481,9 @@ static int imx334_set_ctrl(struct v4l2_ctrl *ctrl) pm_runtime_put(imx334->dev); + break; + case V4L2_CID_HBLANK: + ret = 0; break; default: dev_err(imx334->dev, "Invalid control %d", ctrl->id);