diff mbox series

[1/9] perf srcline: Do not return NULL for srcline

Message ID	20221215192817.2734573-2-namhyung@kernel.org
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Sender: Namhyung Kim <namhyung@gmail.com> From: Namhyung Kim <namhyung@kernel.org> To: Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@kernel.org> Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>, LKML <linux-kernel@vger.kernel.org>, Ian Rogers <irogers@google.com>, Adrian Hunter <adrian.hunter@intel.com>, linux-perf-users@vger.kernel.org, Andi Kleen <ak@linux.intel.com>, Milian Wolff <milian.wolff@kdab.com>, Leo Yan <leo.yan@linaro.org> Subject: [PATCH 1/9] perf srcline: Do not return NULL for srcline Date: Thu, 15 Dec 2022 11:28:09 -0800 Message-Id: <20221215192817.2734573-2-namhyung@kernel.org> In-Reply-To: <20221215192817.2734573-1-namhyung@kernel.org> References: <20221215192817.2734573-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	perf report: Improve srcline sort performance (v1) \| [PATCHSET,0/9] perf report: Improve srcline sort performance (v1) [1/9] perf srcline: Do not return NULL for srcline [2/9] perf report: Ignore SIGPIPE for srcline [3/9] perf symbol: Add filename__has_section() [4/9] perf srcline: Skip srcline if .debug_line is missing [5/9] perf srcline: Conditionally suppress addr2line warnings [6/9] perf hist: Add perf_hpp_fmt->init() callback [7/9] perf hist: Improve srcline sort key performance [8/9] perf hist: Improve srcfile sort key performance [9/9] perf hist: Improve srcline_{from,to} sort key performance

Commit Message

Namhyung Kim Dec. 15, 2022, 7:28 p.m. UTC

  The code assumes non-NULL srcline value always, let's return the usual
SRCLINE_UNKNOWN ("??:0") string instead.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/util/srcline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
index af468e3bb6fa..5319efb16a5a 100644
--- a/tools/perf/util/srcline.c
+++ b/tools/perf/util/srcline.c
@@ -716,7 +716,7 @@  char *__get_srcline(struct dso *dso, u64 addr, struct symbol *sym,
 
 	if (!show_addr)
 		return (show_sym && sym) ?
-			    strndup(sym->name, sym->namelen) : NULL;
+			    strndup(sym->name, sym->namelen) : SRCLINE_UNKNOWN;
 
 	if (sym) {
 		if (asprintf(&srcline, "%s+%" PRIu64, show_sym ? sym->name : "",