Message ID | 20221215093615.3794156-1-lukma@denx.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp249954wrn; Thu, 15 Dec 2022 01:46:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf5+XUbf1C2DvyI+Tbh5HJK4OSM2JnljhyTyYsaHxV1QzrErcT1+cRMTIdjZ3DkcU8I9hEFN X-Received: by 2002:a17:906:141a:b0:7c1:4e5d:d8a0 with SMTP id p26-20020a170906141a00b007c14e5dd8a0mr18778635ejc.76.1671097593433; Thu, 15 Dec 2022 01:46:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671097593; cv=none; d=google.com; s=arc-20160816; b=UPHWNQZvRPM6kMspxCU1c54Jtz8fWOpr1k6+SgLGyntY33R68KF2H+8ScuuKuCvH8k QNSflJv07a3iJIEZ1dAteZbshbjRNN4uyThRXwV31mwrcU9lyOdK9YtxbQ4aQEiMNC2l 1SMOHrUFRrz6689zcFuUQK4/FO+YvhjpubuVZrCV+G46vMDhM7J6JL9INrdx+IbK7fDp qeP1Yg4dS6uhTAI5VgOy54wSVCKRYC5jYE5tKlYERq0T+8q/DKMAl5DBFgUv0c9zFIQO 6rTMjRW0JN/J/pI5UyiPdGoh9MrPdbhydj6bXJiKXse9f8s0ucEpq9etwPboHz0QtQ2Z TJiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wGXPtmxbRwI+rePwZplrD77uCTTd1SabaklEZ+nfpp0=; b=J6Za0RU6MRqv7B3Kg2HYAs4RmpeCEaJ8YkRM0vSbGmwkjQd6YzQDTN62exk/cTfX4e unNHP2eXMdngNcqrHRArXmO/nEdfBHHpJjnlDDkA1vO8rB/YDwt+r+jWBiSvPr+yKfc/ McoVvpnFczan3cX8AFjGR58V05SjOz4mwpfAD4BMGRHRjwAd5zB/jDJ9lgYpCNTT9Hqh oeWQJXoKDSvbdaRSHGnw2IFfboSAV721486xGakR8Xq0zF06MvJqjFCxB0iDFMZMzRWb at+6OrHX7siR7MPZLJeZKkEatA15xLyKAWg3YWOkc40P4hcEkcVBkBDBFhWgEys4rs54 aPag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=xfpHa+UL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa17-20020a1709076d1100b007b99436026dsi14388125ejc.968.2022.12.15.01.46.10; Thu, 15 Dec 2022 01:46:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@denx.de header.s=phobos-20191101 header.b=xfpHa+UL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229960AbiLOJgk (ORCPT <rfc822;jeantsuru.cumc.mandola@gmail.com> + 99 others); Thu, 15 Dec 2022 04:36:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbiLOJgh (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 15 Dec 2022 04:36:37 -0500 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 713381D647 for <linux-kernel@vger.kernel.org>; Thu, 15 Dec 2022 01:36:35 -0800 (PST) Received: from localhost.localdomain (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id F39FB8536C; Thu, 15 Dec 2022 10:36:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1671096993; bh=wGXPtmxbRwI+rePwZplrD77uCTTd1SabaklEZ+nfpp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xfpHa+ULf3pVK6flQwj+EpURMr9coLTyRMBicuWYeyUxi9aUH1Ott5idwEDD5J6rQ 35FTRfbEXs/O9sQQ9K8omKOeCP2PMwjoWLJWlnSoM9bRY27xIyj/Dh9Zh618f7IFCo JofkM/JdZC7cbhEvWqMNkliFBED164onqbm1CpNFmEcb0ao60KhDSVyFlfaSC0FQi5 uMeecYvJPc5/idGoPL4ucbSl/INiAs5UJ3A4WnEZSXBcRt8M4j4eGIfirvIBsiqVZq 4TXR1BDXJOFZRUiwYSSsspiP/UYEtC7/hXMpG+RP79wQGhwviw5nop/UMNYqbzw6am ON0sMYkd3GlqA== From: Lukasz Majewski <lukma@denx.de> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Charles Keepax <ckeepax@opensource.cirrus.com> Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Stephen Kitt <steve@sk2.org>, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Lukasz Majewski <lukma@denx.de> Subject: [PATCH v2 1/3] ASoC: wm8940: Remove warning when no plat data present Date: Thu, 15 Dec 2022 10:36:13 +0100 Message-Id: <20221215093615.3794156-1-lukma@denx.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221214123743.3713843-1-lukma@denx.de> References: <20221214123743.3713843-1-lukma@denx.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752193437047227090?= X-GMAIL-MSGID: =?utf-8?q?1752272830532832928?= |
Series |
[v2,1/3] ASoC: wm8940: Remove warning when no plat data present
|
|
Commit Message
Lukasz Majewski
Dec. 15, 2022, 9:36 a.m. UTC
The lack of platform data in the contemporary Linux shall not be the reason to display warnings to the kernel logs. Signed-off-by: Lukasz Majewski <lukma@denx.de> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- Changes for v2: - None --- sound/soc/codecs/wm8940.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Comments
On Thu, Dec 15, 2022 at 10:36:13AM +0100, Lukasz Majewski wrote: > The lack of platform data in the contemporary Linux > shall not be the reason to display warnings to the > kernel logs. Please don't send new patches in reply to old patches or serieses, this makes it harder for both people and tools to understand what is going on - it can bury things in mailboxes and make it difficult to keep track of what current patches are, both for the new patches and the old ones.
Hi Mark, > On Thu, Dec 15, 2022 at 10:36:13AM +0100, Lukasz Majewski wrote: > > The lack of platform data in the contemporary Linux > > shall not be the reason to display warnings to the > > kernel logs. > > Please don't send new patches in reply to old patches or serieses, > this makes it harder for both people and tools to understand what is > going on - it can bury things in mailboxes and make it difficult to > keep track of what current patches are, both for the new patches and > the old ones. Ok. I will not use --in-reply-to. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/sound/soc/codecs/wm8940.c b/sound/soc/codecs/wm8940.c index 8dac9fd88547..0b59020d747f 100644 --- a/sound/soc/codecs/wm8940.c +++ b/sound/soc/codecs/wm8940.c @@ -709,9 +709,7 @@ static int wm8940_probe(struct snd_soc_component *component) if (ret < 0) return ret; - if (!pdata) - dev_warn(component->dev, "No platform data supplied\n"); - else { + if (pdata) { reg = snd_soc_component_read(component, WM8940_OUTPUTCTL); ret = snd_soc_component_write(component, WM8940_OUTPUTCTL, reg | pdata->vroi); if (ret < 0)