From patchwork Thu Dec 15 06:58:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 33529 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp192254wrn; Wed, 14 Dec 2022 23:15:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf6/pP35Ps1Wjr7hhz2Jg1OHevqV2VcdfRFPeqQ/nxNAfM+gqdJNBXs/NIFnhpfjghb4rnHi X-Received: by 2002:a17:907:d68e:b0:7c1:4f7c:947f with SMTP id wf14-20020a170907d68e00b007c14f7c947fmr11211092ejc.72.1671088535383; Wed, 14 Dec 2022 23:15:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671088535; cv=none; d=google.com; s=arc-20160816; b=S+ceH0XVCqd48pfjQn/pwjHNWnkgiuAQJ5SVLGFAujmaMecdKZdhKrh041mlAq5GfE SKfco1xrJhyj0MVrVzLyzL2y2LjJBzBiE1sE4HTD1PQC6ysuCgBkBA1HUG2qJap8wiAC E3uK9I0fsSrIEICvjtUrJ9D2ukF3r2iT7fQriCszzgbaOdcXIpjQsoP0UPwrUSEzRwYB pCcY4DIm6Q6vmqBalA5BgvyLuVcWtkYB20ggmq5rOUhBlg79D43BHTEhyQsawH6jYprg TiLkzrwwa/mvkd2yfc+yg5rfF4T7Toq997rRn6qIUXaWL3ZP05VT5coB/X/1eRYWGo3O 0JLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BnacRbbY/v/FN0BxUxB8bU+aqBdRLSa7i4FnTA7deQ0=; b=ChdLbZxydfLG1qa+eRvSDki+UgS/n894pORixQkbWdQPlfGNT8N6aY1uM7mAMFUMGR 0ojBuHKKAcNe7HDB2VluEhBTMQm6tSnFXSxNUS2msUR0S3mlaOIRnTVBP2AVlGrSYv3J m908ogc7l/9rD2YFyuNXYrrbtf7owd7xyjjAWBc1INIwqkLOl/5jwYAwsCvypUXk5L1X VzR+r2ukJc+Js3hkP2S6JewndvIw2Y6Dl2s8SvJaSPUZs07zN8kFfbEfjPgHgid3rX3j /xZ5Y26nyJnvTEFr9+/Y6JdBeZ8+TI2ak/wHa+8K1YSzzrmn4BmNezf3feCGxL5aGbcQ Y/KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=hjAV0GRM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kg27-20020a17090776fb00b007be268708b3si10249378ejc.926.2022.12.14.23.15.11; Wed, 14 Dec 2022 23:15:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=hjAV0GRM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230058AbiLOHG1 (ORCPT + 99 others); Thu, 15 Dec 2022 02:06:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229899AbiLOHFl (ORCPT ); Thu, 15 Dec 2022 02:05:41 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70F3C6C738; Wed, 14 Dec 2022 23:00:15 -0800 (PST) Received: from umang.jainideasonboard.com (unknown [IPv6:2401:4900:1f3e:7d24:3f0:3e81:fb16:ab4d]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4BB8B32A2; Thu, 15 Dec 2022 08:00:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671087614; bh=aaumRJIlPyO334JageSyVTFWQcGmFZVA0qlebhmqQM8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hjAV0GRMaH9AOwpZVewhUJG584hEpfaameBGX98e+DYefpzd05cfRUbcb87DRzHNn WNHMC+GnKztmHMqjDq7/IwUNGmGNFYVgIWbz077VYk0wYceodr5oGXaidKwBJpHp1X zgJHAebibMcQvVOLxiZFDQ5rxCG6lVQrQqcvuMfM= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kees Cook , Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [PATCH 7/7] staging: vc04_services: vchiq: Drop custom return values from TODO Date: Thu, 15 Dec 2022 12:28:53 +0530 Message-Id: <20221215065853.34477-8-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221215065853.34477-1-umang.jain@ideasonboard.com> References: <20221215065853.34477-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752263332050892467?= X-GMAIL-MSGID: =?utf-8?q?1752263332050892467?= The custom return values (enum vchiq_status) has been dropped. Remove the TODO entry for the same. Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/TODO | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 97085a0b3223..6d9d4a800aa7 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -40,11 +40,6 @@ beneficial to go over all of them and, if correct, comment on their merits. Extra points to whomever confidently reviews the remote_event_*() family of functions. -* Get rid of custom function return values - -Most functions use a custom set of return values, we should force proper Linux -error numbers. Special care is needed for VCHIQ_RETRY. - * Reformat core code with more sane indentations The code follows the 80 characters limitation yet tends to go 3 or 4 levels of