Message ID | 20221214125821.12489-8-paul@crapouillou.net |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp203394wrn; Wed, 14 Dec 2022 05:03:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf743NpFrHS6AV6ISiyGWYY6dn9DzOxCkCBY6qUv/R9mYNGzJkPGjvMqbBpCSPfnAy/RMqgj X-Received: by 2002:a05:6a20:d696:b0:9d:efbe:2052 with SMTP id it22-20020a056a20d69600b0009defbe2052mr35204485pzb.8.1671022983260; Wed, 14 Dec 2022 05:03:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671022983; cv=none; d=google.com; s=arc-20160816; b=opmpl2OI/nKOxpUQGg+qYgOjaRfqMtqukcyOp5CKgemv4PODYDZY+78n7Ri2wo6kfi tVl6P+HJoQYDRucAHhztb0phoRIacHhhhNGLZjR+RydtdFnV7ND/N/WqoLcP5vpC2zyo sQG12ok5FakbTWTpb8C3bL+JHVlK9a0eCZs7VNDGDnfDzxLe1txH/HQT5921CXsElGz5 eD9IYBY27ASklXUuqcydOixxBW1QebP8Fw8oGPTsXjGEkYvHPt6TCfDSr6SwN4OpE1L2 HFfm5xNJHfhoV3bjAo5CtC9ua7lpip1xlIqQTc0/1wN309et0yXw+1/noiGpg7d1m3eF c1Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=K/tzTFKNZMMV1rVb1b3n0tYGGd7bT77iWuW0eM5CPb0=; b=K2bDXzh9a1Mb5kFc/yWyP4rDMQb/oRw9j2psgVKO64gUHxvFZYBKriuf1KUicpJKTK WU5qOMiyJ42srUgKz5LA12AhXDsd39MZxhKH0xX9eyaKpoQAPXbWtWQGwNf+wTMArrYy eZtvKns6xgpS7+NAZzIPRzI8OA1/4MINAr8LUvZv26dpdj9gdQERRImgodMgQ5+CU56N cKhWParNcXpi0V7dCMru//N2ta6Xq1FnWjgcLik2yDVfblP1fApbZdQ77dA+DUSUw0Ot bfZfZtoyRgyLrplXvbus65+NJFYj5DsUebA2GhDcQlTPwguQSWIFI1HHoeOl4df5ENY5 9uYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=CCR3Jzkc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v8-20020a63bf08000000b004776061dac9si15384164pgf.138.2022.12.14.05.02.46; Wed, 14 Dec 2022 05:03:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=CCR3Jzkc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237528AbiLNM7a (ORCPT <rfc822;jeantsuru.cumc.mandola@gmail.com> + 99 others); Wed, 14 Dec 2022 07:59:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238416AbiLNM71 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 14 Dec 2022 07:59:27 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B557960F1; Wed, 14 Dec 2022 04:59:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1671022719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K/tzTFKNZMMV1rVb1b3n0tYGGd7bT77iWuW0eM5CPb0=; b=CCR3JzkcrQ+B4tyoWwJL3L2TVfweylPk+HzdU2AjikcAi/uYXMI4ARgOFTeN/x+/dWqY9k izDSAMZnqNqvIKvlNoV5fEhv2aaKZqS7j4Xm79sZel9uJcrZjgvHi9U4O1jCEnOUs8DcGA JSqpM1oCWcQyajDG1YG+2XJMmAHRi+M= From: Paul Cercueil <paul@crapouillou.net> To: Phong LE <ple@baylibre.com>, Neil Armstrong <neil.armstrong@linaro.org>, Andrzej Hajda <andrzej.hajda@intel.com>, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: list@opendingux.net, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil <paul@crapouillou.net> Subject: [PATCH 07/10] drm: bridge: it66121: Don't clear DDC FIFO twice Date: Wed, 14 Dec 2022 13:58:18 +0100 Message-Id: <20221214125821.12489-8-paul@crapouillou.net> In-Reply-To: <20221214125821.12489-1-paul@crapouillou.net> References: <20221214125821.12489-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752194596133811419?= X-GMAIL-MSGID: =?utf-8?q?1752194596133811419?= |
Series |
drm: bridge: it66121: IT6610 support and cleanups
|
|
Commit Message
Paul Cercueil
Dec. 14, 2022, 12:58 p.m. UTC
The DDC FIFO was cleared before the loop in it66121_get_edid_block(),
and at the beginning of each iteration; which means that it did not have
to be cleared before the loop.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
drivers/gpu/drm/bridge/ite-it66121.c | 16 ----------------
1 file changed, 16 deletions(-)
Comments
On Wed, 14 Dec 2022 at 13:59, Paul Cercueil <paul@crapouillou.net> wrote: > > The DDC FIFO was cleared before the loop in it66121_get_edid_block(), > and at the beginning of each iteration; which means that it did not have > to be cleared before the loop. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > drivers/gpu/drm/bridge/ite-it66121.c | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c > index 06fa59ae5ffc..5335d4abd7c5 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c > @@ -456,18 +456,6 @@ static inline int it66121_wait_ddc_ready(struct it66121_ctx *ctx) > return 0; > } > > -static int it66121_clear_ddc_fifo(struct it66121_ctx *ctx) > -{ > - int ret; > - > - ret = it66121_preamble_ddc(ctx); > - if (ret) > - return ret; > - > - return regmap_write(ctx->regmap, IT66121_DDC_COMMAND_REG, > - IT66121_DDC_COMMAND_FIFO_CLR); > -} > - > static int it66121_abort_ddc_ops(struct it66121_ctx *ctx) > { > int ret; > @@ -515,10 +503,6 @@ static int it66121_get_edid_block(void *context, u8 *buf, > offset = (block % 2) * len; > block = block / 2; > > - ret = it66121_clear_ddc_fifo(ctx); > - if (ret) > - return ret; > - > while (remain > 0) { > cnt = (remain > IT66121_EDID_FIFO_SIZE) ? > IT66121_EDID_FIFO_SIZE : remain; > -- > 2.35.1 > Reviewed-by: Robert Foss <robert.foss@linaro.org>
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c index 06fa59ae5ffc..5335d4abd7c5 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -456,18 +456,6 @@ static inline int it66121_wait_ddc_ready(struct it66121_ctx *ctx) return 0; } -static int it66121_clear_ddc_fifo(struct it66121_ctx *ctx) -{ - int ret; - - ret = it66121_preamble_ddc(ctx); - if (ret) - return ret; - - return regmap_write(ctx->regmap, IT66121_DDC_COMMAND_REG, - IT66121_DDC_COMMAND_FIFO_CLR); -} - static int it66121_abort_ddc_ops(struct it66121_ctx *ctx) { int ret; @@ -515,10 +503,6 @@ static int it66121_get_edid_block(void *context, u8 *buf, offset = (block % 2) * len; block = block / 2; - ret = it66121_clear_ddc_fifo(ctx); - if (ret) - return ret; - while (remain > 0) { cnt = (remain > IT66121_EDID_FIFO_SIZE) ? IT66121_EDID_FIFO_SIZE : remain;