From patchwork Wed Dec 14 11:49:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 33171 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp171997wrn; Wed, 14 Dec 2022 04:03:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf7sH71nEX1ec29DB7xN8YTCuh0ZgEsomFFWz4XpJHjJNUvHlJfXKeen9KRy99kCoxe8pe3g X-Received: by 2002:a17:906:a459:b0:7c0:fb3d:11a6 with SMTP id cb25-20020a170906a45900b007c0fb3d11a6mr16758728ejb.38.1671019381708; Wed, 14 Dec 2022 04:03:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671019381; cv=none; d=google.com; s=arc-20160816; b=bRqikedWE+le/6XdKF0JJNUYqr1pkKwFqLoH7gBt/M8bzk2kpLdmIold9Hc7J45fuc JPHRemyBDu2X2vMc31dNpph4tC7oYNsUWCvEnBRh6d58dREXEGtu3BmogLemE2EhFU5o 5a0kXWP5sO9wgOemarZwK3WZL82RIkWRy8U9Jxp01aCsAnc7TAO7syuXUEDMssvhXvzG R6KdjdPqfgSbLTRML/SsizNtgpj7DYSk1D8fatHps1rLvDxZn11wENuBQaEEeMwCBpPS E7SSv9AugVOJ+7ae9H/fE/jvk8Pg31mdn05/tqKmFGZ55TngQwlPAxHWpQcE1yUTnlao 2QGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3gWYy1qqswueDgKPCmTxLhEu+RrUZCl2o2ST6pJ4IT4=; b=t+qIoOHkM173uSlL5+6bh+vK9KRmtqDIYPbM+pOmTBNJcN0gzQtxLajSMVtraG2cVL Cw4+DsAgA4t45e9AJ+vgavlRlu70m1rMGZVNLELPUPBIkoVprjwiuQkw1ryyFeJ+LMDf HPwuGbosJGqeIMXq9WwEGFOSFfbEU+eQPVQqv0jozduIblbVAm9ZjUcaxyFBaK0PtGhR RqFo1R3ubCTkFlEQikKGfTmyEzDx4bv1JZd2/cpwvwjFy93MSyc6CDnjnTKGlUuu4IAf sZNEo9ZfCyBSTFTZLFmi1X5dcMgPGrOKSt3Rx054NmsPUNL8cGS0pssdoXB0Bz1aGfaV cUlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bmpIVk2h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n4-20020aa7db44000000b0046a91c850a0si2602195edt.78.2022.12.14.04.02.16; Wed, 14 Dec 2022 04:03:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bmpIVk2h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238044AbiLNLt0 (ORCPT + 99 others); Wed, 14 Dec 2022 06:49:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238006AbiLNLtW (ORCPT ); Wed, 14 Dec 2022 06:49:22 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC9D63AF; Wed, 14 Dec 2022 03:49:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671018561; x=1702554561; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=r188qz47hPmbr6r5XbBcOdNISw/RCExFeHfQbTTAWVA=; b=bmpIVk2hvGOz9ftiG/2sp3uVh3GtvtHNR1aQv7JB1Dtub5ukUtvuDkKo X8/oHGH14orY9Y8cdCvLn1MfpPdgXBsmFJJ4vsNbeuqqr+WFA7CMaaxkg urHHtPyWDEPf7u3pgnl2drSXrUW/mVLyfbKSJPE5A+nbPAKIVnHrF+J7b apTquz1juGExfOMIIO5LnF0aOqg58wwacFqmUATnMOKuvNudjOR5ViKtO JisVr9CwJutOHXUA/JYwo4q+1QkZg73ISTBco+Uv1zAvk/jOExJ34J4VW XPdQaYTm61Uxy0MkyMHGDhpJQn54/tg5u+3jLZe1pEGKJbAG/c7ajRg8R Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="316017144" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="316017144" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 03:49:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="977805631" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="977805631" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 14 Dec 2022 03:49:19 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 5189BF4; Wed, 14 Dec 2022 13:49:48 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , Lars-Peter Clausen Subject: [PATCH v1 2/2] iio: adc: ti-adc128s052: Drop anti-pattern of ACPI_PTR() use Date: Wed, 14 Dec 2022 13:49:44 +0200 Message-Id: <20221214114944.83790-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221214114944.83790-1-andriy.shevchenko@linux.intel.com> References: <20221214114944.83790-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752190818952865455?= X-GMAIL-MSGID: =?utf-8?q?1752190818952865455?= ACPI_PTR() is more harmful than helpful. For example, in this case if CONFIG_ACPI=n, the ID table left unused and code is obfuscated by ifdeffery. Drop anti-pattern of ACPI_PTR() use. Signed-off-by: Andy Shevchenko --- drivers/iio/adc/ti-adc128s052.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c index 9dfc625100b6..fc09ee6bb174 100644 --- a/drivers/iio/adc/ti-adc128s052.c +++ b/drivers/iio/adc/ti-adc128s052.c @@ -9,7 +9,6 @@ * https://www.ti.com/lit/ds/symlink/adc124s021.pdf */ -#include #include #include #include @@ -201,19 +200,17 @@ static const struct spi_device_id adc128_id[] = { }; MODULE_DEVICE_TABLE(spi, adc128_id); -#ifdef CONFIG_ACPI static const struct acpi_device_id adc128_acpi_match[] = { { "AANT1280", (kernel_ulong_t)&adc128_config[2] }, { } }; MODULE_DEVICE_TABLE(acpi, adc128_acpi_match); -#endif static struct spi_driver adc128_driver = { .driver = { .name = "adc128s052", .of_match_table = adc128_of_match, - .acpi_match_table = ACPI_PTR(adc128_acpi_match), + .acpi_match_table = adc128_acpi_match, }, .probe = adc128_probe, .id_table = adc128_id,