From patchwork Wed Dec 14 08:14:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Puma Hsu X-Patchwork-Id: 33102 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp78929wrn; Wed, 14 Dec 2022 00:18:38 -0800 (PST) X-Google-Smtp-Source: AA0mqf5rPvRey5y5pRztvzOfKiXw9GhUi1Sc+X0yGvUMgTBbbd3GODZb2GvT468x0qOWcCHCtIvm X-Received: by 2002:a05:6a20:160d:b0:a4:f2e7:479e with SMTP id l13-20020a056a20160d00b000a4f2e7479emr36512091pzj.7.1671005917703; Wed, 14 Dec 2022 00:18:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671005917; cv=none; d=google.com; s=arc-20160816; b=FymmNqSWks7NFzh1qFVIGsMFpTNzWKRI3wzRn7F7V7k3Vgmyp5e8orxA9YGs9ka3sp EI5rKHDOGhJ+PmiCO5fUh9vBtiTaOtl0PV2L7EPq96RMmGi51cYnDfCS9rIed+Af7rAX 7y3hrqFQzjjCMA4UzDbxo2vxskc6YBupNa4rDWyrBQJn5oGhDyed0oH50GzhcAMMPiUB NLqnTGbWP34Mw1AEOyA4v8dD99yFMurAWZ9wqgeU5drtyqrs0+vNhh1ZLqmZTRXnL5IW hS8xu/01fhtvs9LIMgvpOqPk8bZfhLNs2sqQB0NvZREXWic5J4wGOTPUyKyteweZJlHb aO3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:dkim-signature; bh=xwk10ScpIHN3TWeoCLrvB+vfcB+zS8T8ixzqnuDxGoQ=; b=syfAei77URmilNvtNXVrmmAkXryDsgj4dz5vWsyo8ae2MI2B/luig0z4muNio+PD+M sUxbeLy5iUo6aGlATw+Luuh7MrKOZpcaxZJUQ4T/ha3OgPHjldWbGnHAckB9pU8hdXRC +IMU1uMLcZO568JHx4QuL+eZKTY2ZOtxIB4xjYPV8F07eZbp0LWxA0bvWRc98//ss9/6 0BHUxbFhsGlQVFnrZ24mlAaPujYwzwmKkCa2XXI/DoaP2S0R5vwGs0o+U5gR6RRMBmlD 8Z5LnxvoYSp29cjWHDQxRyRZKJnZklFj9x75Q6TMjb7xrtBlGilWuE+oRuDW5f1AJqTD SNsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=dkcTJ5yY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bn13-20020a056a02030d00b0042b4defce13si15949736pgb.344.2022.12.14.00.18.24; Wed, 14 Dec 2022 00:18:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=dkcTJ5yY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237631AbiLNIQW (ORCPT + 99 others); Wed, 14 Dec 2022 03:16:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237590AbiLNIPl (ORCPT ); Wed, 14 Dec 2022 03:15:41 -0500 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2D7D631E for ; Wed, 14 Dec 2022 00:15:39 -0800 (PST) Received: by mail-pj1-x104a.google.com with SMTP id 94-20020a17090a09e700b002191897f70aso3567012pjo.9 for ; Wed, 14 Dec 2022 00:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xwk10ScpIHN3TWeoCLrvB+vfcB+zS8T8ixzqnuDxGoQ=; b=dkcTJ5yY0DPuZjIwNfNUh0clfXYOIg6v+BRa60N2SdhsarYnRZ3ACBNpqFPdZ+JIgf rhVss6RLEXghltsYgubXVsy4QQ1bOvcYFIfD6VmQC9Ke9WQDEl+JvzE7lSGUdDc3nEHu mlrwozBeVIQvflG/LgXvDlGqU0d2b2S9lb4xQl509RKjmZr4jN25PFQOr/RWcqBpx+w0 1uUeUFI2tGYYHDZyJk/mKw8nu3mUltU+nT9izejge1P9xmWwp2otB+B04CQTwUg1VBuP ma7PFx2xBI43X1LprzqckTNUkinyU/ljwglaIKC9n7D9pi6qX0SLo+4ilSCue3Uk5BEW REkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xwk10ScpIHN3TWeoCLrvB+vfcB+zS8T8ixzqnuDxGoQ=; b=O7ZFynIcIywvHIMTAZEF3HCRgdYi/DO4AhRavyf/Ph1jS8Z1mE/e/VGSM2ury5wX+u Aj2VcV2z1M6GeZ240NpGO/BELC2ynVokdsimwqvQCSgz7keAVztf2kjXhvaRX0IBhjDM dsvWBNol6zXWPv9BOkzkoTBn6zoHNUoT01JboLVH2OJyCl4wbngIT8pdz4JBv7hp7rvV NY5B7+88H4jjzAqbV9BelTkGFsIP0F2c9C/I/dL2HZmNx5pqYGVARuFbH5rxoLVidNeW ewYZ/J2b8d5RF8BhnWgOwLgHQJlhfNt/XSilN2Bm0RgfcueWaxK1BkJ0Q7vxftFSWt+h Xi+Q== X-Gm-Message-State: ANoB5pl6Ob/+VS2yK2Hp9Xu48Bxj3jEu4jZeoN/OrfgONq9l/DHVqVlC qMJtmGMLSFeKN5ye6nc8F20cVSIwkG98 X-Received: from pumahsu.ntc.corp.google.com ([2401:fa00:fc:202:cb1:cbe3:3a49:1751]) (user=pumahsu job=sendgmr) by 2002:a17:902:e80c:b0:189:f899:bc23 with SMTP id u12-20020a170902e80c00b00189f899bc23mr7111469plg.33.1671005739282; Wed, 14 Dec 2022 00:15:39 -0800 (PST) Date: Wed, 14 Dec 2022 16:14:56 +0800 In-Reply-To: <20221214081456.714859-1-pumahsu@google.com> Message-Id: <20221214081456.714859-3-pumahsu@google.com> Mime-Version: 1.0 References: <20221214081456.714859-1-pumahsu@google.com> X-Mailer: git-send-email 2.39.0.rc1.256.g54fd8350bd-goog Subject: [PATCH v2 2/2] usb: core: add implementations for usb suspend/resume hooks From: Puma Hsu To: gregkh@linuxfoundation.org, mka@chromium.org, dianders@chromium.org Cc: albertccwang@google.com, raychi@google.com, howardyen@google.com, leejj@google.com, hch@infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Puma Hsu X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752176700991697779?= X-GMAIL-MSGID: =?utf-8?q?1752176700991697779?= In mobile, a co-processor can be used for USB audio. When the co-processor is working for USB audio, the co-processor is the user/owner of the USB driver, and the ACPU is able to sleep in such condition to improve power consumption. In order to support this, we implement the hooks to handle USB suspend/resume requests. This commit introduces two hook implementations: - usb_device_vendor_suspend() Determine whether we should skip suspend request according to the status of USB audio playback/capture. Return: - true: let driver.c know that we "handled" and it can just return succeeded to ACPU to continue system suspend process. - false: let driver.c know that it still run original suspend process. - usb_device_vendor_resume() Determine whether we should skip resume request according to the USB device's suspend state. Return: - true: let driver.c know that it doesn't need to run resume process. - false: let driver.c know that it still run original resume process. Signed-off-by: Puma Hsu --- drivers/usb/core/usb-hooks-impl-goog.c | 72 ++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 drivers/usb/core/usb-hooks-impl-goog.c diff --git a/drivers/usb/core/usb-hooks-impl-goog.c b/drivers/usb/core/usb-hooks-impl-goog.c new file mode 100644 index 000000000000..89dc360babed --- /dev/null +++ b/drivers/usb/core/usb-hooks-impl-goog.c @@ -0,0 +1,72 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2022 Google Corp. + * + * Author: + * Puma Hsu + */ + +#include +#include "usb.h" + +extern int usb_dev_register_vendor_ops(struct usb_device_vendor_ops *vendor_ops); + +static bool usb_device_vendor_suspend(struct usb_device *udev, pm_message_t msg) +{ + bool usb_playback = false; + bool usb_capture = false; + bool handled = false; + + if (!udev) + return handled; + + /* + * Note: Our private driver provides APIs to know the device is in audio playback + * or capture. + * + * usb_playback = usb_audio_playback_enabled(); + * usb_capture = usb_audio_capture_enabled(); + */ + + /* + * Note: When the USB audio is working, we will not let the usb device suspend. + * Return handled = true so that the System core can it's suspend process. + */ + if (usb_playback || usb_capture) { + dev_info(&udev->dev, "%s: skip suspend process (playback:%d,capture:%d)\n", + __func__, usb_playback, usb_capture); + handled = true; + } + + return handled; +} + +static bool usb_device_vendor_resume(struct usb_device *udev, pm_message_t msg) +{ + bool handled = false; + + if (!udev) + return handled; + + /* + * Note: If the udev didn't suspend actually, we don't need to do resume. + */ + if (udev->port_is_suspended || udev->state == USB_STATE_SUSPENDED) { + handled = false; + } else { + dev_info(&udev->dev, "%s: skip resume process\n", __func__); + handled = true; + } + + return handled; +} + +static struct usb_device_vendor_ops usb_dev_vendor_ops = { + .usb_dev_suspend = usb_device_vendor_suspend, + .usb_dev_resume = usb_device_vendor_resume, +}; + +int usb_vendor_helper_init(void) +{ + return usb_dev_register_vendor_ops(&usb_dev_vendor_ops); +}