Message ID | 20221213183305.544644-6-konrad.dybcio@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp294780wrn; Tue, 13 Dec 2022 10:36:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf4EUXy30GuQDJzUK15oGe15bLVqEbs5RH86KAOiOkQAhd0nyp7WBmr/9xwdJoweSUyOXgk7 X-Received: by 2002:a17:906:2297:b0:7c1:6344:840 with SMTP id p23-20020a170906229700b007c163440840mr10529790eja.24.1670956582416; Tue, 13 Dec 2022 10:36:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670956582; cv=none; d=google.com; s=arc-20160816; b=BwHUlwl4JdrgFwoy+ed6eqMCrzdN20HmwauRePPN97ZSnBWlJIw+sZIAJaR45FoiYy qRnGmaAUPuyqtzRoP4KBeELsdFFPlYkcIoijmJaaBoTPim6o70M+uKteVjhvBlS6GfiJ uJN+9CQZKcJNjGZmoqX1LDt94kvrwP3KarHqUABLXAhTUxcEUlYCq52ZJJY+9m4UHBOq gS0IMLopa++KQYx4NLv5z0SK42ZKpkZpO3Wj2j7cVuw0vYUT13BV/c+O5/sjkweuZDs5 NIB99rVXfI8IlDKXqPSL/VpQOXQvTSZZZHxsZBZIhAE0pxUTUqvoBzrQi+2/ifErLe2d RUkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2l+AXlkbxgNmUyTRU1MNT9VBG4C9+qJhmYSE2pQfryc=; b=vruey0PBR0EfEXbB3Kcm5tkl9GvyiWur/lFiZqyaf3wB6l3sfYAYWJQUynMzsCQ+2o Jb6LSeQcDzPKdN646w8s7U8t6VGP0pbGgWGK+TZCgfuCScLe3waQAwMetkO8R1HbDVuj i/o2UEjvmkbOx0sU6sdZNh3sAJpeIHTFq/n3VFK91PUWfPmSvBAnZl77goN1kXqd4xOz SQICjSyeP4WuywRAgWhiAgobJsg2FGfIhnRoqs/VRjwnS5pLJqiuPlq90exJ3/EtKpdz uGQCXApoj4lpchOm4d64E71bvmSYRUjdAmoZifojdBQOxTwdxkmsBsEUcrASsrgIpK3F pz5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hZ0Z3HPq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc17-20020a170907169100b007c0b71dfd96si10602128ejc.734.2022.12.13.10.35.58; Tue, 13 Dec 2022 10:36:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hZ0Z3HPq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236605AbiLMSdt (ORCPT <rfc822;jeantsuru.cumc.mandola@gmail.com> + 99 others); Tue, 13 Dec 2022 13:33:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236599AbiLMSdW (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 13 Dec 2022 13:33:22 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1799524BF8 for <linux-kernel@vger.kernel.org>; Tue, 13 Dec 2022 10:33:21 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id c1so6362512lfi.7 for <linux-kernel@vger.kernel.org>; Tue, 13 Dec 2022 10:33:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2l+AXlkbxgNmUyTRU1MNT9VBG4C9+qJhmYSE2pQfryc=; b=hZ0Z3HPqBRuQXe40KiDGCdasRHkvJ3/XZq+fUiQQWEppZ4EA7ps4V4ntf8Ytz4FDCm oGyW/CgF6rFdfWXTV/guUB9rALgZV+xRbUq5nXB7yhf/eMRN+wahpt3W56eAT4OSAYm5 6rvqdsJqMJcsEenfhp1oF3Mupvym33h9g6mjS1OUAFXRh+eCoWjQPSdcuD5URiSxgc96 UVgUhSELZmMuzUB24nsUs+2jxxAv6jtkvkux7TZND+Y0rx22MxNHt1YwwwVx0oUvC21b ZMiiNlCRs39mdH20rIvF/nUU+Rot6vgbTBYHt6LP6r3wSpPzotsKXtQcaC8f6hcEiCZM BbDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2l+AXlkbxgNmUyTRU1MNT9VBG4C9+qJhmYSE2pQfryc=; b=JocHIyRIayFQYrQ6prMtiwpNtG6yR4fqpwt5z7RGxQdqo+kKtl51f1sq/f1d4dB9pe DTnwE3f+6S78Tp3XjBsLU+wdqlLCzKzDKrCWgBShJTD6ORsLm1uson3KJvQMCQIOVs7x vTWsCn53W6rMwl8xVoVKPLOa/PVKjekCSxtcSUwLqItmujgpJOy59eMZdRc8/h1uW+57 Pih7bPcTPLnbJpzhncs3kX2iv0BR9pUUReiIQyUGy7r/JoXi55uuXNNq+GpzHXF6kdw+ 4Tq8CDci13ViGSHWGrIfEzE+ktB1LbHvif/rztjUzaM4KfvIYBnE71rk/aXFcav10cxj ZKbA== X-Gm-Message-State: ANoB5pk0Td2FJw0JJIVZfHZyNEYgwkAySfwclvLlLnd6FE1pPwtI2Gw2 FBPmYgjV6WRll6oJIAFKv6de1g== X-Received: by 2002:a05:6512:3495:b0:4b5:5616:ecd2 with SMTP id v21-20020a056512349500b004b55616ecd2mr5324020lfr.55.1670956400592; Tue, 13 Dec 2022 10:33:20 -0800 (PST) Received: from localhost.localdomain (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id t10-20020a056512208a00b004b501497b6fsm465963lfr.148.2022.12.13.10.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Dec 2022 10:33:19 -0800 (PST) From: Konrad Dybcio <konrad.dybcio@linaro.org> To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org, krzysztof.kozlowski@linaro.org Cc: marijn.suijten@somainline.org, Konrad Dybcio <konrad.dybcio@linaro.org>, Loic Poulain <loic.poulain@linaro.org>, Robert Foss <robert.foss@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/6] i2c: qcom-cci: Deprecate duplicated compatibles Date: Tue, 13 Dec 2022 19:33:05 +0100 Message-Id: <20221213183305.544644-6-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221213183305.544644-1-konrad.dybcio@linaro.org> References: <20221213183305.544644-1-konrad.dybcio@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752124969421959509?= X-GMAIL-MSGID: =?utf-8?q?1752124969421959509?= |
Series |
[v2,1/6] dt-bindings: i2c: qcom,i2c-cci: Fall back to common compatibles
|
|
Commit Message
Konrad Dybcio
Dec. 13, 2022, 6:33 p.m. UTC
Many compatibles have been introduced, pointing to the same config data.
Leave a note reminding future developers to not do that again.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Changes in v2:
- new patch
drivers/i2c/busses/i2c-qcom-cci.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
Comments
On 13/12/2022 19:33, Konrad Dybcio wrote: > Many compatibles have been introduced, pointing to the same config data. > Leave a note reminding future developers to not do that again. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > Changes in v2: > - new patch > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Dec 13, 2022 at 07:33:05PM +0100, Konrad Dybcio wrote: > Many compatibles have been introduced, pointing to the same config data. > Leave a note reminding future developers to not do that again. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c index a4b97fe3c3a5..01358472680c 100644 --- a/drivers/i2c/busses/i2c-qcom-cci.c +++ b/drivers/i2c/busses/i2c-qcom-cci.c @@ -811,9 +811,15 @@ static const struct cci_data cci_v2_data = { static const struct of_device_id cci_dt_match[] = { { .compatible = "qcom,msm8226-cci", .data = &cci_v1_data}, - { .compatible = "qcom,msm8916-cci", .data = &cci_v1_data}, { .compatible = "qcom,msm8974-cci", .data = &cci_v1_5_data}, { .compatible = "qcom,msm8996-cci", .data = &cci_v2_data}, + + + /* + * Legacy compatibles kept for backwards compatibility. + * Do not add any new ones unless they introduce a new config + */ + { .compatible = "qcom,msm8916-cci", .data = &cci_v1_data}, { .compatible = "qcom,sdm845-cci", .data = &cci_v2_data}, { .compatible = "qcom,sm8250-cci", .data = &cci_v2_data}, { .compatible = "qcom,sm8450-cci", .data = &cci_v2_data},