From patchwork Tue Dec 13 15:54:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 32870 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp211873wrn; Tue, 13 Dec 2022 08:10:02 -0800 (PST) X-Google-Smtp-Source: AA0mqf53yzcErHWpu9dxCLFkhFN/wzpNajGCTgHErYQlL487qssZD+5So3LJa/ROZp2YTYheMH0E X-Received: by 2002:a05:6402:12c9:b0:46c:55ef:8d50 with SMTP id k9-20020a05640212c900b0046c55ef8d50mr18034397edx.24.1670947802212; Tue, 13 Dec 2022 08:10:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670947802; cv=none; d=google.com; s=arc-20160816; b=zGpb6LlgDt+gGZJT28ktB768MkzGNpS4ELKYmsAzfZuhis4+RNFPNTz3aVCnzEpRfw 3EV1ZSIBo44OeBcMBgAiGqVGaUxLLHCf8hfAxLjfcG53jMhLHzr0lxf8Gk89s+H7KKcW EFWbDvH7ZU1d4D7exOspPC1vbm7mHlIck2uDifmenFWpSc4UYpiqcqzFk7gdEa8P8beV Qx+ufkyCi1D3h35KPk1f162fpkFv+Gs3QIppSdSfYEZAhFIQj3YgCADGxg3wMNQLOzj4 pW7vKosb2nDwws+oQ2BmVQOBDlMUsEVvuOfn+VRZcheM7JxljZF+Ah1tT71mpT/RRivS bU7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=H9bD4vEGhPnw3EnUsCGAUmQGYOk16+ZEqAiPgLivwFI=; b=M3VeP7RxTNf1NwsXgBCVBfuHv8vucdbQqG2sroen3llmodkZUIfo4YYegyCHVfq6gA h+0si2J1j8E3L1r7uvUYCI4fmMPT0yWCakfSTyhtWJwwrfae2RosvJjr4O0zkFQAsnQ5 S2sKIrZGW1nfJD/NeuP23oeJfRhJieHBfR1rADgJ1JpWC5xsxrCiNR1Hp++x8KIpZ3Ik 2u04N69WJzlKBu/ixL9OyHsX+YfrO4ZMkIbPhM7VJhoNAglnpy6cYO3l/zrNGYdCykZj pKNdY1ZEtJVT59nn6ofbU8c4XxpL+zjwU6vBhQPvsiEgHBnakrlggcOId+AwlwEkAxNS gFMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=H2Y6St4c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t21-20020a05640203d500b0046ccf2c79b7si9317575edw.618.2022.12.13.08.09.38; Tue, 13 Dec 2022 08:10:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=H2Y6St4c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236204AbiLMPzD (ORCPT + 99 others); Tue, 13 Dec 2022 10:55:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235622AbiLMPzB (ORCPT ); Tue, 13 Dec 2022 10:55:01 -0500 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0618563B7; Tue, 13 Dec 2022 07:54:59 -0800 (PST) Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BDC6Dkq026377; Tue, 13 Dec 2022 09:54:51 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=H9bD4vEGhPnw3EnUsCGAUmQGYOk16+ZEqAiPgLivwFI=; b=H2Y6St4cDt4F+GA/ZneeEQrS6FWzrum+Dss3jegqVV2UvHIKrFiiWncspHMZt7rttqM+ DTd4RPbUyPr5nTaRPWhDo8IfMNkEWDq/HdrUr8JyJA8xfPm0+yMWiK46pY8gzOTaQfx5 1hY9YIsXwZrtIKPOQp7/KJ+lt8lRfmeLnFDUyDrQ6jB61Q8+T5m0cFJ18emnj+bg+WZr ltPl5yVja+ZZWOgFmawjD5E3+iMgcUku+IJl/Xt0/0K7d6kOmYF4IZK1w7AqMxopHFPF DdlNaxjGWgxGHjf/VOVH/5brU++wFNKD9bZXUThFiOOE9y19xz3qNf/6E3tqOGv0QM/L ww== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3mcrd63f2x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Dec 2022 09:54:51 -0600 Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.20; Tue, 13 Dec 2022 09:54:48 -0600 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.20 via Frontend Transport; Tue, 13 Dec 2022 09:54:48 -0600 Received: from edi-sw-dsktp-006.ad.cirrus.com (edi-sw-dsktp-006.ad.cirrus.com [198.90.251.111]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id DA528B10; Tue, 13 Dec 2022 15:54:48 +0000 (UTC) From: Richard Fitzgerald To: , , CC: , , , Richard Fitzgerald Subject: [PATCH] PM: runtime: Document that force_suspend() is incompatible with SMART_SUSPEND Date: Tue, 13 Dec 2022 15:54:48 +0000 Message-ID: <20221213155448.385167-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-GUID: M77udDUM_cpgyAKQhTe-BiCX7ukNhgJ1 X-Proofpoint-ORIG-GUID: M77udDUM_cpgyAKQhTe-BiCX7ukNhgJ1 X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752115762589985753?= X-GMAIL-MSGID: =?utf-8?q?1752115762589985753?= pm_runtime_force_suspend() cannot be used with DPM_FLAG_SMART_SUSPEND, so note this in the kerneldoc. If DPM_FLAG_SMART_SUSPEND is set and the PM core cannot skip system resume it will call pm_runtime_active() on the driver. This can lead to an inconsistent state where: pm_runtime_force_suspend() called ->runtime_suspend but device_resume_noirq() called pm_runtime_set_active() This leaves the driver actually suspended but marked as active. Signed-off-by: Richard Fitzgerald --- drivers/base/power/runtime.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index 50e726b6c2cf..b29be7d4d7d0 100644 --- a/drivers/base/power/runtime.c +++ b/drivers/base/power/runtime.c @@ -1864,6 +1864,10 @@ static bool pm_runtime_need_not_resume(struct device *dev) * sure the device is put into low power state and it should only be used during * system-wide PM transitions to sleep states. It assumes that the analogous * pm_runtime_force_resume() will be used to resume the device. + * + * Do not use with DPM_FLAG_SMART_SUSPEND as this can lead to an inconsistent + * state where this function has called the ->runtime_suspend callback but the + * PM core marks the driver as runtime active. */ int pm_runtime_force_suspend(struct device *dev) {