diff mbox series

[v2,1/4] ASoC: dt-bindings: microchip: use proper naming syntax

Message ID 20221212164153.78677-2-claudiu.beznea@microchip.com
State New
Headers
Series ASoC: microchip: power saving features and cleanups |

Commit Message

Claudiu Beznea Dec. 12, 2022, 4:41 p.m. UTC 
  Use the following syntax for Microchip ASoC YAML files:
vendor,device.yaml

Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 .../bindings/sound/mchp,i2s-mcc.yaml          | 108 ------------------
 ...,pdmc.yaml => microchip,sama7g5-pdmc.yaml} |   0
 ...rx.yaml => microchip,sama7g5-spdifrx.yaml} |   0
 ...tx.yaml => microchip,sama7g5-spdiftx.yaml} |   0
 4 files changed, 108 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/mchp,i2s-mcc.yaml
 rename Documentation/devicetree/bindings/sound/{microchip,pdmc.yaml => microchip,sama7g5-pdmc.yaml} (100%)
 rename Documentation/devicetree/bindings/sound/{mchp,spdifrx.yaml => microchip,sama7g5-spdifrx.yaml} (100%)
 rename Documentation/devicetree/bindings/sound/{mchp,spdiftx.yaml => microchip,sama7g5-spdiftx.yaml} (100%)

Comments

Rob Herring Dec. 12, 2022, 5:32 p.m. UTC | #1 
On Mon, Dec 12, 2022 at 06:41:50PM +0200, Claudiu Beznea wrote:
> Use the following syntax for Microchip ASoC YAML files:
> vendor,device.yaml
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
>  .../bindings/sound/mchp,i2s-mcc.yaml          | 108 ------------------

Deleting? Why? That's not what the commit message says.

>  ...,pdmc.yaml => microchip,sama7g5-pdmc.yaml} |   0
>  ...rx.yaml => microchip,sama7g5-spdifrx.yaml} |   0
>  ...tx.yaml => microchip,sama7g5-spdiftx.yaml} |   0
>  4 files changed, 108 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/mchp,i2s-mcc.yaml
>  rename Documentation/devicetree/bindings/sound/{microchip,pdmc.yaml => microchip,sama7g5-pdmc.yaml} (100%)
>  rename Documentation/devicetree/bindings/sound/{mchp,spdifrx.yaml => microchip,sama7g5-spdifrx.yaml} (100%)
>  rename Documentation/devicetree/bindings/sound/{mchp,spdiftx.yaml => microchip,sama7g5-spdiftx.yaml} (100%)

These will all fail binding checks. You need to update the $id values.

Rob
Claudiu Beznea Dec. 13, 2022, 8:23 a.m. UTC | #2 
On 12.12.2022 19:32, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, Dec 12, 2022 at 06:41:50PM +0200, Claudiu Beznea wrote:
>> Use the following syntax for Microchip ASoC YAML files:
>> vendor,device.yaml
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>>  .../bindings/sound/mchp,i2s-mcc.yaml          | 108 ------------------
> 
> Deleting? Why? That's not what the commit message says.

Ah, I messed it up in v2... Will send v3.

> 
>>  ...,pdmc.yaml => microchip,sama7g5-pdmc.yaml} |   0
>>  ...rx.yaml => microchip,sama7g5-spdifrx.yaml} |   0
>>  ...tx.yaml => microchip,sama7g5-spdiftx.yaml} |   0
>>  4 files changed, 108 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/sound/mchp,i2s-mcc.yaml
>>  rename Documentation/devicetree/bindings/sound/{microchip,pdmc.yaml => microchip,sama7g5-pdmc.yaml} (100%)
>>  rename Documentation/devicetree/bindings/sound/{mchp,spdifrx.yaml => microchip,sama7g5-spdifrx.yaml} (100%)
>>  rename Documentation/devicetree/bindings/sound/{mchp,spdiftx.yaml => microchip,sama7g5-spdiftx.yaml} (100%)
> 
> These will all fail binding checks. You need to update the $id values.
> 
> Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/mchp,i2s-mcc.yaml b/Documentation/devicetree/bindings/sound/mchp,i2s-mcc.yaml
deleted file mode 100644
index 0481315cb5f2..000000000000
--- a/Documentation/devicetree/bindings/sound/mchp,i2s-mcc.yaml
+++ /dev/null
@@ -1,108 +0,0 @@ 
-# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/sound/mchp,i2s-mcc.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Microchip I2S Multi-Channel Controller
-
-maintainers:
-  - Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
-
-description:
-  The I2SMCC complies with the Inter-IC Sound (I2S) bus specification and
-  supports a Time Division Multiplexed (TDM) interface with external
-  multi-channel audio codecs. It consists of a receiver, a transmitter and a
-  common clock generator that can be enabled separately to provide Adapter,
-  Client or Controller modes with receiver and/or transmitter active.
-  On later I2SMCC versions (starting with Microchip's SAMA7G5) I2S
-  multi-channel is supported by using multiple data pins, output and
-  input, without TDM.
-
-properties:
-  "#sound-dai-cells":
-    const: 0
-
-  compatible:
-    enum:
-      - microchip,sam9x60-i2smcc
-      - microchip,sama7g5-i2smcc
-
-  reg:
-    maxItems: 1
-
-  interrupts:
-    maxItems: 1
-
-  clocks:
-    items:
-      - description: Peripheral Bus Clock
-      - description: Generic Clock (Optional). Should be set mostly when Master
-          Mode is required.
-    minItems: 1
-
-  clock-names:
-    items:
-      - const: pclk
-      - const: gclk
-    minItems: 1
-
-  dmas:
-    items:
-      - description: TX DMA Channel
-      - description: RX DMA Channel
-
-  dma-names:
-    items:
-      - const: tx
-      - const: rx
-
-  microchip,tdm-data-pair:
-    description:
-      Represents the DIN/DOUT pair pins that are used to receive/send
-      TDM data. It is optional and it is only needed if the controller
-      uses the TDM mode.
-    $ref: /schemas/types.yaml#/definitions/uint8
-    enum: [0, 1, 2, 3]
-    default: 0
-
-if:
-  properties:
-    compatible:
-      const: microchip,sam9x60-i2smcc
-then:
-  properties:
-    microchip,tdm-data-pair: false
-
-required:
-  - "#sound-dai-cells"
-  - compatible
-  - reg
-  - interrupts
-  - clocks
-  - clock-names
-  - dmas
-  - dma-names
-
-additionalProperties: false
-
-examples:
-  - |
-    #include <dt-bindings/dma/at91.h>
-    #include <dt-bindings/interrupt-controller/arm-gic.h>
-
-    i2s@f001c000 {
-        #sound-dai-cells = <0>;
-        compatible = "microchip,sam9x60-i2smcc";
-        reg = <0xf001c000 0x100>;
-        interrupts = <34 IRQ_TYPE_LEVEL_HIGH 7>;
-        dmas = <&dma0 (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1) |
-                       AT91_XDMAC_DT_PERID(36))>,
-               <&dma0 (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1) |
-                       AT91_XDMAC_DT_PERID(37))>;
-        dma-names = "tx", "rx";
-        clocks = <&i2s_clk>, <&i2s_gclk>;
-        clock-names = "pclk", "gclk";
-        pinctrl-names = "default";
-        pinctrl-0 = <&pinctrl_i2s_default>;
-    };
diff --git a/Documentation/devicetree/bindings/sound/microchip,pdmc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
similarity index 100%
rename from Documentation/devicetree/bindings/sound/microchip,pdmc.yaml
rename to Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
diff --git a/Documentation/devicetree/bindings/sound/mchp,spdifrx.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-spdifrx.yaml
similarity index 100%
rename from Documentation/devicetree/bindings/sound/mchp,spdifrx.yaml
rename to Documentation/devicetree/bindings/sound/microchip,sama7g5-spdifrx.yaml
diff --git a/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-spdiftx.yaml
similarity index 100%
rename from Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
rename to Documentation/devicetree/bindings/sound/microchip,sama7g5-spdiftx.yaml