From patchwork Mon Dec 12 12:33:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 32361 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2216396wrr; Mon, 12 Dec 2022 04:36:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf4X429XLWXnXzUO2uto1bUaaeyNVmmu/CdttdMpH++mBQTyWt5ZF16mv7YJN0GYevyQ3Lay X-Received: by 2002:a17:906:c249:b0:7ae:eac:fe22 with SMTP id bl9-20020a170906c24900b007ae0eacfe22mr12934477ejb.76.1670848588467; Mon, 12 Dec 2022 04:36:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670848588; cv=none; d=google.com; s=arc-20160816; b=G0RYdEv8SAZxMqVBNcRVUZIrDN4I+m/pQwcqg7Ynjq6YckAGXU/8BKpilePjzutT4D eMmHiOIznyMuaft1dxVMkTo8ufFJ4D6a5TRRbfKi/6d8E9B0i90yENW+purdPoRNyrwa 3RnwwP/ShHnzCmqXEx01vGoR9yBJ+lW7LIQir4ku7cPB03Rg8wEhWkCgU2kRj8V7pi/y e+ap2a+smvMFzcNa2H+NcngB4ICBdY3L/3mXiFGsAh15VAM7xysQSrllzPJU8/OMqdw2 X7XihGUI0hS6+g3u3ek2B3S3HTAeoLtp3gpanA66FFEZeP0xnlEOWCP9cWSG0Swn2nN+ 0Xuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QfIwNI7T0psn5lDqNEX4WmRlkGqyl7ZmRdxDmkjkE3o=; b=fbcLI+efY2JlGDdvx+f3xPF1Xj59bXwWv93CuVPc/dxKeL2QQQv3GFIlw2R25Taw6R R23G7SgNMytNbsPND+u1mopsAfCxbh6YMrSOW2IkQDAVdZVakDcvqeo/7MqN7pfKFiaw Ju6gVKFyZ07jKGiTkAqs4fFADLVrJvd6oCJtG2mAylxykV5dhKEaqOP8JfwxL/0Ifg5I 0EGnKNql3mJLJSfqbFwki9v9UWjShKTJs0Zm+8xl+Uf07QZtHPRkHLwU83vD6teaU2uc T+ZStbtQFChxoC/Lhb7xoKgSRNiysYBNs/X6lpUTBXWbNgQ6i27K5Dp1ofv8HtgbR/cQ xRlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uUzlkjM9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a21-20020a1709066d5500b007b29ccd79c0si4532818ejt.590.2022.12.12.04.36.01; Mon, 12 Dec 2022 04:36:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uUzlkjM9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232214AbiLLMfZ (ORCPT + 99 others); Mon, 12 Dec 2022 07:35:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232238AbiLLMe7 (ORCPT ); Mon, 12 Dec 2022 07:34:59 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9EAF12ACE for ; Mon, 12 Dec 2022 04:34:20 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id z8-20020a17090abd8800b00219ed30ce47so15542799pjr.3 for ; Mon, 12 Dec 2022 04:34:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QfIwNI7T0psn5lDqNEX4WmRlkGqyl7ZmRdxDmkjkE3o=; b=uUzlkjM9xadP/wsfePCnqjzwimre9NyLsWAauCXIMA4K2H4sdT5xEbloK1SqvMpiI1 RbnWr8fQlEusmTFxO97E6HQ1SY+VLLpx6sUhuDJqsaXMoJP0o5up0rCoTYybXD16bjSA aShFXmtsF5KPZSAIn9B2I/d31rGvMztJVH6vtfl/b++okd4nu9Kk9FPoR8TXLQATuheJ r7UTt35dMuC18r94SFLCEwbfYUALLkwJ6XlpjFzImo2IStVCik4eblWALX0L9c+bkNeQ GGFJuMsb9mYhEuTkKtqKmMrm0wzFYLXUM8ja/vhaEuUngg7DDEcLEW3cLBDuCMUUESHN k2nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QfIwNI7T0psn5lDqNEX4WmRlkGqyl7ZmRdxDmkjkE3o=; b=O4HVN9nKsBb7kYs5VR3MkexpeCbVnFEY5r7g1QZuoVpez/+bHbrn9981l7KoEW6Z0L 2FDabdggrdp30jMHjt8RL9G903PV15ceCHP+nb0NR9eY3KtTULaXaHPW3egI5vS018A6 n/cmdT4SNHBGC2eE77r2o33j4pR8RbTnkkCDC7Tx4wQ1qfTxjFKzhLb5IXBQ9J8UYHG7 9lQHKHySNnOGiWoH/ympZNh9hq1kNA5YW3J5jQTE9I6NY5xIXX3p1diGKg+KMTrQ2GdC gxdk1eJ0UYLI0uW/pU54SRMYLvzdVha1IbaKPjzYXLpHrWZ4vlBKAJBGKK/OSK80j/ow kDQw== X-Gm-Message-State: ANoB5plglkMp7A6EL+fk+7Gnv8Zer+ik0l2prIDWTfVurcc23SNLb5xl Mbyic+jhKpxBexdF+A+fB0ax X-Received: by 2002:a17:902:6bc8:b0:188:d2b3:26c1 with SMTP id m8-20020a1709026bc800b00188d2b326c1mr15270890plt.10.1670848437579; Mon, 12 Dec 2022 04:33:57 -0800 (PST) Received: from localhost.localdomain ([220.158.159.33]) by smtp.gmail.com with ESMTPSA id j14-20020a170902da8e00b00189c93ce5easm6252557plx.166.2022.12.12.04.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 04:33:56 -0800 (PST) From: Manivannan Sadhasivam To: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, bp@alien8.de, tony.luck@intel.com Cc: quic_saipraka@quicinc.com, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org, quic_ppareek@quicinc.com, luca.weiss@fairphone.com, Manivannan Sadhasivam , stable@vger.kernel.org Subject: [PATCH v2 06/13] arm64: dts: qcom: sc8280xp: Fix the base addresses of LLCC banks Date: Mon, 12 Dec 2022 18:03:04 +0530 Message-Id: <20221212123311.146261-7-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221212123311.146261-1-manivannan.sadhasivam@linaro.org> References: <20221212123311.146261-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752011729351190143?= X-GMAIL-MSGID: =?utf-8?q?1752011729351190143?= The LLCC block has several banks each with a different base address and holes in between. So it is not a correct approach to cover these banks with a single offset/size. Instead, the individual bank's base address needs to be specified in devicetree with the exact size. Also, let's get rid of reg-names property as it is not needed anymore. The driver is expected to parse the reg field based on index to get the addresses of each LLCC banks. Cc: # 6.0 Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") Reported-by: Parikshit Pareek Signed-off-by: Manivannan Sadhasivam Reviewed-by: Sai Prakash Ranjan --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 109c9d2b684d..f8731cbccce9 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1856,8 +1856,11 @@ opp-6 { system-cache-controller@9200000 { compatible = "qcom,sc8280xp-llcc"; - reg = <0 0x09200000 0 0x58000>, <0 0x09600000 0 0x58000>; - reg-names = "llcc_base", "llcc_broadcast_base"; + reg = <0 0x09200000 0 0x58000>, <0 0x09280000 0 0x58000>, + <0 0x09300000 0 0x58000>, <0 0x09380000 0 0x58000>, + <0 0x09400000 0 0x58000>, <0 0x09480000 0 0x58000>, + <0 0x09500000 0 0x58000>, <0 0x09580000 0 0x58000>, + <0 0x09600000 0 0x58000>; interrupts = ; };