iommu/arm-smmu-qcom: Add SM8150 DPU compatible

Message ID 20221212100617.18190-1-konrad.dybcio@linaro.org
State New
Headers
Series iommu/arm-smmu-qcom: Add SM8150 DPU compatible |

Commit Message

Konrad Dybcio Dec. 12, 2022, 10:06 a.m. UTC
  From: Marijn Suijten <marijn.suijten@somainline.org>

Add the SM8150 DPU compatible to clients compatible list, as it also
needs the workarounds.

Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Depends on the binding here:

[1] https://lore.kernel.org/linux-arm-msm/20221212093315.11390-1-konrad.dybcio@linaro.org/T/#t

 drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Dmitry Baryshkov Dec. 12, 2022, 10:58 a.m. UTC | #1
On 12 December 2022 13:06:16 GMT+03:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>From: Marijn Suijten <marijn.suijten@somainline.org>
>
>Add the SM8150 DPU compatible to clients compatible list, as it also
>needs the workarounds.

Please rebase on top of linux-next, this part was rewritten.


>
>Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
>Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>---
>Depends on the binding here:
>
>[1] https://lore.kernel.org/linux-arm-msm/20221212093315.11390-1-konrad.dybcio@linaro.org/T/#t
>
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>index 6610f5d2877d..cd74c1efcfde 100644
>--- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>+++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>@@ -255,6 +255,7 @@ static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = {
> 	{ .compatible = "qcom,sdm845-mss-pil" },
> 	{ .compatible = "qcom,sm6350-mdss" },
> 	{ .compatible = "qcom,sm6375-mdss" },
>+	{ .compatible = "qcom,sm8150-mdss" },
> 	{ .compatible = "qcom,sm8250-mdss" },
> 	{ }
> };
  
Konrad Dybcio Dec. 12, 2022, 11 a.m. UTC | #2
On 12.12.2022 11:58, Dmitry Baryshkov wrote:
> 
> 
> On 12 December 2022 13:06:16 GMT+03:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>> From: Marijn Suijten <marijn.suijten@somainline.org>
>>
>> Add the SM8150 DPU compatible to clients compatible list, as it also
>> needs the workarounds.
> 
> Please rebase on top of linux-next, this part was rewritten.
This one wasn't, but yeah it is based on some local changes
(see 6350/6375)..

Konrad
> 
> 
>>
>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> Depends on the binding here:
>>
>> [1] https://lore.kernel.org/linux-arm-msm/20221212093315.11390-1-konrad.dybcio@linaro.org/T/#t
>>
>> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>> index 6610f5d2877d..cd74c1efcfde 100644
>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>> @@ -255,6 +255,7 @@ static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = {
>> 	{ .compatible = "qcom,sdm845-mss-pil" },
>> 	{ .compatible = "qcom,sm6350-mdss" },
>> 	{ .compatible = "qcom,sm6375-mdss" },
>> +	{ .compatible = "qcom,sm8150-mdss" },
>> 	{ .compatible = "qcom,sm8250-mdss" },
>> 	{ }
>> };
>
  
Dmitry Baryshkov Dec. 12, 2022, 11:20 a.m. UTC | #3
On 12 December 2022 14:00:10 GMT+03:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>On 12.12.2022 11:58, Dmitry Baryshkov wrote:
>> 
>> 
>> On 12 December 2022 13:06:16 GMT+03:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>> From: Marijn Suijten <marijn.suijten@somainline.org>
>>>
>>> Add the SM8150 DPU compatible to clients compatible list, as it also
>>> needs the workarounds.
>> 
>> Please rebase on top of linux-next, this part was rewritten.
>This one wasn't, but yeah it is based on some local changes
>(see 6350/6375)..

It was,

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c?h=next-20221208#n498

>
>Konrad
>> 
>> 
>>>
>>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>> Depends on the binding here:
>>>
>>> [1] https://lore.kernel.org/linux-arm-msm/20221212093315.11390-1-konrad.dybcio@linaro.org/T/#t
>>>
>>> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> index 6610f5d2877d..cd74c1efcfde 100644
>>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> @@ -255,6 +255,7 @@ static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = {
>>> 	{ .compatible = "qcom,sdm845-mss-pil" },
>>> 	{ .compatible = "qcom,sm6350-mdss" },
>>> 	{ .compatible = "qcom,sm6375-mdss" },
>>> +	{ .compatible = "qcom,sm8150-mdss" },
>>> 	{ .compatible = "qcom,sm8250-mdss" },
>>> 	{ }
>>> };
>>
  
Konrad Dybcio Dec. 12, 2022, 11:21 a.m. UTC | #4
On 12.12.2022 12:20, Dmitry Baryshkov wrote:
> 
> 
> On 12 December 2022 14:00:10 GMT+03:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>> On 12.12.2022 11:58, Dmitry Baryshkov wrote:
>>>
>>>
>>> On 12 December 2022 13:06:16 GMT+03:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>>> From: Marijn Suijten <marijn.suijten@somainline.org>
>>>>
>>>> Add the SM8150 DPU compatible to clients compatible list, as it also
>>>> needs the workarounds.
>>>
>>> Please rebase on top of linux-next, this part was rewritten.
>> This one wasn't, but yeah it is based on some local changes
>> (see 6350/6375)..
> 
> It was,
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c?h=next-20221208#n498
We're not looking at the same thing, this patch adds a compatible
for 8150's mdss so that it can be matched as a client, not a
compatible for the SMMU itself (which itself has been merged
dinosaur years ago).

Konrad
> 
>>
>> Konrad
>>>
>>>
>>>>
>>>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>> ---
>>>> Depends on the binding here:
>>>>
>>>> [1] https://lore.kernel.org/linux-arm-msm/20221212093315.11390-1-konrad.dybcio@linaro.org/T/#t
>>>>
>>>> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>>> index 6610f5d2877d..cd74c1efcfde 100644
>>>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>>> @@ -255,6 +255,7 @@ static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = {
>>>> 	{ .compatible = "qcom,sdm845-mss-pil" },
>>>> 	{ .compatible = "qcom,sm6350-mdss" },
>>>> 	{ .compatible = "qcom,sm6375-mdss" },
>>>> +	{ .compatible = "qcom,sm8150-mdss" },
>>>> 	{ .compatible = "qcom,sm8250-mdss" },
>>>> 	{ }
>>>> };
>>>
>
  
Dmitry Baryshkov Dec. 12, 2022, 11:27 a.m. UTC | #5
On 12 December 2022 14:00:10 GMT+03:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>On 12.12.2022 11:58, Dmitry Baryshkov wrote:
>> 
>> 
>> On 12 December 2022 13:06:16 GMT+03:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>> From: Marijn Suijten <marijn.suijten@somainline.org>
>>>
>>> Add the SM8150 DPU compatible to clients compatible list, as it also
>>> needs the workarounds.
>> 
>> Please rebase on top of linux-next, this part was rewritten.
>This one wasn't, but yeah it is based on some local changes
>(see 6350/6375)..

Stupid me, you are right here. This part wasn't changed. Please ignore the comment.

>
>Konrad
>> 
>> 
>>>
>>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>> Depends on the binding here:
>>>
>>> [1] https://lore.kernel.org/linux-arm-msm/20221212093315.11390-1-konrad.dybcio@linaro.org/T/#t
>>>
>>> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> index 6610f5d2877d..cd74c1efcfde 100644
>>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>> @@ -255,6 +255,7 @@ static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = {
>>> 	{ .compatible = "qcom,sdm845-mss-pil" },
>>> 	{ .compatible = "qcom,sm6350-mdss" },
>>> 	{ .compatible = "qcom,sm6375-mdss" },
>>> +	{ .compatible = "qcom,sm8150-mdss" },
>>> 	{ .compatible = "qcom,sm8250-mdss" },
>>> 	{ }
>>> };
>>
  
Konrad Dybcio Dec. 12, 2022, 11:33 a.m. UTC | #6
On 12.12.2022 12:27, Dmitry Baryshkov wrote:
> 
> 
> On 12 December 2022 14:00:10 GMT+03:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>>
>> On 12.12.2022 11:58, Dmitry Baryshkov wrote:
>>>
>>>
>>> On 12 December 2022 13:06:16 GMT+03:00, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>>> From: Marijn Suijten <marijn.suijten@somainline.org>
>>>>
>>>> Add the SM8150 DPU compatible to clients compatible list, as it also
>>>> needs the workarounds.
>>>
>>> Please rebase on top of linux-next, this part was rewritten.
>> This one wasn't, but yeah it is based on some local changes
>> (see 6350/6375)..
> 
> Stupid me, you are right here. This part wasn't changed. Please ignore the comment.
As I mentioned, it was accidentally right, as this doesn't apply
on plain next ^^

Konrad
> 
>>
>> Konrad
>>>
>>>
>>>>
>>>> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>> ---
>>>> Depends on the binding here:
>>>>
>>>> [1] https://lore.kernel.org/linux-arm-msm/20221212093315.11390-1-konrad.dybcio@linaro.org/T/#t
>>>>
>>>> drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>>> index 6610f5d2877d..cd74c1efcfde 100644
>>>> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>>> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
>>>> @@ -255,6 +255,7 @@ static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = {
>>>> 	{ .compatible = "qcom,sdm845-mss-pil" },
>>>> 	{ .compatible = "qcom,sm6350-mdss" },
>>>> 	{ .compatible = "qcom,sm6375-mdss" },
>>>> +	{ .compatible = "qcom,sm8150-mdss" },
>>>> 	{ .compatible = "qcom,sm8250-mdss" },
>>>> 	{ }
>>>> };
>>>
>
  

Patch

diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
index 6610f5d2877d..cd74c1efcfde 100644
--- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
+++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
@@ -255,6 +255,7 @@  static const struct of_device_id qcom_smmu_client_of_match[] __maybe_unused = {
 	{ .compatible = "qcom,sdm845-mss-pil" },
 	{ .compatible = "qcom,sm6350-mdss" },
 	{ .compatible = "qcom,sm6375-mdss" },
+	{ .compatible = "qcom,sm8150-mdss" },
 	{ .compatible = "qcom,sm8250-mdss" },
 	{ }
 };