From patchwork Sun Dec 11 09:49:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 32163 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1696560wrr; Sun, 11 Dec 2022 01:55:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf7rEuretBn04VhpC8miL26D5HAXMUnAKNnSB0CCot/3PcpN2V66VDIPSqFT4riV5dYAle1Z X-Received: by 2002:a05:6402:444b:b0:463:ba73:9139 with SMTP id o11-20020a056402444b00b00463ba739139mr10345387edb.2.1670752550804; Sun, 11 Dec 2022 01:55:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670752550; cv=none; d=google.com; s=arc-20160816; b=lNEDpejGZa2UvXOTOVElncG29KeWYVTw3tWlTP6dzJR5BRgldOch9ngvhB7kCnM0Zx WHOyujat8XLCcY+SEkNqxsfjSLOdQAGqfP1+Fw98QVelf54a+po18fOI30Cl/VcWTKYE UfNGew03qFQPqXHuDb1dLDRzDHT7GOS2qUEv5nFxb70vCFxYSoKbV5AnozjpX5/ScXVl rLl6mfBQyrunH4Hzx05P6ykKWEc0O7C8YqJ1BPJB4/NZL9Mai97kgo4fVkw3GdsTmYYB U4N2XEwR9+bWvPAkbBPWB8O6mPIWHyXBzYbCT5lTt+3eecHrwXO3IXirjudhlvC3sd+i tL4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MzxFl2kXwY0vF0u6XgCHpFReYJM1QcQXtVDhmHf0ayE=; b=t5TUsGuX4GYkWK1Gl/+4hJ2E0tk2q4dO870xKJFiLUKONaFV9C+REvZLbLEp2VQWh4 GCR1H+crNUaJWM7sdzd6o7t4wTqsPZB2UGCWLHSxfXkBdlFmehOGc1ggFo/IgFM7+VqO nPVySMQRMSZpLOQEW+x/06fp1ooMjVk36MPQH4XOWwDyUNV+lI5V7+HjahVs1hHd/8eT kLXi+6cXa3zb6O+OpchMtdNADcTBctwGhR9OF9eKZX/qng8iUG/FBKJ8PZCvgQAvrnBn qlYp8YMYqLZAcdmjKulcLKQYE3cTCnTzW3AQ2TLb/4DI93ZEaNM5jFT+ewwQp6fXPvmL 2K1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tlxoHj+2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j24-20020aa7ca58000000b0046b67e245dasi4896673edt.121.2022.12.11.01.55.27; Sun, 11 Dec 2022 01:55:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tlxoHj+2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbiLKJtc (ORCPT + 99 others); Sun, 11 Dec 2022 04:49:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229891AbiLKJt1 (ORCPT ); Sun, 11 Dec 2022 04:49:27 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0EC210FD9; Sun, 11 Dec 2022 01:49:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C67EB80915; Sun, 11 Dec 2022 09:49:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E12EEC433D2; Sun, 11 Dec 2022 09:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670752164; bh=3GMvyRizM+Rxblh7pHwRbabkGYlPbTfIEjgrgW67JR4=; h=From:To:Cc:Subject:Date:From; b=tlxoHj+2xtDqNBEqNRf8IF0m7ZkxeDb7Yu/5Zs2b510WNs6EaenMSHFv8svwpUU5B 4Szgb6+Pn4UHMwRmr7ubmnUIBEv4uYeQ8JJYbaGefew1qSvkDh47ZNmtsSXggqdn/u eCyF/uBLHxOg7dzhOU3xVqi2BueWZnmNouEVg2ZOc6fZgWrv8GBEjQ1o0ddD+KbQ01 64iNEJyr7vFkM1H+sx7frCHzYT8sT0yV6mfjB3GoU07Sr60r01SqwiMi0QFZlzT740 Q3meivDTL3+SdQjZbsYoZk16VhkXTSeDSXf0ntWWP5F7bEfQ8QUdNqX6yRwsKDEhod S3wV1AOBedpzg== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier Subject: [PATCH] kbuild: do not sort after reading modules.order Date: Sun, 11 Dec 2022 18:49:18 +0900 Message-Id: <20221211094919.2717594-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751911026791833528?= X-GMAIL-MSGID: =?utf-8?q?1751911026791833528?= modules.order lists modules in the deterministic order (that is why "modules order"), and there is no duplication in the list. $(sort ) is pointless. Signed-off-by: Masahiro Yamada Reviewed-by: Nicolas Schier --- scripts/Makefile.modfinal | 2 +- scripts/Makefile.modinst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.modfinal b/scripts/Makefile.modfinal index 25bedd83644b..4705d32388f3 100644 --- a/scripts/Makefile.modfinal +++ b/scripts/Makefile.modfinal @@ -13,7 +13,7 @@ include $(srctree)/scripts/Kbuild.include include $(srctree)/scripts/Makefile.lib # find all modules listed in modules.order -modules := $(sort $(shell cat $(MODORDER))) +modules := $(shell cat $(MODORDER)) __modfinal: $(modules) @: diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index a4c987c23750..f4cff42069ad 100644 --- a/scripts/Makefile.modinst +++ b/scripts/Makefile.modinst @@ -9,7 +9,7 @@ __modinst: include include/config/auto.conf include $(srctree)/scripts/Kbuild.include -modules := $(sort $(shell cat $(MODORDER))) +modules := $(shell cat $(MODORDER)) ifeq ($(KBUILD_EXTMOD),) dst := $(MODLIB)/kernel