[v2,05/24] m68k: Remove COMMAND_LINE_SIZE from uapi

Message ID 20221211061358.28035-6-palmer@rivosinc.com
State New
Headers
Series Remove COMMAND_LINE_SIZE from uapi |

Commit Message

Palmer Dabbelt Dec. 11, 2022, 6:13 a.m. UTC
  As far as I can tell this is not used by userspace and thus should not
be part of the user-visible API.

Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
This leaves an empty <uapi/asm/setup.h>, which will soon be cleaned up.
---
 arch/m68k/include/asm/setup.h      | 3 +--
 arch/m68k/include/uapi/asm/setup.h | 2 --
 2 files changed, 1 insertion(+), 4 deletions(-)
  

Comments

Geert Uytterhoeven Jan. 16, 2023, 10:07 a.m. UTC | #1
CC linux-m68k

On Sun, Dec 11, 2022 at 7:19 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> As far as I can tell this is not used by userspace and thus should not
> be part of the user-visible API.
>
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
> This leaves an empty <uapi/asm/setup.h>, which will soon be cleaned up.
> ---
>  arch/m68k/include/asm/setup.h      | 3 +--
>  arch/m68k/include/uapi/asm/setup.h | 2 --
>  2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/m68k/include/asm/setup.h b/arch/m68k/include/asm/setup.h
> index 2c99477aaf89..9a256cc3931d 100644
> --- a/arch/m68k/include/asm/setup.h
> +++ b/arch/m68k/include/asm/setup.h
> @@ -23,9 +23,8 @@
>  #define _M68K_SETUP_H
>
>  #include <uapi/asm/bootinfo.h>
> -#include <uapi/asm/setup.h>
> -
>
> +#define COMMAND_LINE_SIZE 256
>  #define CL_SIZE COMMAND_LINE_SIZE
>
>  #ifndef __ASSEMBLY__
> diff --git a/arch/m68k/include/uapi/asm/setup.h b/arch/m68k/include/uapi/asm/setup.h
> index 25fe26d5597c..005593acc7d8 100644
> --- a/arch/m68k/include/uapi/asm/setup.h
> +++ b/arch/m68k/include/uapi/asm/setup.h
> @@ -12,6 +12,4 @@
>  #ifndef _UAPI_M68K_SETUP_H
>  #define _UAPI_M68K_SETUP_H
>
> -#define COMMAND_LINE_SIZE 256
> -
>  #endif /* _UAPI_M68K_SETUP_H */
> --
> 2.38.1
>
  

Patch

diff --git a/arch/m68k/include/asm/setup.h b/arch/m68k/include/asm/setup.h
index 2c99477aaf89..9a256cc3931d 100644
--- a/arch/m68k/include/asm/setup.h
+++ b/arch/m68k/include/asm/setup.h
@@ -23,9 +23,8 @@ 
 #define _M68K_SETUP_H
 
 #include <uapi/asm/bootinfo.h>
-#include <uapi/asm/setup.h>
-
 
+#define COMMAND_LINE_SIZE 256
 #define CL_SIZE COMMAND_LINE_SIZE
 
 #ifndef __ASSEMBLY__
diff --git a/arch/m68k/include/uapi/asm/setup.h b/arch/m68k/include/uapi/asm/setup.h
index 25fe26d5597c..005593acc7d8 100644
--- a/arch/m68k/include/uapi/asm/setup.h
+++ b/arch/m68k/include/uapi/asm/setup.h
@@ -12,6 +12,4 @@ 
 #ifndef _UAPI_M68K_SETUP_H
 #define _UAPI_M68K_SETUP_H
 
-#define COMMAND_LINE_SIZE 256
-
 #endif /* _UAPI_M68K_SETUP_H */