From patchwork Sat Dec 10 22:06:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 32099 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1511674wrr; Sat, 10 Dec 2022 14:07:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf4E0yH2YcZOksk9qBzP87tGNOAqvMBKFiX8yn0cVqGPWccD6Gumeoejo07eWwbZNjl5+cxi X-Received: by 2002:a05:6a21:8cc9:b0:a4:255b:f3b8 with SMTP id ta9-20020a056a218cc900b000a4255bf3b8mr12110708pzb.45.1670710067771; Sat, 10 Dec 2022 14:07:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670710067; cv=none; d=google.com; s=arc-20160816; b=o2Ywl5h/uy+Ip+Mp342vZpJOfjKlH4KaKNJx6MqXLBEoK8XXzy2C2Nrp/HR6KOuVMB fWDk4Y3wJx/ac/7akSPWKt0SIh/iyLpS5hAtsu+5NhBYUn/9FF5NJlmMSad/OmzomyXG +py8lcU1x3xdiWoIxh5c4CnGT2YEM5Fu++tV07V2KfEPkkyQq8rkVat3NOkDUM51cpNj /g0byG5LD/vaSmmPwpaoqkaXgUvzM202ikNmpbhfjlcw3H9baDfbSnRr6FTKSN8LQAmw oFJ1x6g4RHBoukJaMa/4HkKWCW4CMOaYepR8Mgz+rkXE+7dt427HgiMYRa59HKvn8xrS dVJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Y8wj1BQeN8krBByKIv+6VkkjfodcgulIwxvYwq+goMM=; b=bmJJB7AP1KZ7yoJI6V68bgy3vl+ZdLf5iIIVW483jjc8GMbt7F3aVdSr5VBRikqBvy Lx2JN8Le8FvhJGPypZEILbiQWJ1SJG53GjLgDjt4uDMoienxfSlmAyZl9X937E9l47dX mk+EASqEvZdBJlZsnlz+ZeF+yXKAn54wmtq3CH5N0eJsSskQ9HS+J51PaKbnL6Nrzl+3 Hb6m8lZF/6vo/7PkfS2XxZZtKDbrqtuWUCAhQM3hZO1O8UsLeB1Y+n1vJkuzhHVw2scj vMBCipJDWQ8cdhurvWXxkXOPno9++vKlrYi1aG54aZPAtTP4iiDRQIv3KWYK/UKwdanD BiZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MGAAQ4Rq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d70-20020a633649000000b00478814eaea9si5305006pga.654.2022.12.10.14.07.34; Sat, 10 Dec 2022 14:07:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MGAAQ4Rq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229879AbiLJWF5 (ORCPT + 99 others); Sat, 10 Dec 2022 17:05:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229843AbiLJWFj (ORCPT ); Sat, 10 Dec 2022 17:05:39 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A644111C3B; Sat, 10 Dec 2022 14:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670709938; x=1702245938; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MnNwcdMxEciJeVyGc4ORlNy3VU7ZtA7su0OonJmjLgM=; b=MGAAQ4RqqMkoNzrU6bj0+pmfGzB6amo9IJaRA3kIpibd6naKqy6WV1jQ rQZovSo8d5nCVTtZ2IOGwNOWWOLqfXw8gA7LeQBj4ZTFwjwIU0dENa+AV XOlxUFykZK41Ow5OAxvgVf17pu9jyRhp/lqp+P/CtaCIwawbxNsHRbscS S4aLq84iC3oneIpghS0vDW80/8A30o6tLWLa4XJPHfXk8q4Qnsu3eCjJU iG/tFCqjN9QC6I3QfkGB+iOdgREvt5GUXvDQqv9UwAq4ew6gZoiYdSxPA muvztjwocE+xOSsu6O/RXv+bMa9JN3OL/qqfHxHMMxng9wk8aunpRuu8c g==; X-IronPort-AV: E=McAfee;i="6500,9779,10557"; a="298001324" X-IronPort-AV: E=Sophos;i="5.96,235,1665471600"; d="scan'208";a="298001324" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2022 14:05:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10557"; a="754448425" X-IronPort-AV: E=Sophos;i="5.96,235,1665471600"; d="scan'208";a="754448425" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 10 Dec 2022 14:05:36 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 64A8A6E2; Sun, 11 Dec 2022 00:06:05 +0200 (EET) From: Andy Shevchenko To: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko Subject: [PATCH v2 4/4] gpio: pca953x: Remove unused PCAL953X_OUT_CONF from pcal6534_recalc_addr() Date: Sun, 11 Dec 2022 00:06:01 +0200 Message-Id: <20221210220601.77648-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221210220601.77648-1-andriy.shevchenko@linux.intel.com> References: <20221210220601.77648-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751866480114890109?= X-GMAIL-MSGID: =?utf-8?q?1751866480114890109?= First of all, PCAL953X_OUT_CONF is not used in the driver. Second, it's not a per-bank register, it's a single for the chip and should be handled differently anyway. To avoid confusion, drop PCAL953X_OUT_CONF from pcal6534_recalc_addr(). Signed-off-by: Andy Shevchenko --- v2: new patch drivers/gpio/gpio-pca953x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 8aba8df393bd..1286b22ef23a 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -461,7 +461,6 @@ static u8 pcal6534_recalc_addr(struct pca953x_chip *chip, int reg, int off) case PCAL953X_PULL_SEL: case PCAL953X_INT_MASK: case PCAL953X_INT_STAT: - case PCAL953X_OUT_CONF: pinctrl = ((reg & PCAL_PINCTRL_MASK) >> 1) + 0x20; break; case PCAL6524_INT_EDGE: