From patchwork Sat Dec 10 22:05:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 32100 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1511752wrr; Sat, 10 Dec 2022 14:08:02 -0800 (PST) X-Google-Smtp-Source: AA0mqf7wzGcKkCobR/DNJiBICEzE0UUeIExR23aMONkdMPF5bgUzuIVUDe9rdjavRtGcHl3Cfs2x X-Received: by 2002:a17:902:ef45:b0:187:2bff:da48 with SMTP id e5-20020a170902ef4500b001872bffda48mr11090881plx.58.1670710082531; Sat, 10 Dec 2022 14:08:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670710082; cv=none; d=google.com; s=arc-20160816; b=Cxq2Qg20EksIRi0l6mttgg1xAfDJ7BoaOuvtZ4YeHvSL2d/yOyk3rWqcDPJQes0SIt xQu7XoGId6wX47IWRMxPXt/FpOJ9HInnTcPery7CvigzfyRRMPHPM/Crbt0cZCUtMAJT UdTPs6Kx0usRwgs/lRI9q16Ag0QN94L6TxdEW6QCCF9M9i804FDimDrgaeu5gSy2Cssh +qs7I/gNWNwkzZiyivc3U3o7UyoUEsdn4va0gN2aWPXBmdgQHvCMfGzJ7LRUPh7vy5Pc fHe/FdzgBTjfPhZ7nXNfxa2s48qeZD4qD1Ih39xrNAXT8jIO6MIuKjOLoZ5L8GnNVVSO nw4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=0GuEZDxQtFUpPoVPuxgwDla/+8Cb/ENR5o9d6z+1eC4=; b=OmEI+9eFkxrG1FUA6SC1Ju8XSEUp9DlhP1qyf68HhyAjpPw6qw77tdtmZzqk62tdwJ 2oK0NT9Q/XzGTotG1Aszs0hFNpIZe6NThk0A+IFOZV9Ufna7rghDxGPGnWZsgheTRp5I dH8Usf1lZpGK4w0fcY5l1mzxhZBqIAaLx254if9iOXrHb5MqFBg6qpNSO2Kbows3RkKs KihQTq03q5Gpqr6QjiJ8NGk3zaZcOPsnV6z5UegdubjcSTyuhoCtNcAR0W2YoPFl40FS tokbt9Q68tZbfAHVkr5r/raPACi78jrJpi/Ntue+rEzQdbO79cQmA0SaxEL/tyZ9AqHk SZAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dPlu4Ovg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n11-20020a170902d2cb00b00175449cf6f8si5615595plc.606.2022.12.10.14.07.49; Sat, 10 Dec 2022 14:08:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dPlu4Ovg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229805AbiLJWGA (ORCPT + 99 others); Sat, 10 Dec 2022 17:06:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbiLJWFk (ORCPT ); Sat, 10 Dec 2022 17:05:40 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DC0213D24; Sat, 10 Dec 2022 14:05:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670709939; x=1702245939; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nkgtRUpy/gZUYkzHWEcPgSfI8fgT7IazaxmYic/RiEE=; b=dPlu4OvgESPDicL/HRR07nzbCj17SybpwfB9WMCv6HFoCbMfEf0bYgVK qWBGEvFenvQgaEtIfVyOdEfgLv9tTjA7/FASwgVhOfpOB1kmwPj+uuB5I JtWU86djkJsEHvnGL7T/zCtK4K+aTfF4omWTbjhZOgqVT7P4iMfxiOT6G QdffMFR1kGCrIyU9QqbVKZofoXfRdTaRX4/CVRXTByPLjoGqOxMZltV3k brm3yUeB3N8A0B8VZhrXNFFrHm88VQhp1Crrb1ewtr1eUkZDfWnjga73k S9IjkMpOD6mKKGdWUQ1VTzqnq7KSku0DYvIAp9LVEJiqxaoHlrsZlyQzN w==; X-IronPort-AV: E=McAfee;i="6500,9779,10557"; a="298001327" X-IronPort-AV: E=Sophos;i="5.96,235,1665471600"; d="scan'208";a="298001327" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2022 14:05:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10557"; a="754448424" X-IronPort-AV: E=Sophos;i="5.96,235,1665471600"; d="scan'208";a="754448424" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 10 Dec 2022 14:05:36 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 47584179; Sun, 11 Dec 2022 00:06:05 +0200 (EET) From: Andy Shevchenko To: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski , Haibo Chen , Andy Shevchenko Subject: [PATCH v2 1/4] gpio: pca953x: avoid to use uninitialized value pinctrl Date: Sun, 11 Dec 2022 00:05:58 +0200 Message-Id: <20221210220601.77648-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751866495053713178?= X-GMAIL-MSGID: =?utf-8?q?1751866495053713178?= From: Haibo Chen There is a variable pinctrl declared without initializer. And then has the case (switch operation chose the default case) to directly use this uninitialized value, this is not a safe behavior. So here initialize the pinctrl as 0 to avoid this issue. This is reported by Coverity. Fixes: 13c5d4ce8060 ("gpio: pca953x: Add support for PCAL6534") Signed-off-by: Haibo Chen Signed-off-by: Andy Shevchenko --- v2: used default case (Andy) drivers/gpio/gpio-pca953x.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index a59d61cd44b2..5299e5bb76d6 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -474,6 +474,9 @@ static u8 pcal6534_recalc_addr(struct pca953x_chip *chip, int reg, int off) case PCAL6524_DEBOUNCE: pinctrl = ((reg & PCAL_PINCTRL_MASK) >> 1) + 0x1c; break; + default: + pinctrl = 0; + break; } return pinctrl + addr + (off / BANK_SZ);