From patchwork Fri Dec 9 17:12:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 31884 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp895656wrr; Fri, 9 Dec 2022 09:16:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf4RmQV6UK9ZrZncsgq+V1qTS3yTDbaTDhbFkzfT32pSc6gQEcaWKa/i9Ez0AuD742wIGQLW X-Received: by 2002:a17:906:3c15:b0:7c1:4d21:abb7 with SMTP id h21-20020a1709063c1500b007c14d21abb7mr4968ejg.54.1670606207075; Fri, 09 Dec 2022 09:16:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670606207; cv=none; d=google.com; s=arc-20160816; b=1A4eWU/8aM82V9epAoLj7OFXvn7QKsKudIP/dVa1boCORTMjMRxr4vpZnEQVHQw+2b 74uT6/iAHzo5SjsXo6+nExCto69cC/C4BhLl4ucNZ0K/fWQq+sUx05JepUBj47CfJlmS JnzhFE4xrdlgWlLeNiu1IQRGlN1HxmPmiqyF5f1bF5dQpZy00SlWHsONk+BwwWvV+DpC 73je/q6mHL/5GTvgu3Cv31fKq0Hwgt7AmTSBLddGgIsUknejKwD3QxrhDbY5BOCZ/lqA OK/6r45IUsQeTLXy0kuXCxegCThy8OK2c2RNhOq8Gx+p6RkodwI3Thsctuuv5D0L3Zj2 aNNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=M88P4SMh5VCPJCyuLc/w2B8fWJUsM71IvdRT7VAjmHQ=; b=jcFzKz+AKp+qKBVmhS8yp4mO8BUFaBCrngOCT4GmotI6xDC3QMLjDdK1AF9UlVoUep crUZLoQpV7x/ZHPj2zVjTjN4XbWXYrwEq8FBZtUS4y8FZU7KNOkcGlLdxXwa7Acf8fkY FhfDo3Jc2aPHTNJ38htCMB4IWt3BI/BFRXoXvVuOqaS9HCuYtAPw8uTlwr+sFrOegWDu rnuqL83Q/havm6um1vVDR25gaaP+ayjrEsKgB2aYAxKJF55eX6KRw8ZdqJcbG1PFojiB x+IzudwfUZ5+5kgBpMnhkcrBMpmsi5ewURX1pUj/9YV0SS85bML9OM7AaoVPh0ZHeydC RkNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fGd3e82N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qw28-20020a1709066a1c00b007ae84881ebasi260868ejc.505.2022.12.09.09.16.23; Fri, 09 Dec 2022 09:16:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fGd3e82N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230019AbiLIRN2 (ORCPT + 99 others); Fri, 9 Dec 2022 12:13:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbiLIRNV (ORCPT ); Fri, 9 Dec 2022 12:13:21 -0500 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D2E9419B5 for ; Fri, 9 Dec 2022 09:13:14 -0800 (PST) Received: by mail-pl1-x629.google.com with SMTP id a9so5528994pld.7 for ; Fri, 09 Dec 2022 09:13:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M88P4SMh5VCPJCyuLc/w2B8fWJUsM71IvdRT7VAjmHQ=; b=fGd3e82N31A7l0GFrD4RELU4+SmeP8YESrYNFW7YbDq/1R5jPqb8HNf+yew8ZNCRFM C7/4ccIgu7oVj7ehikAIRQtjKtveYz2hYbWdeapMVOiPP2ZlFmwVaQBpTsw0kUPnRo+M A6RKaIjdiuS+DXbkVcxHNSKfFI/mfyREzSE9s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M88P4SMh5VCPJCyuLc/w2B8fWJUsM71IvdRT7VAjmHQ=; b=50Fe9Kh5Zk6YwCZSn3SbmTL9jU+38HWKkMJ9M8KoNiuZXWB+ZNgcNHysHj92e4Ra7k 0HJeu9LoNjm0oPuCj+QOqX1P3f6ADtich1YSl9UvFv8deDtFB3R4wNIerVhhpPpUfaMV AfwGfrDYYVPJvb+LZrfX1jMkqAbUByyUVqHW7xJTBGBk/ubHux0EMt+LEcT8WigrFZrA Ft4j9ykofBuQLeTemShyf3sFh0LyhEVQ2bThEhzPlnEkhc/joQIb7+2NJt0fM1Bs1Td4 SitE7h6oO4clQLhdwb5fb0fj3jVH4YP1nH14+ldHIqgiiT5y7wh9UztlEvk49q5u94zW lz3w== X-Gm-Message-State: ANoB5pmGG5eK2s1A/nsV534XbLhscNp50MBOAaFy4D5lEBFVdc1c+WR8 A+q0crcOP0KlK/+yetzcBQHXfg== X-Received: by 2002:a17:902:aa08:b0:189:fb78:a7d4 with SMTP id be8-20020a170902aa0800b00189fb78a7d4mr6267571plb.21.1670605994046; Fri, 09 Dec 2022 09:13:14 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:9a82:7898:7bf4:b4f]) by smtp.gmail.com with ESMTPSA id j16-20020a170902da9000b00189c62eac37sm1597503plx.32.2022.12.09.09.13.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Dec 2022 09:13:13 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson Cc: swboyd@chromium.org, Dmitry Torokhov , mka@chromium.org, Yunlong Jia , linux-arm-msm@vger.kernel.org, Konrad Dybcio , linux-input@vger.kernel.org, Douglas Anderson , Andy Gross , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/4] arm64: dts: qcom: sc7180: Bump up trogdor ts_reset_l drive strength Date: Fri, 9 Dec 2022 09:12:37 -0800 Message-Id: <20221209091234.v3.1.I39c387f1e3176fcf340039ec12d54047de9f8526@changeid> X-Mailer: git-send-email 2.39.0.rc1.256.g54fd8350bd-goog In-Reply-To: <20221209171240.1614904-1-dianders@chromium.org> References: <20221209171240.1614904-1-dianders@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751757574322165980?= X-GMAIL-MSGID: =?utf-8?q?1751757574322165980?= On at least one board (pazquel360) the reset line for the touchscreen was scoped and found to take almost 2 ms to fall when we drove it low. This wasn't great because the Linux driver for the touchscreen (the elants_i2c driver) thinks it can do a 500 us reset pulse. If we bump the drive strength to 8 mA then the reset line went down in ~421 us. NOTE: we could apply this fix just for pazquel360, but: * Probably other trogdor devices have similar timings and it's just that nobody has noticed it before. * There are other trogdor boards using the same elan driver that tries to do 500 us reset pulses. * Bumping the drive strength to 8mA across the board won't hurt. This isn't a high speed signal or anything. Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke Reviewed-by: Konrad Dybcio --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index f1defb94d670..ff1c7aa6a722 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -1376,7 +1376,15 @@ ts_reset_l: ts-reset-l-state { pins = "gpio8"; function = "gpio"; bias-disable; - drive-strength = <2>; + + /* + * The reset GPIO to the touchscreen takes almost 2ms to drop + * at the default drive strength. When we bump it up to 8mA it + * falls in under 500us. We want this to be fast since the Elan + * datasheet (and any drivers written based on it) talk about using + * a 500 us reset pulse. + */ + drive-strength = <8>; }; sdc1_on: sdc1-on-state {