From patchwork Fri Dec 9 02:06:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 31597 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp535642wrr; Thu, 8 Dec 2022 18:13:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf7ImQUfFQMSuRUCk5H3s/YivANYK7OFy9SHsPq65xwkPOzCiJs5ibnEsogw1HtrXlxRk204 X-Received: by 2002:a05:6402:43ce:b0:46c:a43d:5e23 with SMTP id p14-20020a05640243ce00b0046ca43d5e23mr4012682edc.28.1670552021308; Thu, 08 Dec 2022 18:13:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670552021; cv=none; d=google.com; s=arc-20160816; b=vNcr0Yyi/h9gIjLIPSW6zfWIqoh0ShpyaGJ5+SgTMMStygBntgWDgDOfWd4F/LQ4B8 EGs1D7bPeX01MFRfD+qJCxiEyD9d5+0kCnUtmaOOXftNz92DMgoyCShWsp3ax6nHyq+T uuADkVDbTcUBYF+QsiQ5eyL7BXUofG+D0Ny5KTEusfwr0vfIvNWwCnJEfjJO3mcT9cLw m3hH9/lhFvbM10MKHIhka5PXL907j6eBa5JyBjWorR+Bc3l4Cjt2bTARaUFlDIktCDh1 D8G7CIbSLc/yb3mDr77QwXh1PfuOww25fRoCNBeTJHw45TAcI8eBai7NNgN7s4CpyaYy ve0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=M88P4SMh5VCPJCyuLc/w2B8fWJUsM71IvdRT7VAjmHQ=; b=ryjcwnxyr7RlmzOWjnEppFa08usB1YGKasQ7k1dYX5D+opGNxtvs0N0MmC9twBoGMA 61Dk55SHV4cANTj2YSxtF8xTvQq3P7U4L/vt3w9xj5U5ULrYmOezdWsRSLVCb5/Fbb2z k1d6w1Fc4A3vdv+ZZM7ILR26wjKP80++oyEW5KKWtsyDXqoX9LjLoYsuzVTVFdm5D0qn z4P15cPwbXCac76TDUcaNfIQvuTuGIlFHlCAnUqVjOQE9sZ+QIVE0aZ1ewFKoc/zKHAh 0L54gRLtT8xiSA4S3E6HF8YeBGjOrRi88s+/U2ZOEp8QsBdevBe7dOHltBF1RIQAmfVq hkeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XIV9gS7a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u23-20020a056402065700b0046bef95b2e6si187596edx.492.2022.12.08.18.13.18; Thu, 08 Dec 2022 18:13:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XIV9gS7a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230123AbiLICGf (ORCPT + 99 others); Thu, 8 Dec 2022 21:06:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbiLICG3 (ORCPT ); Thu, 8 Dec 2022 21:06:29 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67C299230B for ; Thu, 8 Dec 2022 18:06:28 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id 3-20020a17090a098300b00219041dcbe9so3452439pjo.3 for ; Thu, 08 Dec 2022 18:06:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M88P4SMh5VCPJCyuLc/w2B8fWJUsM71IvdRT7VAjmHQ=; b=XIV9gS7alHxSUtR0tKaSg1ZlTvjuvanMhkxu9gP+QpjiM2dNoCFBdqxhXqHxm0gQxK fiG35WMYsI4gJmDpVdNgZQIe+pWpRzesNMP0PihtGP8T7c2YYBxNcXh1lAAHS87CMrD3 naYNadu9ysQ3fHsQ1mFE0avh4w5DRqRtW5ZYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M88P4SMh5VCPJCyuLc/w2B8fWJUsM71IvdRT7VAjmHQ=; b=rCidU4OgvhZB8oMaOyMxKM4WfVTXmZJAbdC4tuzOEQSz+rEkemPh2U9dtWbfPWu6tG tWi3lp9MAKg33YHzHPJfZB08/vjSmarWMr2MyeEyFqVHN9naS43rLVy9Ik3vaf5HKBYf ieVlKsW+qo6h16WC9crhklztW3JyWxfdCFHaiU9/98RDTQdwIGR16brOGUWuR9Bo8yEM HmLIN3iuq6waFhex0DvBb8nEKBgKnUeLqGYLAD+HrNFH6urXApJScVrpASBy+igE5gXF bFkEwzEq3x3DlPrU/fwqyU74tN8srtHJCsj0wg/T/abBvZlcqSXJ6LQACeq7TFreinh7 y/Pw== X-Gm-Message-State: ANoB5pl4VWmM2nG4Xt7TRydW69k/Fz5C/rvcHQxKkTPSpjUA61vCeoqd kDJZ49xnuZUaGGwSxFp7YmNlIw== X-Received: by 2002:a17:90a:f614:b0:218:87cf:1bed with SMTP id bw20-20020a17090af61400b0021887cf1bedmr4772786pjb.2.1670551587920; Thu, 08 Dec 2022 18:06:27 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:9a82:7898:7bf4:b4f]) by smtp.gmail.com with ESMTPSA id h3-20020a17090a648300b00218ddc8048bsm233473pjj.34.2022.12.08.18.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 18:06:27 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Dmitry Torokhov Cc: linux-arm-msm@vger.kernel.org, mka@chromium.org, Yunlong Jia , Konrad Dybcio , linux-input@vger.kernel.org, swboyd@chromium.org, Douglas Anderson , Andy Gross , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/5] arm64: dts: qcom: sc7180: Bump up trogdor ts_reset_l drive strength Date: Thu, 8 Dec 2022 18:06:08 -0800 Message-Id: <20221208180603.v2.1.I39c387f1e3176fcf340039ec12d54047de9f8526@changeid> X-Mailer: git-send-email 2.39.0.rc1.256.g54fd8350bd-goog In-Reply-To: <20221209020612.1303267-1-dianders@chromium.org> References: <20221209020612.1303267-1-dianders@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751700756096793506?= X-GMAIL-MSGID: =?utf-8?q?1751700756096793506?= On at least one board (pazquel360) the reset line for the touchscreen was scoped and found to take almost 2 ms to fall when we drove it low. This wasn't great because the Linux driver for the touchscreen (the elants_i2c driver) thinks it can do a 500 us reset pulse. If we bump the drive strength to 8 mA then the reset line went down in ~421 us. NOTE: we could apply this fix just for pazquel360, but: * Probably other trogdor devices have similar timings and it's just that nobody has noticed it before. * There are other trogdor boards using the same elan driver that tries to do 500 us reset pulses. * Bumping the drive strength to 8mA across the board won't hurt. This isn't a high speed signal or anything. Signed-off-by: Douglas Anderson Reviewed-by: Matthias Kaehlcke --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index f1defb94d670..ff1c7aa6a722 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -1376,7 +1376,15 @@ ts_reset_l: ts-reset-l-state { pins = "gpio8"; function = "gpio"; bias-disable; - drive-strength = <2>; + + /* + * The reset GPIO to the touchscreen takes almost 2ms to drop + * at the default drive strength. When we bump it up to 8mA it + * falls in under 500us. We want this to be fast since the Elan + * datasheet (and any drivers written based on it) talk about using + * a 500 us reset pulse. + */ + drive-strength = <8>; }; sdc1_on: sdc1-on-state {