From patchwork Thu Dec 8 15:13:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oded Gabbay X-Patchwork-Id: 31395 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp253593wrr; Thu, 8 Dec 2022 07:16:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf6yuFRYCdPd86Kj+sHQ5LYHFFg9xJK5iBit0UzyIsqBaS08iF3fdxx9EmQ+niuEVZ5LB0R5 X-Received: by 2002:aa7:db4b:0:b0:46a:c6d3:a237 with SMTP id n11-20020aa7db4b000000b0046ac6d3a237mr7245975edt.132.1670512578752; Thu, 08 Dec 2022 07:16:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670512578; cv=none; d=google.com; s=arc-20160816; b=rc5vsP+gVU5optdVL6Mw+698EgUr1EnjUXd81aStQSEW2iwkzF2MoAHeOwwEGecyTw q4LIjntKlygfe8rLqiz+aBaSuAPlI98MVsGq8yQCBSdkHJpgC5gAdtqAWBj5vJRfXhyp jW0RiA1xQx7ve39stfecvZUWjC2XWdj61vUrWmLExs2xQ0drMSV52aXRhzIMj12iTwYK mzFpiN4elYDG2i1o6wLHPv+W51xWDGg3VZft3fQwmoq2xFNSptT/Zc77v5jRauRI2MT/ ATwIl6TKBJdcagah2kYMYcGHiqkIgdp3PS1xYoyOOiBX04WbUDAP9m3MchtbECXTi/Cu Q1CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MWHo4Fc/h7oobC05MLZN04ZUMufvvKOqJdqxGKH7+yI=; b=HuqKQMmsXLlvFM2uIbVtLny8OMtBP3E/38VyuhYYKvy37HtlIjm8LmgV1ui9LcFTSB 5FixQjGYyvc2zyrYxpbYzmo665lGluQ4OdS5Pq1ecnooR489ydTkdp8zmr5PD+rbxecX 6E9WTZotpTD3Hg4g8VewguE7Re+8RQrB5xqoer45ecRgJzpESnGXkBU1qpKq04cHLRCE 0pEe2lE82DrHaxK2ea/ditHOiBy2xNd7ahCJ60eeXxJ2bhWayLcIQTUMwqqMHC6PbuRC WiaNw6wXZBhLVnzGA0LxMYfG+r0D5wp2bTzDv0TnutGusYvi5IcUAzYWN/vu/rN7oOtI 0aFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZMj7fYoY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wu5-20020a170906eec500b00730a4246dd0si9703244ejb.593.2022.12.08.07.15.54; Thu, 08 Dec 2022 07:16:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZMj7fYoY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230159AbiLHPOf (ORCPT + 99 others); Thu, 8 Dec 2022 10:14:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229961AbiLHPOV (ORCPT ); Thu, 8 Dec 2022 10:14:21 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95FA7ABA10 for ; Thu, 8 Dec 2022 07:14:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4529661F7C for ; Thu, 8 Dec 2022 15:13:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB280C433B5; Thu, 8 Dec 2022 15:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670512438; bh=vduhEwTqUmujvyUHIEbNfHylxhRM+/iHi4mF+4Bpzvk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZMj7fYoYcAgR54QWLbYw3liejLnN8HA6KDMScCtz9FJk5qcN++cjhgJuiMCQL+xeq kOEZKQouFylF4gf9rays11mytgr+5KrYX11784qb++HpuEBrx+lJSzt17DGl2OcRd4 UGM7WAsVcYt0VeKp7de8mFeJ5c+zPPnPCFkwvExc1wioqghdQ8nYmc6a2pJ/oqYlsk 5vSpshRAVJlCVlvhObIsiuxo/7wDYHDOGvKoW6ByssCvii4w1TxIO1zL61ELTzHQPr snepxKposuX7bZeTvTcIOGWD3XarroyzjeKkfxCvQx/21duQTEbcOUXxuw+mhKImT3 OB9b6qaqAA86g== From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: Tomer Tayar Subject: [PATCH 03/26] habanalabs: remove releasing of user threads from device release Date: Thu, 8 Dec 2022 17:13:27 +0200 Message-Id: <20221208151350.1833823-3-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221208151350.1833823-1-ogabbay@kernel.org> References: <20221208151350.1833823-1-ogabbay@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751659397828520630?= X-GMAIL-MSGID: =?utf-8?q?1751659397828520630?= From: Tomer Tayar The device file is not in use when hl_device_release() is called, and there aren't any user threads that use IOCTLs to wait for interrupts. Therefore there is no need to release them at this point. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/device.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/misc/habanalabs/common/device.c b/drivers/misc/habanalabs/common/device.c index 87ab329e65d4..1453f2ec72d9 100644 --- a/drivers/misc/habanalabs/common/device.c +++ b/drivers/misc/habanalabs/common/device.c @@ -511,11 +511,6 @@ static int hl_device_release(struct inode *inode, struct file *filp) return 0; } - /* Each pending user interrupt holds the user's context, hence we - * must release them all before calling hl_ctx_mgr_fini(). - */ - hl_release_pending_user_interrupts(hpriv->hdev); - hl_ctx_mgr_fini(hdev, &hpriv->ctx_mgr); hl_mem_mgr_fini(&hpriv->mem_mgr);