| Message ID | 20221208135512.421903-8-paul.kocialkowski@bootlin.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp207699wrr;
Thu, 8 Dec 2022 05:57:27 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf6pwBDRgrTVDdoSe8N0ST0c+gRMOVgqjJdTbpv6WMSRAZiIUSHqeRrpMD0hjQkx5QR8YqG9
X-Received: by 2002:a17:902:ee82:b0:189:f0ce:43db with SMTP id
a2-20020a170902ee8200b00189f0ce43dbmr8579011pld.88.1670507847144;
Thu, 08 Dec 2022 05:57:27 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1670507847; cv=none;
d=google.com; s=arc-20160816;
b=SePjDrJwKiZnGpxwcfoObA2OuC8QhunkTr4RbKN+4x28N9ZPyLj41NuXQWcY1gMwcl
lvOc8StMbf8+Hkoi8urrK3hprnNAnEYpkmD2Ur7osEeRLRjbZXzs8/Q5gCqigH3zyv6s
pGGUOThElw4HBOC2hdters6EksKGYzswGNm8gUOOUasNdWI9vatB6yNfs5v6R46oqw3v
+cEZGwDEAeUVErcsgPn6SCJt+ap6/zcJuVaQQMs5SXjKt8x2Ckf6l0s1kij9G8EF9yD5
R3WCz4f/kT5Xxp7O/AZtW3gEPg/1JsCeXBq3aN4z1bO/CRBnk0A487ev77csYKfLfRFM
8hFA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=NirQ4Z0H8CCFNO8YF35iEuHBJ67K2AC07Y4K8xGkunI=;
b=WvRlYrlbJMKGccaYNkKHdao3X5LubosXk3E1lEkyYteT2o2BWOX+0BCjh8rmdxkK4E
TiDbDjBlBewvns4wisuxyZwfz7JPnTJLGNJKg+xFeOFk8QVR+FjmH+S6uKbV4l9IoPoS
DRA9X7KT1/pyYxfiRiOur3CaSN3+ltPr1T10RRpTRtQpPsghZr6kDXe9sjcecwrajKOA
KkiPBAAjWWnNcAoCcd8KX8R7uY/xLKYjDkCyfhhgILKc4yjS6EvdqGZ1rWMerEpn7rE+
eM7o8Y4IH1KCSSUA7QUKbsnEwlTMH6REYnGE7M8WuoC1bGgUgrmSNdMCfY65N54HoSJd
NpJA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@bootlin.com header.s=gm1 header.b=deKqCLsx;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
oj3-20020a17090b4d8300b00219ebe1506esi4717482pjb.131.2022.12.08.05.57.13;
Thu, 08 Dec 2022 05:57:27 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@bootlin.com header.s=gm1 header.b=deKqCLsx;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230217AbiLHN4z (ORCPT <rfc822;foxyelen666@gmail.com>
+ 99 others); Thu, 8 Dec 2022 08:56:55 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60386 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230283AbiLHN4d (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 8 Dec 2022 08:56:33 -0500
Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net
[IPv6:2001:4b98:dc4:8::227])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3B5A9951D;
Thu, 8 Dec 2022 05:56:13 -0800 (PST)
Received: (Authenticated sender: paul.kocialkowski@bootlin.com)
by mail.gandi.net (Postfix) with ESMTPSA id 6CA972000F;
Thu, 8 Dec 2022 13:55:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1;
t=1670507752;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=NirQ4Z0H8CCFNO8YF35iEuHBJ67K2AC07Y4K8xGkunI=;
b=deKqCLsxjB88RmwnIcZIHBybtsPdTrLSzv+zQgNRFNikyTIWDuEu9NLsEvKJL7YNC3G9df
Dm+ax6gFUOJkNzsg+VlE6qQ4BY9SjjTkjEOr58YVY/gNK/FfaagWL6DhCjO/8Pss8MVKbM
xLdyr3LGB+Cu+5eNn2GKWm+d1KJrxt45wXrxTJosHfzGD91tRb1b+jvK1gg3ar4CuDbFjl
a1zs5PNPj0vwZmy/K/hHHa2Iww0yagn8p54cIpbDIbmnwCdDElETYGeYYHm5XYOGnNgXA9
mhtmXkKPIQkZaIl2//RuuuOZp+znQ9Z3o+ptvkYrlSiEYe68kC5G0zTTkDYydQ==
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Cc: Yong Deng <yong.deng@magewell.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Sakari Ailus <sakari.ailus@iki.fi>,
Conor Dooley <conor@kernel.org>,
Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH v2 07/11] media: sun6i-isp: proc: Fix return code handling in
stream off path
Date: Thu, 8 Dec 2022 14:55:08 +0100
Message-Id: <20221208135512.421903-8-paul.kocialkowski@bootlin.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221208135512.421903-1-paul.kocialkowski@bootlin.com>
References: <20221208135512.421903-1-paul.kocialkowski@bootlin.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1751654436070356371?=
X-GMAIL-MSGID: =?utf-8?q?1751654436070356371?=
|
| Series |
Allwinner A31/A83T CSI/ISP/MIPI CSI-2 media fixes
|
|
Commit Message
Paul Kocialkowski
Dec. 8, 2022, 1:55 p.m. UTC
Explicitly set ret to zero on disable path to avoid a related smatch
warning. This makes initialization at declaration useless.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c index d69d2be0add2..a95709d2c573 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c @@ -173,8 +173,7 @@ static int sun6i_isp_proc_s_stream(struct v4l2_subdev *subdev, int on) struct sun6i_isp_proc_source *source; struct v4l2_subdev *source_subdev; struct media_pad *remote_pad; - /* Initialize to 0 to use both in disable label (ret != 0) and off. */ - int ret = 0; + int ret; /* Source */ @@ -195,6 +194,7 @@ static int sun6i_isp_proc_s_stream(struct v4l2_subdev *subdev, int on) if (!on) { sun6i_isp_proc_irq_disable(isp_dev); v4l2_subdev_call(source_subdev, video, s_stream, 0); + ret = 0; goto disable; }