From patchwork Wed Dec 7 21:48:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Oliver Upton X-Patchwork-Id: 31060 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp419592wrr; Wed, 7 Dec 2022 13:49:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf7R6RPFUN2Td8ZQnHozrtadeFQbeg8U8oiz5dhAa8NDlCHp2qlRz60Zr07pkUFU9mCA/OGE X-Received: by 2002:a17:90a:f104:b0:218:bd1d:37ad with SMTP id cc4-20020a17090af10400b00218bd1d37admr82086907pjb.39.1670449759651; Wed, 07 Dec 2022 13:49:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670449759; cv=none; d=google.com; s=arc-20160816; b=A7YwEM3CJ6VD5FTnFWlfk6QRgSq7ctNeto/3Dn8Gtr/54ZgjCIiWCBVXsSgFDfqJp3 IEB2g/hsMr2XVXfarASMqBqa8yxK92G1VSzpcDm6oRS3VlmE3R2++rhJkk9xLJ9+qZOS oEUK881g7DiDnZiM9/Tp4XrgWUvGky0oNrFIO7wk1q+Wpg2LKN6GDJ2NR5yw752/hney KJkOELo1qxncFHN7/skkIsBsj8p2x9gxAZtcYQD5N/dfrA0fQEk/5glimZHmR5QrI+NK 3VwCQlDmsutlH8DYADAT6QUcARc2KX+Us5ihpvlF1nRXUJ/CiLDwKwrd2tnu/W3hot/e f54g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=OmUuSlDwuptIt2dazcrMy1PSKnvzv2Vi/qLEdCvsz/Y=; b=YZWqlWe2j5Fz2bVVXAIa+kguqXEP52IKcBHeMP7uGfRAZWPJcVWMTOoiR4+/lwgJBb hqDls8YhCV09A85xfVYNtUADR7dNXyw3VbGCazo15y0fA+y9rs4PVgQGoNkgeShed96x Rn6PGXma/3JsK3UzfnVDUHykxjjFyFNi+5xQUWWPNHfIqcYMBkA9q3LvVaSYB1d87uGw sqPChzPV1ohXPA9mBAwEXPsi870xs0qo3nYFbT0X9WZ2ssa/yXBMNmUx21KqKRNGUV5o xjahiVyDS3fQrwbhuLyXu2BPduDB/tD44FuLQGKqzxI7T561JiQkQMUYlREdNdO0K5Rd TlWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=r9OVVkwq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w11-20020a63f50b000000b00478e26efc95si5877197pgh.34.2022.12.07.13.49.06; Wed, 07 Dec 2022 13:49:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=r9OVVkwq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbiLGVs2 (ORCPT + 99 others); Wed, 7 Dec 2022 16:48:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbiLGVs1 (ORCPT ); Wed, 7 Dec 2022 16:48:27 -0500 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0660554EE; Wed, 7 Dec 2022 13:48:26 -0800 (PST) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1670449704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OmUuSlDwuptIt2dazcrMy1PSKnvzv2Vi/qLEdCvsz/Y=; b=r9OVVkwqCW2+ZPso5Mwh5U1VnBcaT5WsdLENVqzghNOT3staCANlBlpxlDD4ykT/tlhLWu aE9D5Y1Hts/dAqCvu9onYYdd8eq7FFPmU3GxGxMEhzyhvZRKyGGTsrCch80Jnhdu3LaOuN 9UpIlbMneOGhUV9yZri4B4u7RnWiMJI= From: Oliver Upton To: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Oliver Upton , Paolo Bonzini , Shuah Khan , Andrew Jones , Sean Christopherson , Ricardo Koller Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kvmarm@lists.linux.dev, Mark Brown , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] KVM: selftests: Fix build due to ucall_uninit() removal Date: Wed, 7 Dec 2022 21:48:05 +0000 Message-Id: <20221207214809.489070-2-oliver.upton@linux.dev> In-Reply-To: <20221207214809.489070-1-oliver.upton@linux.dev> References: <20221207214809.489070-1-oliver.upton@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751593527202073895?= X-GMAIL-MSGID: =?utf-8?q?1751593527202073895?= From: Mark Brown Today's -next fails to build on arm64 due to: In file included from include/kvm_util.h:11, from aarch64/page_fault_test.c:15: include/ucall_common.h:36:47: note: expected ‘vm_paddr_t’ {aka ‘long unsigned int’} but argument is of type ‘void *’ 36 | void ucall_init(struct kvm_vm *vm, vm_paddr_t mmio_gpa); | ~~~~~~~~~~~^~~~~~~~ aarch64/page_fault_test.c:725:2: warning: implicit declaration of function ‘ucall_uninit’; did you mean ‘ucall_init’? [-Wimplicit-function-declaration] 725 | ucall_uninit(vm); | ^~~~~~~~~~~~ | ucall_init which is caused by commit interacting poorly with commit 28a65567acb5 ("KVM: selftests: Drop now-unnecessary ucall_uninit()") As is done for other ucall_uninit() users remove the call in the newly added page_fault_test.c. Fixes: 28a65567acb5 ("KVM: selftests: Drop now-unnecessary ucall_uninit()") Fixes: 35c581015712 ("KVM: selftests: aarch64: Add aarch64/page_fault_test") Signed-off-by: Mark Brown Cc: Sean Christopherson Cc: Ricardo Koller Cc: Marc Zyngier Signed-off-by: Oliver Upton --- tools/testing/selftests/kvm/aarch64/page_fault_test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/kvm/aarch64/page_fault_test.c b/tools/testing/selftests/kvm/aarch64/page_fault_test.c index 0cda70bef5d5..92d3a91153b6 100644 --- a/tools/testing/selftests/kvm/aarch64/page_fault_test.c +++ b/tools/testing/selftests/kvm/aarch64/page_fault_test.c @@ -722,7 +722,6 @@ static void run_test(enum vm_guest_mode mode, void *arg) vcpu_run_loop(vm, vcpu, test); - ucall_uninit(vm); kvm_vm_free(vm); free_uffd(test, pt_uffd, data_uffd);