From patchwork Wed Dec 7 19:03:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 30992 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp357806wrr; Wed, 7 Dec 2022 11:05:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf5DY+BOBC2mEHZxwLpFuX85GBwjFp8kGcPlPWFJ6zMkN7juZ+gpLGm5mJq92LWYdzvSGkBo X-Received: by 2002:a17:903:1203:b0:189:30cd:8fa4 with SMTP id l3-20020a170903120300b0018930cd8fa4mr79190879plh.103.1670439949580; Wed, 07 Dec 2022 11:05:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670439949; cv=none; d=google.com; s=arc-20160816; b=LHL8R7NCiDsBikN3MPqG3/icbvvrSVbTt2NCH8QBPdJ1sHXqhtxE5kM+NoQTWhkyvZ NldcMSC6Ubvm+RsPTVv82b6wmcUwY/nEJHVSsdwpf/kyY2lU+SCTilPFmQKe+SMo6zRU fL2SLQOvlJ8jqcr3ag10rXkuX0fR8Ig2k7XDebeNN1hy7+avTtthKwOs4ribxVT2Dszh wnjzNx79jK0mhkrrBU1o/GZf/oIB6af4DShjM8gEo0IKRyVjEijXQWVM+NXv219bVTf4 sp+AlwuKYA+HeTsynUPQijqkBavZMg9wWNTjm6zqI7uBlPg/F6fMKIUjnz9FTTXb8i4h TDJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yQMIkyqxS08Gd+bbaCPDtzE0ybzjTkAOkY3rR5WaEks=; b=PB5AOEkWE6mQ85A/mIUu1r4WN39BD/rGY8BbiUExEtMER32AjFE/SeVOAhyKGsj2tu Hne4pMOEXEEw/k9kOqOvuyzWU8znJcGRYII2bdv69FF+ZewoO6gYVeNw1Te1KYiCUGqU jFTtRzAgZ+22pSHxuRGfMzBoHOOnuOYkDtf9xrNtapxUJqwdkZNm/qE+Jxs0R9/YQz9l 8K1eI0R4DSV6U28VoYeBUMIrep0GmTkvSDppyECWZKtsoASza7AOh0b/Ge35hSUUPSy7 XHmQVd6h+wltCJTJIOtvp+nZoDPMXS9TRQ2t+jTxjy1GWbUSBDTJj+/gE/i8KxwoAQwb hMwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RjrNYgy9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lr18-20020a17090b4b9200b0021336b17122si2366897pjb.5.2022.12.07.11.05.35; Wed, 07 Dec 2022 11:05:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RjrNYgy9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229843AbiLGTET (ORCPT + 99 others); Wed, 7 Dec 2022 14:04:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229788AbiLGTEE (ORCPT ); Wed, 7 Dec 2022 14:04:04 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE2FC70614; Wed, 7 Dec 2022 11:04:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670439842; x=1701975842; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5GwPuobCpJ0+heyq5ckbm6iaVU06rI+4xJ6yg8SuKhM=; b=RjrNYgy9SLTW0HJweCLS77U6R2DvngqMnAwbyEUdHv4gxzoAoetqOpdG U+h4q787M/pv56x8O2S0J+NUn7w/LjqrS2PQm+0pYspgSYnmJrBU0/IHS Kxkv2PFrcGrr8b7mQFxM2LkiYdaoDlxBrjpjTPzR72nQXyTYtIkwkK6mZ v5VD1EvPYq1OLi5qhRrqqmudgP+RiPGi9yePb7YvD4+qMjneNeRalH6G2 zc9ngan3BdT1ctL4qAs/Bq3COnOwWjJzbEBLG3fTma+5FjnU4o8GQsoMT qtRMACKBD8DWR72wyglY6lqsLpllGnhKEdxXHLdjT9RMaEHiqjrF2xJzb A==; X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="315690226" X-IronPort-AV: E=Sophos;i="5.96,225,1665471600"; d="scan'208";a="315690226" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2022 11:03:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="821060668" X-IronPort-AV: E=Sophos;i="5.96,225,1665471600"; d="scan'208";a="821060668" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 07 Dec 2022 11:03:40 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0E46D184; Wed, 7 Dec 2022 21:04:09 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Cc: Jonathan Cameron , Lars-Peter Clausen , Ferry Toth Subject: [PATCH v1 05/11] iio: light: tsl2563: Drop unused defintion(s) Date: Wed, 7 Dec 2022 21:03:42 +0200 Message-Id: <20221207190348.9347-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221207190348.9347-1-andriy.shevchenko@linux.intel.com> References: <20221207190348.9347-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751583240450209713?= X-GMAIL-MSGID: =?utf-8?q?1751583240450209713?= The CALIB_FRAC() is defined and might had been used in tsl2563_calib_from_sysfs(). But let's just move a comment from it to the latter function. CLAIB_FRAC_HALF is used in a single place, i.e. in tsl2563_calib_to_sysfs(). So, let's just inline it there. While at it, switch to use DIV_ROUND_CLOSEST(). Signed-off-by: Andy Shevchenko Tested-by: Ferry Toth --- drivers/iio/light/tsl2563.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c index 3b60d8000351..bdd40a5df53d 100644 --- a/drivers/iio/light/tsl2563.c +++ b/drivers/iio/light/tsl2563.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -38,10 +39,6 @@ /* Bits used for fraction in calibration coefficients.*/ #define CALIB_FRAC_BITS 10 -/* 0.5 in CALIB_FRAC_BITS precision */ -#define CALIB_FRAC_HALF BIT(CALIB_FRAC_BITS - 1) -/* Make a fraction from a number n that was multiplied with b. */ -#define CALIB_FRAC(n, b) (((n) << CALIB_FRAC_BITS) / (b)) /* Decimal 10^(digits in sysfs presentation) */ #define CALIB_BASE_SYSFS 1000 @@ -360,12 +357,12 @@ static int tsl2563_get_adc(struct tsl2563_chip *chip) static inline int tsl2563_calib_to_sysfs(u32 calib) { - return (int) (((calib * CALIB_BASE_SYSFS) + - CALIB_FRAC_HALF) >> CALIB_FRAC_BITS); + return (int)DIV_ROUND_CLOSEST(calib * CALIB_BASE_SYSFS, BIT(CALIB_FRAC_BITS)); } static inline u32 tsl2563_calib_from_sysfs(int value) { + /* Make a fraction from a number n that was multiplied with b. */ return (((u32) value) << CALIB_FRAC_BITS) / CALIB_BASE_SYSFS; }