diff mbox series

RDMA/hfi1: use sysfs_emit() to instead of scnprintf()

Message ID 202212071632188074249@zte.com.cn
State New
Headers
Series RDMA/hfi1: use sysfs_emit() to instead of scnprintf() |

Commit Message

ye.xingchen@zte.com.cn Dec. 7, 2022, 8:32 a.m. UTC 
  From: ye xingchen <ye.xingchen@zte.com.cn>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/infiniband/hw/hfi1/driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leon Romanovsky Dec. 7, 2022, 9:08 a.m. UTC | #1 
On Wed, Dec 07, 2022 at 04:32:18PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>  drivers/infiniband/hw/hfi1/driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/driver.c b/drivers/infiniband/hw/hfi1/driver.c
> index 8e71bef9d982..bcc6bc0540f0 100644
> --- a/drivers/infiniband/hw/hfi1/driver.c
> +++ b/drivers/infiniband/hw/hfi1/driver.c
> @@ -112,7 +112,7 @@ static int hfi1_caps_get(char *buffer, const struct kernel_param *kp)
>  	cap_mask &= ~HFI1_CAP_LOCKED_SMASK;
>  	cap_mask |= ((cap_mask & HFI1_CAP_K2U) << HFI1_CAP_USER_SHIFT);
> 
> -	return scnprintf(buffer, PAGE_SIZE, "0x%lx", cap_mask);
> +	return sysfs_emit(buffer, "0x%lx\n", cap_mask);

Dennis,

Please pay attention what "\n" doesn't exist in original line.
I applied the patch as I think it is the same, but if you see that it
is not, please say so, so we will drop/adapt it before merge window.

Thanks

>  }
> 
>  struct pci_dev *get_pci_dev(struct rvt_dev_info *rdi)
> -- 
> 2.25.1
Leon Romanovsky Dec. 7, 2022, 9:08 a.m. UTC | #2 
On Wed, 7 Dec 2022 16:32:18 +0800 (CST), ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> 
> [...]

Applied, thanks!

[1/1] RDMA/hfi1: use sysfs_emit() to instead of scnprintf()
      https://git.kernel.org/rdma/rdma/c/d074f0aebde564

Best regards,
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/hfi1/driver.c b/drivers/infiniband/hw/hfi1/driver.c
index 8e71bef9d982..bcc6bc0540f0 100644
--- a/drivers/infiniband/hw/hfi1/driver.c
+++ b/drivers/infiniband/hw/hfi1/driver.c
@@ -112,7 +112,7 @@  static int hfi1_caps_get(char *buffer, const struct kernel_param *kp)
 	cap_mask &= ~HFI1_CAP_LOCKED_SMASK;
 	cap_mask |= ((cap_mask & HFI1_CAP_K2U) << HFI1_CAP_USER_SHIFT);

-	return scnprintf(buffer, PAGE_SIZE, "0x%lx", cap_mask);
+	return sysfs_emit(buffer, "0x%lx\n", cap_mask);
 }

 struct pci_dev *get_pci_dev(struct rvt_dev_info *rdi)