diff mbox series

[2/4] Documentation: amd_pstate: Move amd_pstate param to alphabetical order

Message ID 20221207154648.233759-3-wyes.karny@amd.com
State New
Headers
Series amd_pstate: Add guided autonomous mode support |

Commit Message

Wyes Karny Dec. 7, 2022, 3:46 p.m. UTC 
  Move amd_pstate command line param description to correct alphabetical
order.

Signed-off-by: Wyes Karny <wyes.karny@amd.com>
---
 .../admin-guide/kernel-parameters.txt         | 30 +++++++++----------
 1 file changed, 15 insertions(+), 15 deletions(-)

Comments

Bagas Sanjaya Dec. 8, 2022, 2:42 a.m. UTC | #1 
On Wed, Dec 07, 2022 at 03:46:46PM +0000, Wyes Karny wrote:
> +	amd_pstate=	[X86]
> +			disable
> +			  Do not enable amd_pstate as the default
> +			  scaling driver for the supported processors
> +			passive
> +			  Use amd_pstate as a scaling driver, driver requests a
> +			  desired performance on this abstract scale and the power
> +			  management firmware translates the requests into actual
> +			  hardware states (core frequency, data fabric and memory
> +			  clocks etc.)

Device drivers request certain performance level?

> +			guided
> +			  Activate guided autonomous mode. Driver requests minimum
> +			  performance and maximum performance and the PMFW autonomously
> +			  selects frequencies in this range.

Same here.

Thanks.
Wyes Karny Dec. 9, 2022, 6:43 a.m. UTC | #2 
Hi Bagas Sanjaya,

On 12/8/2022 8:12 AM, Bagas Sanjaya wrote:
> On Wed, Dec 07, 2022 at 03:46:46PM +0000, Wyes Karny wrote:
>> +	amd_pstate=	[X86]
>> +			disable
>> +			  Do not enable amd_pstate as the default
>> +			  scaling driver for the supported processors
>> +			passive
>> +			  Use amd_pstate as a scaling driver, driver requests a
>> +			  desired performance on this abstract scale and the power
>> +			  management firmware translates the requests into actual
>> +			  hardware states (core frequency, data fabric and memory
>> +			  clocks etc.)
> 
> Device drivers request certain performance level?

What about the below wording?

""

passive
	Use amd_pstate with passive mode as a scaling driver.
	In this mode autonomous selection is disabled.
	Driver requests a desired performance level and PMFW
	tires to match the same performance level (if it is
	satisfied by guaranteed performance level).

""

Perry, let me know if it looks fine to you?

> 
>> +			guided
>> +			  Activate guided autonomous mode. Driver requests minimum
>> +			  performance and maximum performance and the PMFW autonomously
>> +			  selects frequencies in this range.
> 
> Same here.

I'll rewrite this as:

guided
	Activate guided autonomous mode. Driver requests minimum and
	maximum performance level and the PMFW autonomously
	selects a performance level in this range and appropriate
	to the current workload.

> 
> Thanks. 
>
diff mbox series

Patch

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 75e57afba77e..143a38ce27e5 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -339,6 +339,21 @@ 
 			             This mode requires kvm-amd.avic=1.
 			             (Default when IOMMU HW support is present.)
 
+	amd_pstate=	[X86]
+			disable
+			  Do not enable amd_pstate as the default
+			  scaling driver for the supported processors
+			passive
+			  Use amd_pstate as a scaling driver, driver requests a
+			  desired performance on this abstract scale and the power
+			  management firmware translates the requests into actual
+			  hardware states (core frequency, data fabric and memory
+			  clocks etc.)
+			guided
+			  Activate guided autonomous mode. Driver requests minimum
+			  performance and maximum performance and the PMFW autonomously
+			  selects frequencies in this range.
+
 	amijoy.map=	[HW,JOY] Amiga joystick support
 			Map of devices attached to JOY0DAT and JOY1DAT
 			Format: <a>,<b>
@@ -6959,18 +6974,3 @@ 
 				memory, and other data can't be written using
 				xmon commands.
 			off	xmon is disabled.
-
-	amd_pstate=	[X86]
-			disable
-			  Do not enable amd_pstate as the default
-			  scaling driver for the supported processors
-			passive
-			  Use amd_pstate as a scaling driver, driver requests a
-			  desired performance on this abstract scale and the power
-			  management firmware translates the requests into actual
-			  hardware states (core frequency, data fabric and memory
-			  clocks etc.)
-			guided
-			  Activate guided autonomous mode. Driver requests minimum
-			  performance and maximum performance and the PMFW autonomously
-			  selects frequencies in this range.