From patchwork Wed Dec 7 01:14:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yang X-Patchwork-Id: 30572 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3146960wrr; Tue, 6 Dec 2022 17:21:14 -0800 (PST) X-Google-Smtp-Source: AA0mqf7OF+Osw6RxQu4slZJ9hFKLqSScOQxtj3bIWkXkgjKaIzgnNUpYN5oSvVW0pXxWxFrEQiyF X-Received: by 2002:aa7:d314:0:b0:46c:fc3f:cf8a with SMTP id p20-20020aa7d314000000b0046cfc3fcf8amr6186312edq.386.1670376074166; Tue, 06 Dec 2022 17:21:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670376074; cv=none; d=google.com; s=arc-20160816; b=XkAzomhnfuqFV3J+1rOXPQVqOKD8xnGQpCaQzwvSa3t060/p3WiZU7LLM/bbE6zu50 GScIO7Bui4NpLsMN+ENvOwPgwXfherqzYGf5KNIGi5WETjW1bK8DT7KHtnqRWfVJHFQq 8UFzuyCVvZP/+iXrSLx0yQs6QUMr2w94LgbwokhgXcb8LMe5v5t0pgMoZRUdj2s4HiP4 ZjVyMUIfJzV/J9GnhZt/Csav9ef7P9aImpkXID9aRzSLLab1XLTc8Wvhvx8M2Qp4+fxt KNTlln39AFBpLJaBNwDTQi7eZ392SzJZOVW8vFBLYULAYYJnboV/HXIrjkiT+LsUc8wF AslA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=igTSLt/yJRWfVoFPjZqtyau1Z5PRKYe7hJIhnygHO1M=; b=LEEhjeTLG+Y06o89Du32gDScL9oikMlkI1dIPsdYvLpqL9pBq3D+hOliAty1rptatb SoBcqllu+HaqrQMLqld23XK7Ql1IC8IWaTAvt+40QKn0VGoMu8CaCjCGOQo6GYPOoqr8 siE+ddeJ2sBL5IW9HBiAOlvZTwwJaxIbjMegNlGMStZH21A57r3TnBvmeYgq2UX3OmCJ BuNXmNiAcZyYJM0rjFJWwN8tPk+Uy8r6p5iz3MJlP1DLjzDP363cBlTEQGwHiJbHFiYb ah2q619h8qWzGL5PFszmbrZm9sY/E/Q2CDbCvCkxUwpKxutpI86+JGJeT6i3t5l5rwF5 I/ag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hv22-20020a17090760d600b0078316f0b5f8si4025688ejc.88.2022.12.06.17.20.51; Tue, 06 Dec 2022 17:21:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbiLGBOk (ORCPT + 99 others); Tue, 6 Dec 2022 20:14:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229670AbiLGBOj (ORCPT ); Tue, 6 Dec 2022 20:14:39 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B4434C25C for ; Tue, 6 Dec 2022 17:14:38 -0800 (PST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NRfT92XxWz4xVnK; Wed, 7 Dec 2022 09:14:37 +0800 (CST) Received: from szxlzmapp04.zte.com.cn ([10.5.231.166]) by mse-fl1.zte.com.cn with SMTP id 2B71EN5C058547; Wed, 7 Dec 2022 09:14:23 +0800 (+08) (envelope-from yang.yang29@zte.com.cn) Received: from mapi (szxlzmapp02[null]) by mapi (Zmail) with MAPI id mid14; Wed, 7 Dec 2022 09:14:24 +0800 (CST) Date: Wed, 7 Dec 2022 09:14:24 +0800 (CST) X-Zmail-TransId: 2b04638fe8f0ffffffff9ff87117 X-Mailer: Zmail v1.0 Message-ID: <202212070914242210002@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , , , , , Subject: =?utf-8?q?=5BPATCH_linux-next=5D_misc=3A_eeprom/idt=5F89hpesx=3A_us?= =?utf-8?q?e_strscpy=28=29_to_instead_of?= =?utf-8?b?IHN0cm5jcHkoKcKg?= X-MAIL: mse-fl1.zte.com.cn 2B71EN5C058547 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 638FE8FD.000 by FangMail milter! X-FangMail-Envelope: 1670375677/4NRfT92XxWz4xVnK/638FE8FD.000/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 638FE8FD.000/4NRfT92XxWz4xVnK X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751516261895161056?= X-GMAIL-MSGID: =?utf-8?q?1751516261895161056?= From: Xu Panda The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings. Signed-off-by: Xu Panda Signed-off-by: Yang Yang --- drivers/misc/eeprom/idt_89hpesx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c index 4e07ee9cb500..57b985fe59f4 100644 --- a/drivers/misc/eeprom/idt_89hpesx.c +++ b/drivers/misc/eeprom/idt_89hpesx.c @@ -941,8 +941,7 @@ static ssize_t idt_dbgfs_csr_write(struct file *filep, const char __user *ubuf, goto free_buf; } /* Copy the register address to the substring buffer */ - strncpy(csraddr_str, buf, csraddr_len); - csraddr_str[csraddr_len] = '\0'; + strscpy(csraddr_str, buf, csraddr_len + 1); /* Register value must follow the colon */ csrval_str = colon_ch + 1; } else /* if (str_colon == NULL) */ {