Message ID | 20221207-rpi-hvs-crtc-misc-v1-10-1f8e0770798b@cerno.tech |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp137475wrr; Wed, 7 Dec 2022 04:03:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf7955U9gCgjTaGOYF5gLaVdxFfH2BGdTHLPL2S35l0OlfUPBQ923tsJzvV0dWNtA9Gxr3Nj X-Received: by 2002:a17:902:b7c3:b0:189:5e92:d45a with SMTP id v3-20020a170902b7c300b001895e92d45amr61720647plz.157.1670414621650; Wed, 07 Dec 2022 04:03:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670414621; cv=none; d=google.com; s=arc-20160816; b=MwKYD8v+o9O+/wgNojDyIaCZXNdqBduRG+UGnmibbwRQF1ypFUQbqiOyWhwv1iLF0B 695Id+A+rKULspKPgaJgcYgDQHMsZTn9BckWK2RIdKO5DYJXOXSaY369k70uLFAMOIJl X0tsEYpQNqGJz0yVPuxNcSBt7yZ779yXvod8PijsR4BqJvv9DfreUmnCuOS3VZKqXxaU GIXYu9fst58EFDYnbmaZfgKYTqDDEZooo4kUkoiVz6+EESJa+0F7m19wUsbPeMRX9a12 eLmEYgr/JJD3O/25osyQqZo6Uq4xOrXco8Ubym+ip4LQHkuLuGhQUIs/9+jUCrkWhCz+ 7pwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :feedback-id:dkim-signature:dkim-signature; bh=chybC9bA4z237Otv3XNN+1hhSvj8Cx+nBnOPtGmUHew=; b=bOp3caqYGX8K/HkfgTnxCq2mFmXgeOlHnLN0IW3DOOTP9XitufMZO7OlVHOAEFxknw sc3iOOvnY9fUcyD4k9u9q02tGSCSh24OSDEkUpginbn26if4DA+iMxHwazGfJAEEEJFb cSk63+Hw0yMbQMIF0/foKNKdnb8Ic+AvAz2Gx3IuYz4xkltuIAUa0EWgzuN2oo1A2eJS 1TMOvxJCMp5odMkFk0Wzsgz6E03Ljl80rvKHzchWqs4yvVnjdHZDWq/69fBBs42s14EV dZeonez0mGkmF3EOv/2kx7OH51jc5yDGuQYOWL0oQ1qYaUdny5XxfBsCKRNFJhZYezAn MeOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b=exYWL9oD; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=tBPaV7Kp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y30-20020a056a00181e00b005774d572ad3si4084029pfa.31.2022.12.07.04.03.26; Wed, 07 Dec 2022 04:03:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b=exYWL9oD; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=tBPaV7Kp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbiLGL4U (ORCPT <rfc822;b08248@gmail.com> + 99 others); Wed, 7 Dec 2022 06:56:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbiLGLzc (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 7 Dec 2022 06:55:32 -0500 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38FE4CE28 for <linux-kernel@vger.kernel.org>; Wed, 7 Dec 2022 03:55:31 -0800 (PST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A52C95C01E9; Wed, 7 Dec 2022 06:55:30 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 07 Dec 2022 06:55:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1670414130; x= 1670500530; bh=chybC9bA4z237Otv3XNN+1hhSvj8Cx+nBnOPtGmUHew=; b=e xYWL9oDgcShiObJtAACa651WpMg6F3QytTFX5IYy+D/xSC4kJgQuLqL1V4pPbD+Z 1hJZTsOn7f2KOKSHSqEggJhigmUyeKYqF2Ka5cRavSkeBVAwhCr1XlgpuKHkFXBf EqpBAXTWRRiIUdfKfDKKmTYcRZjoKVZFHlqAbDyIQVMl3aeEaoMzmxFUtWTTabE6 VsvexcpQJcnVfkI87wmMBVX7KzH3Iu/8l4c9jQo0e69BjrUeKYZKAKU3ISquHuh0 cA4KwWyUSSm+1h3IZVBN6Wuk3qedrOfCe1uzWUW6W+kAUWL1TnV3eK8HBGzglS8C YNxfo3Tl7Um/gUCqa9KgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1670414130; x= 1670500530; bh=chybC9bA4z237Otv3XNN+1hhSvj8Cx+nBnOPtGmUHew=; b=t BPaV7KpvDzJNwekv8pTr10ms92PFWu2pKDHq4DKYgXjsACVcRMbEgpKJhshPUSTh fuGgR2Y9ZXqz6cNFdiTsotStFC3rf2mm180DQi48hYTzg3UcTIO3ouzssEpwfXXO bJGliH9xJy/yJ9fNgO/lbAdCMxjYcJDv3KTsSLYdEqWv7zqTbzbr0f0WmqdCfMvN qFp1Fkij3aCM0vTaG7A+mj6aD2+9hWwxOK3le50Haffn4qXWEpjVo0OWFX6sEpbc q6lWFJNjfoJY+8qyXU/hhOAdTQIUysr3WZdcS/NfgtFaWz7bEaH7/E9nu1EQ9+ZD NZSQFHZMwM/lFD7qDRw9A== X-ME-Sender: <xms:Mn-QY1zH7kxnwXP30kVmyeYgWxFCMO177QQdk-inyhbt7nfJ4LPtCA> <xme:Mn-QY1SmjSH5J7lCh-mXhrN_1r6g7qlr1kGzlrVG5nqIeMJlOz2ET40D9T-yfAkO5 8aRejvqmxfXeEtc4CU> X-ME-Received: <xmr:Mn-QY_Whj7GMjVy4Y5dNDLDyp7b6U538EX0EKwSl4qMZz12tYHcJSQ7WOOVcOnRFUg-7VyS8_9BDUysN9FXTyJl6PIWg6muQ8YCHAAzDZ_r9YA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekgdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhfffugggtgffkfhgjvfevofesthejredtredtjeenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeevvdelieejgedvkeffheekheeilefhgefgffehteekueelvddtueffheet ledtffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: <xmx:Mn-QY3h_aa7AVVwzSr3BYEZudc6YwrMVyYua6RT2hxqMdqTxrFsagw> <xmx:Mn-QY3DaVNoFRr314atgnZJ8V_WkB-ScUlGIXM432AEKNm5EHwLMqg> <xmx:Mn-QYwI-iDL7YVoEhwTD0oCUJEfxS_lRKLCX9C0sOeqsiMDQ9ckEKg> <xmx:Mn-QY_7zDCKkatjj3VB3EwoePDdbOqY69LfIzzYLYX7P-w7-yCFDdQ> Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Dec 2022 06:55:29 -0500 (EST) From: Maxime Ripard <maxime@cerno.tech> Date: Wed, 07 Dec 2022 12:53:21 +0100 Subject: [PATCH 10/15] drm/vc4: plane: Omit pixel_order from the hvs_format for hvs5 only formats MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20221207-rpi-hvs-crtc-misc-v1-10-1f8e0770798b@cerno.tech> References: <20221207-rpi-hvs-crtc-misc-v1-0-1f8e0770798b@cerno.tech> In-Reply-To: <20221207-rpi-hvs-crtc-misc-v1-0-1f8e0770798b@cerno.tech> To: Emma Anholt <emma@anholt.net>, Maxime Ripard <mripard@kernel.org>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Eric Anholt <eric@anholt.net> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson <dave.stevenson@raspberrypi.com>, Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>, Maxime Ripard <maxime@cerno.tech> X-Mailer: b4 0.11.0-dev-8c583 X-Developer-Signature: v=1; a=openpgp-sha256; l=1659; i=maxime@cerno.tech; h=from:subject:message-id; bh=TjzYPZb0GiveIAkQNU4LbeqUUAovVrht0vdSF4aq2qQ=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMkT6laaR36MquNQc/dmnOhx6bxYgEFIkWVOeJCjZUbKyaN3 Ioo6SlkYxLgYZMUUWWKEzZfEnZr1upONbx7MHFYmkCEMXJwCMJEtPxgZJje3WhXqqc2x/XUuuTX07a Ggq4p3vs08OJn/nvuqK/kR+xj+aTC2HFpTYBDzu1F1oar7eYt7N5g2Xuo6YP9+T+4G4XWd3AA= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751556682294861334?= X-GMAIL-MSGID: =?utf-8?q?1751556682294861334?= |
Series |
drm/vc4: Misc fixes and improvements for the HVS and CRTCs
|
|
Commit Message
Maxime Ripard
Dec. 7, 2022, 11:53 a.m. UTC
From: Dave Stevenson <dave.stevenson@raspberrypi.com> pixel_order is used for the earlier versions of the HVS, so is redundant on the 10:10:10:2 and 10bit YUV formats that are only supported on HVS5. Remove the assignment from the table to avoid confusion. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/gpu/drm/vc4/vc4_plane.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index 8b4805c937f0..7b7bbe94d47a 100644 --- a/drivers/gpu/drm/vc4/vc4_plane.c +++ b/drivers/gpu/drm/vc4/vc4_plane.c @@ -148,35 +148,30 @@ static const struct hvs_format { { .drm = DRM_FORMAT_P030, .hvs = HVS_PIXEL_FORMAT_YCBCR_10BIT, - .pixel_order = HVS_PIXEL_ORDER_XYCBCR, .pixel_order_hvs5 = HVS_PIXEL_ORDER_XYCBCR, .hvs5_only = true, }, { .drm = DRM_FORMAT_XRGB2101010, .hvs = HVS_PIXEL_FORMAT_RGBA1010102, - .pixel_order = HVS_PIXEL_ORDER_ABGR, .pixel_order_hvs5 = HVS_PIXEL_ORDER_ARGB, .hvs5_only = true, }, { .drm = DRM_FORMAT_ARGB2101010, .hvs = HVS_PIXEL_FORMAT_RGBA1010102, - .pixel_order = HVS_PIXEL_ORDER_ABGR, .pixel_order_hvs5 = HVS_PIXEL_ORDER_ARGB, .hvs5_only = true, }, { .drm = DRM_FORMAT_ABGR2101010, .hvs = HVS_PIXEL_FORMAT_RGBA1010102, - .pixel_order = HVS_PIXEL_ORDER_ARGB, .pixel_order_hvs5 = HVS_PIXEL_ORDER_ABGR, .hvs5_only = true, }, { .drm = DRM_FORMAT_XBGR2101010, .hvs = HVS_PIXEL_FORMAT_RGBA1010102, - .pixel_order = HVS_PIXEL_ORDER_ARGB, .pixel_order_hvs5 = HVS_PIXEL_ORDER_ABGR, .hvs5_only = true, },