From patchwork Tue Dec 6 00:34:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 30033 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2552265wrr; Mon, 5 Dec 2022 16:36:30 -0800 (PST) X-Google-Smtp-Source: AA0mqf5pW5TBhe8FFg0tJvvp1aRfK0hkHKkH0tNxMucKd1OQ5oFHLr0QWXTHE6SKco1E7BIr3kv3 X-Received: by 2002:a17:906:2e96:b0:7ad:8f76:17c7 with SMTP id o22-20020a1709062e9600b007ad8f7617c7mr59407817eji.315.1670286990188; Mon, 05 Dec 2022 16:36:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670286990; cv=none; d=google.com; s=arc-20160816; b=KdSP2AXwetm/2cOZomhahWgpDeJR3RHZZWHpZvYiDgnNCTms95Wv1AzYYsGpLXzCzT INj4tJPdOlZn44RtlbYjxCx4zsSsKNjbZevEReb3qF1ZvQjVZvfVG0bSJ4EblAq+iiTZ qYjURcqi17aIjAZixj/p29brP0/DzdGm2/BKg6BMG33WA7Sh6B3xNUqseYhlTOww4tQc GTrhUm0HHFLrnRcxCxk6OWivXro9s9IpmevKVT3veemGkGcBMnXAAkN8Zjc3mjQm59XM WTI/Ky3eCaKxmRxhcc0G/oNpLHWQtt2SzKtqWnUVIg0JmPONuAcgXl3T2WoF80RvfzsD hwgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=V90z9eTEMci54i3YZ8QYuNC9bFvs8+el6j2KiedHbvg=; b=BavbLlaItz8H3h+FmEx9eLWmDGa/fB/90jAyebDNX2oiUIDPXh1Ixxr+XRE3Pw0lg1 AVh1WfdmnYJu01gOvIxLIisNIRKGSokbSon/ni+cijwX+gdc8jDWkHsrUMoHDaXAT5dK i5ulSSxLWJ8BJXGjeNjpj+9kWb1U6tKMtKmTEfRaGPhtJaZT+YyuJfnz+yKT7NRNcezs x6ywbuefaHwMsMpVIMgpyl2/9tXqaJfxJBBiemGbxmMH7jSKWoGLLebkVjVjgVTkN5Zn kZ7QYvRZDJCZxCINIr56rqouY8AqPwhENXa+2Z+SiXHEAZ9D5CNWnncXgOB/znnq6PsV IQLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=R2Ndil74; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o22-20020a170906975600b007ae9abf1990si13382577ejy.352.2022.12.05.16.36.06; Mon, 05 Dec 2022 16:36:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=R2Ndil74; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232323AbiLFAfR (ORCPT + 99 others); Mon, 5 Dec 2022 19:35:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232118AbiLFAfD (ORCPT ); Mon, 5 Dec 2022 19:35:03 -0500 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 525BB1F2C5 for ; Mon, 5 Dec 2022 16:35:01 -0800 (PST) Received: by mail-io1-xd32.google.com with SMTP id h6so2988107iof.9 for ; Mon, 05 Dec 2022 16:35:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V90z9eTEMci54i3YZ8QYuNC9bFvs8+el6j2KiedHbvg=; b=R2Ndil74IG9PqDMJEegGA0DvTGkgW8PQSxp6pKCYZAHS0nj3FTiadswwvB2k5j5OVE xvIc9byBO4CklGK/HSKcCeGryj9tJMOr7HOVLtlkZaWMM+jt73YJrhOnrwuwTnELtWPC n5BGX7bbMsRU6DG0/fYQl8HLa+XlFfZOgPhfuE8TnuZQcuPfnTj6IG9E6HULwIMNMI0o x6gMUZP5uy+ECwqPhPhegeda2t9TcAnzmYqAErCet8NlUKDOBbJslIp9qEXHNdgpSLHr dAebJihOm+FeSYCFOg62daD+K7gVrHpy7MjLpY9W6qMWSC7ozzhUFCCGXqquz+10Johb B3lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V90z9eTEMci54i3YZ8QYuNC9bFvs8+el6j2KiedHbvg=; b=xARKmN490EBowCeWclDgnSP9yGFpfM9xPdg0ThwxJjY7lmJJvbXO6u9qCXlRkzZHk6 cvOWr5lPbSTlv9+wQs8jgM8njnrzqrcJyUGLA1StkQRocGZX6ISgsU7bdQkY90pF/XQn 0TRdJzLYSQWC2R/LRGwhUij8U5LA5EOqFYv8BVIPwbKbAQ4LklteSRBUo6lu+eXmvjx1 xlRwLFMTkqn58TiwHLrT7DVv88xfmTnPqb+foPS5tAQCnnUdpFWUQ1s/Vy/wRVp+C9dp 4Ggm4NXPIx+FphxoS48Y2062vUk6JtPsOAE23umrt0J+FBercyFwOmRjcaW1R3QDopx9 M0kw== X-Gm-Message-State: ANoB5plFwmeexUG9nYzorVs8a+E77sZNob8FUtUa+MtxGDMSpst8cLV1 7bu6imLPFX/owdbNtbYIfFb9S3GGNtVFcQ== X-Received: by 2002:a5e:a505:0:b0:6df:80f5:c0e5 with SMTP id 5-20020a5ea505000000b006df80f5c0e5mr17816718iog.44.1670286900927; Mon, 05 Dec 2022 16:35:00 -0800 (PST) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id x3-20020a056602160300b006bba42f7822sm6408213iow.52.2022.12.05.16.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 16:35:00 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com, daniel.vetter@ffwll.ch, seanpaul@chromium.org, robdclark@gmail.com, jbaron@akamai.com, gregkh@linuxfoundation.org, Jim Cromie Subject: [RFC PATCH 04/17] dyndbg: replace classmap list with a vector Date: Mon, 5 Dec 2022 17:34:11 -0700 Message-Id: <20221206003424.592078-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221206003424.592078-1-jim.cromie@gmail.com> References: <20221206003424.592078-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751422850708862527?= X-GMAIL-MSGID: =?utf-8?q?1751422850708862527?= Classmaps are stored/linked in a section/array, but are each added to the module's ddebug_table.maps list-head. This is unnecessary; even when ddebug_attach_classmap() is handling the builtin section (with classmaps for multiple builtin modules), its contents are ordered, so a module's possibly multiple classmaps will be consecutive in the section, and could be treated as a vector/block, since both start-addy and subrange length are in the ddebug_info arg. So this changes: struct ddebug_class_map drops list link. struct ddebug_table drops the maps list-head, and gets: classes & num_classes for the start-addy, and length. num_classes is placed to improve struct packing. The loading: in ddebug_attach_module_classes(), replace the for-the-modname list-add loop, with a forloop that finds the module's subrange (start,length) of matching classmaps within the possibly builtin classmaps vector, and saves those to the ddebug_table. The reading/using: change list-foreach loops in ddebug_class_name() & ddebug_find_valid_class() to walk the array from start to length. Also: Move #define __outvar up, above an added use in a fn-prototype. Simplify ddebug_attach_module_classes args, ref has both addy,len. This isn't technically a bugfix, but IMO simplifies later fixes for the chicken-egg post-init enablement regression. Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 1 - lib/dynamic_debug.c | 61 ++++++++++++++++++----------------- 2 files changed, 32 insertions(+), 30 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 41682278d2e8..bf47bcfad8e6 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -81,7 +81,6 @@ enum class_map_type { }; struct ddebug_class_map { - struct list_head link; struct module *mod; const char *mod_name; /* needed for builtins */ const char **class_names; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 48ca1387a409..fd5296dbb40f 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -45,10 +45,11 @@ extern struct ddebug_class_map __start___dyndbg_classes[]; extern struct ddebug_class_map __stop___dyndbg_classes[]; struct ddebug_table { - struct list_head link, maps; + struct list_head link; const char *mod_name; - unsigned int num_ddebugs; struct _ddebug *ddebugs; + struct ddebug_class_map *classes; + unsigned int num_ddebugs, num_classes; }; struct ddebug_query { @@ -146,13 +147,15 @@ static void vpr_info_dq(const struct ddebug_query *query, const char *msg) query->first_lineno, query->last_lineno, query->class_string); } +#define __outvar /* filled by callee */ static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table const *dt, - const char *class_string, int *class_id) + const char *class_string, + __outvar int *class_id) { struct ddebug_class_map *map; - int idx; + int i, idx; - list_for_each_entry(map, &dt->maps, link) { + for (map = dt->classes, i = 0; i < dt->num_classes; i++, map++) { idx = match_string(map->class_names, map->length, class_string); if (idx >= 0) { *class_id = idx + map->base; @@ -163,7 +166,6 @@ static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table cons return NULL; } -#define __outvar /* filled by callee */ /* * Search the tables for _ddebug's which match the given `query' and * apply the `flags' and `mask' to them. Returns number of matching @@ -1109,9 +1111,10 @@ static void *ddebug_proc_next(struct seq_file *m, void *p, loff_t *pos) static const char *ddebug_class_name(struct ddebug_iter *iter, struct _ddebug *dp) { - struct ddebug_class_map *map; + struct ddebug_class_map *map = iter->table->classes; + int i, nc = iter->table->num_classes; - list_for_each_entry(map, &iter->table->maps, link) + for (i = 0; i < nc; i++, map++) if (class_in_range(dp->class_id, map)) return map->class_names[dp->class_id - map->base]; @@ -1195,30 +1198,31 @@ static const struct proc_ops proc_fops = { .proc_write = ddebug_proc_write }; -static void ddebug_attach_module_classes(struct ddebug_table *dt, - struct ddebug_class_map *classes, - int num_classes) +static void ddebug_attach_module_classes(struct ddebug_table *dt, struct _ddebug_info *di) { struct ddebug_class_map *cm; - int i, j, ct = 0; + int i, nc = 0; - for (cm = classes, i = 0; i < num_classes; i++, cm++) { + /* + * Find this module's classmaps in a subrange/wholerange of + * the builtin/modular classmap vector/section. Save the start + * and length of the subrange at its edges. + */ + for (cm = di->classes, i = 0; i < di->num_classes; i++, cm++) { if (!strcmp(cm->mod_name, dt->mod_name)) { - - v2pr_info("class[%d]: module:%s base:%d len:%d ty:%d\n", i, - cm->mod_name, cm->base, cm->length, cm->map_type); - - for (j = 0; j < cm->length; j++) - v3pr_info(" %d: %d %s\n", j + cm->base, j, - cm->class_names[j]); - - list_add(&cm->link, &dt->maps); - ct++; + if (!nc) { + v2pr_info("start subrange, class[%d]: module:%s base:%d len:%d ty:%d\n", + i, cm->mod_name, cm->base, cm->length, cm->map_type); + dt->classes = cm; + } + nc++; } } - if (ct) - vpr_info("module:%s attached %d classes\n", dt->mod_name, ct); + if (nc) { + dt->num_classes = nc; + vpr_info("module:%s attached %d classes\n", dt->mod_name, nc); + } } /* @@ -1252,10 +1256,9 @@ static int __ddebug_add_module(struct _ddebug_info *di, unsigned int base, dt->num_ddebugs = di->num_descs; INIT_LIST_HEAD(&dt->link); - INIT_LIST_HEAD(&dt->maps); if (di->classes && di->num_classes) - ddebug_attach_module_classes(dt, di->classes, di->num_classes); + ddebug_attach_module_classes(dt, di); mutex_lock(&ddebug_lock); list_add_tail(&dt->link, &ddebug_tables); @@ -1344,8 +1347,8 @@ static void ddebug_remove_all_tables(void) mutex_lock(&ddebug_lock); while (!list_empty(&ddebug_tables)) { struct ddebug_table *dt = list_entry(ddebug_tables.next, - struct ddebug_table, - link); + struct ddebug_table, + link); ddebug_table_free(dt); } mutex_unlock(&ddebug_lock);