From patchwork Tue Dec 6 00:34:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 30042 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2552739wrr; Mon, 5 Dec 2022 16:37:56 -0800 (PST) X-Google-Smtp-Source: AA0mqf6NQZJfMDgQyBVXynlyAmXB1THyl71YgMmpH5lv5b5YxKmA2LlCjirjKCeDBN0m/t0zw+oJ X-Received: by 2002:a05:6402:1857:b0:46b:19aa:cfaa with SMTP id v23-20020a056402185700b0046b19aacfaamr35379282edy.229.1670287076429; Mon, 05 Dec 2022 16:37:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670287076; cv=none; d=google.com; s=arc-20160816; b=u/U2ncpwHlPe6FdAMjuF4qTTmkNhw70ED67xoW+Hrkm/qXXhHGf+ni8/8T+T1JvZgm SCYg/2ezHtdMbGtgiof6Pso24ta+Obr1pHi0cUmg4bct8Kz9GyCA3U9EgkzpaCFoJUr8 oYSpE2WKPp5hDmfJFRBp3XUThulivtFPuBshxc/rPsJ0iq3kbrPKbU6WnBzEZcwJ6DgK 4YiIhSZS+W87C1G8Wpx+d8cvm76u0D8TAqZKLMzh8cN1OfLqWagoYXRPldTTxLIaHa7J Tnrz7LIU0wzKbzLMO0At+YQjnTGRpZUg+AMkCUauBLguBbNyJQUbx1jQlH78urd1hc9n u9GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=FoWT3whneSiQzTAYd5Vl5dubMxD0/e5Afaj7/WmcC8o=; b=s3ld57Cg5Jb2oZnP4zUl6gvZxqio0TQGaJmcy+Hu6nILjw1d6GzmPFaZNtwfAwSLD6 SY9Mrr7CK7XV+dl64kLkFortwWdqh0+CNjAyv4qNNiBpWzH1CkWy69oJQfXmaQke7vgf GQZDo3Gb7Vx+PYJGM/EWn9e4R7HTx3iJzSAFnMHglBi/AVaKPiG++AA6VU1i6SOkLEcb WTAcdZTFwFAQHFKB1oD9WqxYSjL0wh6Jz5dJRwM15VwN45+UNXlwXlPHF5D2x+saiWxg aZ2qy5rWnjWjqgm5dDPO8OqW9jo3ySGMWTM7npnFdW6XhGOulAZCBA3Tbl7Gx/Qlka1H eaXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="hI/CwpgB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u12-20020aa7d98c000000b0046799762e48si657043eds.437.2022.12.05.16.37.32; Mon, 05 Dec 2022 16:37:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="hI/CwpgB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232918AbiLFAgK (ORCPT + 99 others); Mon, 5 Dec 2022 19:36:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232883AbiLFAfi (ORCPT ); Mon, 5 Dec 2022 19:35:38 -0500 Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C03F2127F for ; Mon, 5 Dec 2022 16:35:13 -0800 (PST) Received: by mail-io1-xd2f.google.com with SMTP id d123so3305766iof.6 for ; Mon, 05 Dec 2022 16:35:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FoWT3whneSiQzTAYd5Vl5dubMxD0/e5Afaj7/WmcC8o=; b=hI/CwpgBrv4FuN2UQf8ufrGEGWB3NLRMuEPL1gFEIujpHxwkfRV1QX1TD7RlOKnUjN wotsSjDJJYp77gKIDb6M6VvDv3dkVrpTi/b+lqk41/l+j3m1ZtggdhCEHN+9rnG09LXY EKqhFJSGtMtM4JE0WaHl49/OpjtHwTxZzFc1lkjFgGxgrx6ZkZR100GXh1qM/Gl4ZEe9 j9xnM8mlK8JDE6gz+sVwd5f0SqLBK5v1oPwOTS6WkFSbE+XLSydLHJQXjEZWc+MJ3mQz 42AuQhhU01H99SK0cwAuLJwvkCNpmI291UFZcFB++2WNpXQDgZVa6ehyw+7GUgdgLa/A knEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FoWT3whneSiQzTAYd5Vl5dubMxD0/e5Afaj7/WmcC8o=; b=J+u4ZQk7/nFueLyodJh0fpwCJkikTM1JB5LWw1yGoLIN4IGAjZg4BaTcSVzINwB20U kR6L6fHf1besnXBsaXpvmID6vIxGran0MgPSFY7l041IEIDkm9uDOB2zBqnHVJ52DOKr X9mSl+J+sLRS81ZK+BPJhInuNEmX6vhm0fJ3EG2m/934FQKH4SyScSpxSslYVvqxpoqF pRFZ34jV3itFqc+ZHwdXysf6b0LNDsotckgwqvv9VF5kMI2WOa7pDtw2iem4WJePLV9n 8zY4XsM1qC2IK72bx0ICPDRbLKJ8aBcfJRK6rqhGVfykIhIV22fUPGgsOcUURyRNDUnV H0mg== X-Gm-Message-State: ANoB5pnXSZbnrAwSC0M8/bE0NRvv4SKeICv65ey1PsNASCPXrCUtPGj6 dMFS6Nbqvr1VZCuObTdeKcsLWWUHjf6jtw== X-Received: by 2002:a02:6a43:0:b0:375:4725:4b4f with SMTP id m3-20020a026a43000000b0037547254b4fmr39159172jaf.52.1670286912140; Mon, 05 Dec 2022 16:35:12 -0800 (PST) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id x3-20020a056602160300b006bba42f7822sm6408213iow.52.2022.12.05.16.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 16:35:11 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com, daniel.vetter@ffwll.ch, seanpaul@chromium.org, robdclark@gmail.com, jbaron@akamai.com, gregkh@linuxfoundation.org, Jim Cromie Subject: [RFC PATCH 13/17] drm_print: fix stale macro-name in comment Date: Mon, 5 Dec 2022 17:34:20 -0700 Message-Id: <20221206003424.592078-14-jim.cromie@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221206003424.592078-1-jim.cromie@gmail.com> References: <20221206003424.592078-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751422941588288691?= X-GMAIL-MSGID: =?utf-8?q?1751422941588288691?= Cited commit uses stale macro name, fix this, and explain better. When DRM_USE_DYNAMIC_DEBUG=y, DYNDBG_CLASSMAP_DEFINE() maps DRM_UT_* onto BITs in drm.debug. This still uses enum drm_debug_category, but it is somewhat indirect, with the ordered set of DRM_UT_* enum-vals. This requires that the macro args: DRM_UT_* list must be kept in sync and in order. Fixes: f158936b60a7 ("drm: POC drm on dyndbg - use in core, 2 helpers, 3 drivers.") Signed-off-by: Jim Cromie --- . emphasize ABI non-change despite enum val change - Jani Nikula . reorder to back of patchset to follow API name changes. --- include/drm/drm_print.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 6a27e8f26770..7695ba31b3a4 100644 --- a/include/drm/drm_print.h +++ b/include/drm/drm_print.h @@ -276,7 +276,10 @@ static inline struct drm_printer drm_err_printer(const char *prefix) * */ enum drm_debug_category { - /* These names must match those in DYNAMIC_DEBUG_CLASSBITS */ + /* + * Keep DYNDBG_CLASSMAP_DEFINE args in sync with changes here, + * the enum-values define BIT()s in drm.debug, so are ABI. + */ /** * @DRM_UT_CORE: Used in the generic drm code: drm_ioctl.c, drm_mm.c, * drm_memory.c, ...