From patchwork Mon Dec 5 11:18:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ye.xingchen@zte.com.cn X-Patchwork-Id: 29644 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2191607wrr; Mon, 5 Dec 2022 03:29:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf4yPIL9AuYv1m0un/GAxL8TE3rOgd1osKi81Nrxg7Gwk4EsUwJO/Tdz6iWoL8sLCw7f9d/v X-Received: by 2002:aa7:8608:0:b0:52f:db84:81cf with SMTP id p8-20020aa78608000000b0052fdb8481cfmr65602476pfn.26.1670239751366; Mon, 05 Dec 2022 03:29:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670239751; cv=none; d=google.com; s=arc-20160816; b=AGel2TuhQED1Uwga9KvRRFafC5LYF8wCGBxsoyFM+lc8TFpb8ga+f8Y57C/07rTaSV KjM/0gbbVIhTQslzBbjg6Lgn7Vb2lSd0jVsmz6+m4mabQY5+QYaCHfiI4MCwRh9WLi+6 ia7fyOYBDP+nw5pyCuZjLktONaBxbjJkR4nkySAu55gaqU8oEXeHRrPZvRVNV4MXdhac B0EXLPjpx9YviTkr1Xl/I/R4qQaKcUAsjU/fCg5N/YYYDNv58eoczl2fjWO3etuSCVOD v1e8zDZPyufhy+sWtY4VyG7e0R/YcgRxetRjOWQZK6E9oy5lAUQ8WI8k888APUpJARNt Daew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=92P2/xusQKF0kFjWRakiZu3X6n/dgXLRK/m2ypB/UK0=; b=ygxG/N5QnYuIg2EDJh7BIw2hBhTGlE9Gfo8lsu87GJUte3dAAiSrZinaHDE62ZJwRr B/lq8HidTZV622LNlTNbjwPn+/JPnT0qvK5UWzRMHFzdNYpeneNy6QI0EjEWiEdU+Rn9 2OI67FerxhLBzRvA9xoffIWaK5d8OPFinZjgyxDqEc94wntHtxLAtLkuqpsRKZGWkcpV hShCAdt+VXCTvqmNwNQebLGkVSXSgmcy09yPt0oHSPRc6eDmbIVc0fnUNSGNgk1vawMp qlmAjMYxk6RJxgIdQetz5EKbw0RjV+1PR7ZyZ7ABp45Yr2EgDG0VCWddAYrGGQdTTxHy 9dZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 21-20020a631355000000b00450283e2ae6si14811666pgt.623.2022.12.05.03.28.57; Mon, 05 Dec 2022 03:29:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230179AbiLELTK (ORCPT + 99 others); Mon, 5 Dec 2022 06:19:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbiLELTI (ORCPT ); Mon, 5 Dec 2022 06:19:08 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 896F117599; Mon, 5 Dec 2022 03:19:02 -0800 (PST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NQgzT1CFWz5BNRf; Mon, 5 Dec 2022 19:19:01 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl2.zte.com.cn with SMTP id 2B5BIrxN064224; Mon, 5 Dec 2022 19:18:53 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Mon, 5 Dec 2022 19:18:56 +0800 (CST) Date: Mon, 5 Dec 2022 19:18:56 +0800 (CST) X-Zmail-TransId: 2af9638dd3a0ffffffffe4ece7e0 X-Mailer: Zmail v1.0 Message-ID: <202212051918564721658@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , , , Subject: =?utf-8?q?=5BPATCH_net-next=5D_net=3A_ethernet=3A_use_sysfs=5Femit?= =?utf-8?q?=28=29_to_instead_of_scnprintf=28=29?= X-MAIL: mse-fl2.zte.com.cn 2B5BIrxN064224 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 638DD3A5.000 by FangMail milter! X-FangMail-Envelope: 1670239141/4NQgzT1CFWz5BNRf/638DD3A5.000/10.5.228.133/[10.5.228.133]/mse-fl2.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 638DD3A5.000/4NQgzT1CFWz5BNRf X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751373317584165538?= X-GMAIL-MSGID: =?utf-8?q?1751373317584165538?= From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen Reviewed-by: Leon Romanovsky --- net/ethernet/eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c index e02daa74e833..2edc8b796a4e 100644 --- a/net/ethernet/eth.c +++ b/net/ethernet/eth.c @@ -398,7 +398,7 @@ EXPORT_SYMBOL(alloc_etherdev_mqs); ssize_t sysfs_format_mac(char *buf, const unsigned char *addr, int len) { - return scnprintf(buf, PAGE_SIZE, "%*phC\n", len, addr); + return sysfs_emit(buf, "%*phC\n", len, addr); } EXPORT_SYMBOL(sysfs_format_mac);