From patchwork Mon Dec 5 14:59:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keith Busch X-Patchwork-Id: 29718 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2314493wrr; Mon, 5 Dec 2022 07:19:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf5YKW2/FoBpylKyU2AcFAMadSowyuTw233y1m+95bFgsXVRnlvMobnx64cvCYm5TRxeYH2U X-Received: by 2002:a05:6402:3892:b0:454:cbef:c161 with SMTP id fd18-20020a056402389200b00454cbefc161mr57497407edb.365.1670253582273; Mon, 05 Dec 2022 07:19:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670253582; cv=none; d=google.com; s=arc-20160816; b=jRDCp2o5EMRHwZDyfnR5i5fSKOMGslM1MZxGqfJoRJUEnZsN/LKgYeRphHyP6MDe6M 2Ek63m7meSwBHhdSJyAwxPpU1MIhRDYD4+/RgstPqB7alor/7Mzjp62g0DRN+MvrUWL0 h5doeabL3RfGkfzuRGFnT/2m5eaf27SYF3dnY/+MTaKcACTMO5clLhMmyvChG9QBbYtS N3T+5JoexRjYepfAFLYbJCH9jP+hJpXeDUnHQKhAZ2rjd1c3atZxW9GrfIERNtUZwMLy N12MrswCKiE+IAvcR13pxFDlkGDVMJj92rPpTgFx+SXBRvNAwrlSvnswH80JIj9Nq1xs Enog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MLWHDUS20C0jmHJ39hBO1H02jIUsWm5bZEXT2SOrcPk=; b=mw0qLkxA1ZGNojmgife2doRynw3yxi8XDOGi4ArLhUdcPTPhHliuGuZJMchQpp58yV Ig/Al/gYBEChTMXSFWJ8/ZBy48fbENJK4ELCiLo9oRs6raXWT7f850EYRsh1sVTGfqJD QB7lgiQ/wGbvjpzeeXA58gQfvpM9gatktcFmefUWgalvD/V9Q8JMiur+aeNYWdsaW70p XcAdMhMIbkzqe/byJuEHNq0Ph2XnC7z14A+/kcFcGFrAbzsMD+kpaka2P7CouzzzOOjN Fq3GU7smNPYbKv0qBqx4hJjLQyWG69b+ih8Bg4hg3GXhUEI9eWrnYLfkn71+kxtb7agT kC7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@meta.com header.s=s2048-2021-q4 header.b=ejYF75fU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=meta.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds15-20020a170907724f00b007ae165c79c8si12772838ejc.940.2022.12.05.07.19.17; Mon, 05 Dec 2022 07:19:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@meta.com header.s=s2048-2021-q4 header.b=ejYF75fU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=meta.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231829AbiLEPOR (ORCPT + 99 others); Mon, 5 Dec 2022 10:14:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230522AbiLEPNe (ORCPT ); Mon, 5 Dec 2022 10:13:34 -0500 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8340D5F84 for ; Mon, 5 Dec 2022 07:13:27 -0800 (PST) Received: from pps.filterd (m0044010.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B51d4Sq028659 for ; Mon, 5 Dec 2022 07:13:26 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=MLWHDUS20C0jmHJ39hBO1H02jIUsWm5bZEXT2SOrcPk=; b=ejYF75fU7LKM8wl5jpImHC6ob7OmFqntqgSVGc7q7fBRtNTo2YbmogV9/hYldchrM5wM G0+tjYboDIyd5JbXawla0H4uvIOtKIYTIurU5zdZBP0kxApMAZGRIOvXKAig2QNU3KMf eIiafVB8VOpgv6FqOoo28oMSYTlMz1YLZA6rOqxa7tMTjf+eHGdJuwl4dbcwngVrLne1 l16/SnAwj5orN2eNpyh6zDEi0moXxB76qmVzGa0EU66PzkXkQAohAew/QcGDljqEA6kz WusGmDZ0R0+69WEmS1e817ytYI09qRBuM4V9W9N5PPvhKdasT7p0qd7KndjZCpcdkU7Z yw== Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3m82ntv1f1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 05 Dec 2022 07:13:26 -0800 Received: from twshared0551.06.ash8.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:83::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 5 Dec 2022 07:13:24 -0800 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id 6027CC6156E3; Mon, 5 Dec 2022 07:00:09 -0800 (PST) From: Keith Busch To: , , Matthew Wilcox CC: Tony Battersby , Keith Busch Subject: [PATCH 03/11] dmapool: use sysfs_emit() instead of scnprintf() Date: Mon, 5 Dec 2022 06:59:29 -0800 Message-ID: <20221205145937.54367-4-kbusch@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221205145937.54367-1-kbusch@meta.com> References: <20221205145937.54367-1-kbusch@meta.com> MIME-Version: 1.0 X-FB-Internal: Safe X-Proofpoint-ORIG-GUID: gIKqeh2PxnGikkroHP_deWhRD57Zjpuo X-Proofpoint-GUID: gIKqeh2PxnGikkroHP_deWhRD57Zjpuo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-05_01,2022-12-05_01,2022-06-22_01 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751387820076889007?= X-GMAIL-MSGID: =?utf-8?q?1751387820076889007?= From: Tony Battersby Use sysfs_emit instead of scnprintf, snprintf or sprintf. Signed-off-by: Tony Battersby Signed-off-by: Keith Busch --- mm/dmapool.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index 559207e1c3339..20616b760bb9c 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -64,18 +64,11 @@ static DEFINE_MUTEX(pools_reg_lock); static ssize_t pools_show(struct device *dev, struct device_attribute *attr, char *buf) { - unsigned temp; - unsigned size; - char *next; + int size; struct dma_page *page; struct dma_pool *pool; - next = buf; - size = PAGE_SIZE; - - temp = scnprintf(next, size, "poolinfo - 0.1\n"); - size -= temp; - next += temp; + size = sysfs_emit(buf, "poolinfo - 0.1\n"); mutex_lock(&pools_lock); list_for_each_entry(pool, &dev->dma_pools, pools) { @@ -90,16 +83,14 @@ static ssize_t pools_show(struct device *dev, struct device_attribute *attr, cha spin_unlock_irq(&pool->lock); /* per-pool info, no real statistics yet */ - temp = scnprintf(next, size, "%-16s %4u %4zu %4zu %2u\n", - pool->name, blocks, - pages * (pool->allocation / pool->size), - pool->size, pages); - size -= temp; - next += temp; + size += sysfs_emit_at(buf, size, "%-16s %4u %4zu %4zu %2u\n", + pool->name, blocks, + pages * (pool->allocation / pool->size), + pool->size, pages); } mutex_unlock(&pools_lock); - return PAGE_SIZE - size; + return size; } static DEVICE_ATTR_RO(pools);